fix #55972: Erroneous self arguments on bare functions emit subpar compilation error #56002
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
lcnr
changed the title
|
should work, still need to improve the Error message |
|
In my opinion it is not worth to handle invalid uses of |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
|
📌 Commit 5bfdcc1 has been approved by |
bors
added
S-waiting-on-bors
| impl Foo { | ||
| fn c(foo: u32, self) {} | ||
| //~^ ERROR unexpected `self` argument in function | ||
| //~| NOTE `self` is only valid as the first argument of a trait function |
There was a problem hiding this comment.
Since this is a function in an inherent impl, it would be nice if the error could emphasize here that the problem is that it must be the first argument.
There was a problem hiding this comment.
In my opinion it is not worth to handle invalid uses of self differently. To implement this I would probably change parse_arg_general(&mut self, require_name: bool) to parse_arg_general(&mut self, require_name: bool, is_bare_fn: bool), which is somewhat ugly.
I did think about simple ways to check if we currently parse a associated function but did not find one.
There was a problem hiding this comment.
It's not a big deal, but still would be nice.
But I am not knowledgeable in the relevant APIs either.^^
|
@bors r+ |
|
📌 Commit 88d6094 has been approved by |
fix rust-lang#55972: Erroneous self arguments on bare functions emit subpar compilation error rust-lang#55972 r? @estebank
Rollup of 11 pull requests Successful merges: - #55367 (lint if a private item has doctests) - #55485 (Return &T / &mut T in ManuallyDrop Deref(Mut) impl) - #55784 (Clarifying documentation for collections::hash_map::Entry::or_insert) - #55961 (Fix VecDeque pretty-printer) - #55980 (Suggest on closure args count mismatching with pipe span) - #56002 (fix #55972: Erroneous self arguments on bare functions emit subpar compilation error) - #56063 (Update any.rs documentation using keyword dyn) - #56067 (Add SGX target to rustc) - #56078 (Fix error message for `-C panic=xxx`.) - #56106 (Remove some incorrect doc comments) - #56126 (core/benches/num: Add `from_str/from_str_radix()` benchmarks) Failed merges: r? @ghost
#55972
r? @estebank