Rollup of 11 pull requests #56155
Merged
Rollup of 11 pull requests #56155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the generated documentation looks like this:
fn deref(&self) -> &<ManuallyDrop<T> as Deref>::Target
Returning the actual type directly makes the generated docs more clear:
fn deref(&self) -> &T
Previous version does not show that or_insert does not insert the passed value, as the passed value was the same value as what was already in the map.
This fixes the VecDeque pretty-printer to handle cases where head < tail. Closes rust-lang#55944
…t-lint, r=QuietMisdreavus lint if a private item has doctests Fixes rust-lang#55333. r? @QuietMisdreavus
…f, r=TimNN
Return &T / &mut T in ManuallyDrop Deref(Mut) impl
Without this change the generated documentation looks like this:
fn deref(&self) -> &<ManuallyDrop<T> as Deref>::Target
Returning the actual type directly makes the generated docs more clear:
fn deref(&self) -> &T
Basically, compare how the impl for `Box<T>` and `ManuallyDrop<T>` looks in this screenshot:
Clarifying documentation for collections::hash_map::Entry::or_insert Previous version does not show that or_insert does not insert the passed value, as the passed value was the same value as what was already in the map.
…tsakis Fix VecDeque pretty-printer This fixes the VecDeque pretty-printer to handle cases where head < tail. Closes rust-lang#55944
Suggest on closure args count mismatching with pipe span Closes rust-lang#55891 r? @estebank
fix rust-lang#55972: Erroneous self arguments on bare functions emit subpar compilation error rust-lang#55972 r? @estebank
Update any.rs documentation using keyword dyn This will fix rust-lang#56062.
…crichton Add SGX target to rustc This adds the `x86_64-fortanix-unknown-sgx` target specification to the Rust compiler. See rust-lang#56066 for more details about this target.
…hton Fix error message for `-C panic=xxx`. Fixes rust-lang/cargo#6334
Remove some incorrect doc comments
core/benches/num: Add `from_str/from_str_radix()` benchmarks This was extracted from rust-lang#55973 /cc @alexcrichton
|
@bors: r+ p=11 |
|
📌 Commit 61d7b3e has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 22, 2018
Rollup of 11 pull requests Successful merges: - #55367 (lint if a private item has doctests) - #55485 (Return &T / &mut T in ManuallyDrop Deref(Mut) impl) - #55784 (Clarifying documentation for collections::hash_map::Entry::or_insert) - #55961 (Fix VecDeque pretty-printer) - #55980 (Suggest on closure args count mismatching with pipe span) - #56002 (fix #55972: Erroneous self arguments on bare functions emit subpar compilation error) - #56063 (Update any.rs documentation using keyword dyn) - #56067 (Add SGX target to rustc) - #56078 (Fix error message for `-C panic=xxx`.) - #56106 (Remove some incorrect doc comments) - #56126 (core/benches/num: Add `from_str/from_str_radix()` benchmarks) Failed merges: r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-C panic=xxx. #56078 (Fix error message for-C panic=xxx.)from_str/from_str_radix()benchmarks #56126 (core/benches/num: Addfrom_str/from_str_radix()benchmarks)Failed merges:
r? @ghost