Prevent cache issues on version updates #58848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I presume you'll want to beta backport as well, but I'll leave that to the rustdoc and/or docs team to decide. @bors r+ |
|
📌 Commit 196e021 has been approved by |
bors
added
S-waiting-on-bors
QuietMisdreavus
added
beta-nominated
|
Beta-nominating since this fixes an issue we've had with docs version upgrades on the site for ages. @rust-lang/docs, would anyone like to approve the backport? |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 11, 2019
…Mark-Simulacrum Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
GuillaumeGomez
force-pushed
the
fix-cache-issues
branch
from
862103b to
5652dd6
Compare
|
Ok, it was the index generator generation which failed because the theme files didn't receive the suffix. Fixed now that we can move on! @bors: r=Mark-Simulacrum,ollie27 |
|
📌 Commit 5652dd6 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 28, 2019
…Mark-Simulacrum,ollie27 Prevent cache issues on version updates Fixes rust-lang#58827. cc @rust-lang/infra
bors
added a commit
that referenced
this pull request
Mar 28, 2019
Rollup of 12 pull requests Successful merges: - #57987 (Fix some AArch64 typos) - #58581 (Refactor generic parameter encoder functions) - #58803 (fs::copy() unix: set file mode early) - #58848 (Prevent cache issues on version updates) - #59198 (Do not complain about unmentioned fields in recovered patterns) - #59351 (Include llvm-ar with llvm-tools component) - #59413 (HirIdify hir::ItemId) - #59441 (Remove the block on natvis for lld-link.) - #59448 (Use consistent phrasing for all macro summaries) - #59456 (Add documentation about `for` used as higher ranked trait bounds) - #59472 (Document that `std::io::BufReader` discards contents on drop) - #59474 (Fix link capitalization in documentation of std::io::BufWriter.) Failed merges: r? @ghost
|
Ping @rust-lang/docs @rust-lang/rustdoc this needs to be approved for beta backport. |
|
I approve for it. cc @QuietMisdreavus |
pietroalbini
added
the
beta-accepted
pietroalbini
removed
the
beta-nominated
pietroalbini
added
the
beta-nominated
|
This was removed from the backport since it caused a build failure. |
bors
added a commit
that referenced
this pull request
Apr 8, 2019
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted * #59499: Fix broken download link in the armhf-gnu image * #58330: Add rustdoc JS non-std tests * #58848: Prevent cache issues on version updates r? @ghost
pietroalbini
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58827.
cc @rust-lang/infra