-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HirIdify hir::ItemId #59413
HirIdify hir::ItemId #59413
Conversation
Oh, sweet - you were able to crack it 👍. |
@bors r+ |
📌 Commit cb4ac71 has been approved by |
@ljedrz Let's see if the tests pass before celebrating =P |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r- |
I see impl Trait and async stuff also create items, so I guess I have to allocate the HIR counters for those too. |
I changed the code to allocate the HIR id counters on demand. That seem to suffice for impl Trait, since it doesn't also create new |
@bors r+ |
📌 Commit f7c66fb has been approved by |
HirIdify hir::ItemId Version of rust-lang#59092. r? @oli-obk
Rollup of 12 pull requests Successful merges: - #57987 (Fix some AArch64 typos) - #58581 (Refactor generic parameter encoder functions) - #58803 (fs::copy() unix: set file mode early) - #58848 (Prevent cache issues on version updates) - #59198 (Do not complain about unmentioned fields in recovered patterns) - #59351 (Include llvm-ar with llvm-tools component) - #59413 (HirIdify hir::ItemId) - #59441 (Remove the block on natvis for lld-link.) - #59448 (Use consistent phrasing for all macro summaries) - #59456 (Add documentation about `for` used as higher ranked trait bounds) - #59472 (Document that `std::io::BufReader` discards contents on drop) - #59474 (Fix link capitalization in documentation of std::io::BufWriter.) Failed merges: r? @ghost
Version of #59092.
r? @oli-obk