Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak unresolved label suggestion #59697

Merged
merged 1 commit into from
Apr 25, 2019
Merged

tweak unresolved label suggestion #59697

merged 1 commit into from
Apr 25, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Apr 4, 2019

Only suggest label names in the same hygiene context, and use a
structured suggestion.

Question for reviewer: Is this the right way to check for label hygiene?

Only suggest label names in the same hygiene context, and use a
structured suggestion.
@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2019
@zackmdavis
Copy link
Member

(My review turnaround time has not been super-great lately; let me make sure to look/think about this the evening (UTC−7) of Tuesday the ninth)

@zackmdavis
Copy link
Member

or the tenth

@Dylan-DPC-zz
Copy link

ping from triage @zackmdavis any updates?

@zackmdavis
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2019

📌 Commit 3b686d5 has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 25, 2019
tweak unresolved label suggestion

Only suggest label names in the same hygiene context, and use a
structured suggestion.

Question for reviewer: Is this the right way to check for label hygiene?
bors added a commit that referenced this pull request Apr 25, 2019
Rollup of 6 pull requests

Successful merges:

 - #59560 (MIR generation cleanup)
 - #59697 (tweak unresolved label suggestion)
 - #60038 (Add codegen test for PGO instrumentation.)
 - #60160 (Fix #58270, fix off-by-one error in error diagnostics.)
 - #60185 (Reexport IntErrorKind in std)
 - #60243 (Add regression test for #53249.)

Failed merges:

r? @ghost
@bors bors merged commit 3b686d5 into rust-lang:master Apr 25, 2019
@bors
Copy link
Contributor

bors commented Apr 25, 2019

⌛ Testing commit 3b686d5 with merge 9aea116...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants