improve pinning projection docs #61878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Cc @Centril you usually have a bunch of feedback on these ;) |
Centril
reviewed
Jun 18, 2019
|
@RalfJung Looks good aside from a few nits ^--- |
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
|
@rust-lang/libs this still awaits review. |
RalfJung
added
T-libs-api
|
@withoutboats could you maybe help review this? |
Dylan-DPC-zz
approved these changes
Jun 26, 2019
|
@bors: r=me |
|
@bors r+ |
|
📌 Commit bf03a3c has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
@bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
improve pinning projection docs This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182). Fixes rust-lang#61272.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
improve pinning projection docs This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182). Fixes rust-lang#61272.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
improve pinning projection docs This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182). Fixes rust-lang#61272.
bors
added a commit
that referenced
this pull request
Jun 28, 2019
Rollup of 16 pull requests Successful merges: - #61878 (improve pinning projection docs) - #62043 (Remove `FnBox`) - #62067 (Add suggestion for missing `.await` keyword) - #62076 (Updated RELEASES.md for 1.36.0) - #62102 (call out explicitly that general read needs to be called with an initialized buffer) - #62106 (Add more tests for async/await) - #62124 (refactor lexer to use idiomatic borrowing) - #62131 (libsyntax: Fix some Clippy warnings) - #62152 (Don't ICE on item in `.await` expression) - #62154 (Remove old fixme) - #62155 (Add regression test for MIR drop generation in async loops) - #62156 (Update books) - #62160 (Remove outdated question_mark_macro_sep lint) - #62164 (save-analysis: use buffered writes) - #62171 (rustc: Retry SIGILL linker invocations) - #62176 (Update RLS) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to improve the explanation of structural pinning and pinning projections based on this URLO thread.
Fixes #61272.