Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for MIR drop generation in async loops #62155

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Jun 26, 2019

Fixes #61986.

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2019
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me rollup with nits.

src/test/ui/async-await/issues/issue-61986.rs Outdated Show resolved Hide resolved
src/test/ui/async-await/issues/issue-61986.rs Outdated Show resolved Hide resolved
src/test/ui/async-await/issues/issue-61986.rs Outdated Show resolved Hide resolved
@cramertj
Copy link
Member Author

@bors r=centril rollup

@bors
Copy link
Contributor

bors commented Jun 26, 2019

📌 Commit 72ca844 has been approved by centril

@bors
Copy link
Contributor

bors commented Jun 26, 2019

🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Add regression test for MIR drop generation in async loops

Fixes rust-lang#61986.

r? @Centril
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Add regression test for MIR drop generation in async loops

Fixes rust-lang#61986.

r? @Centril
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Add regression test for MIR drop generation in async loops

Fixes rust-lang#61986.

r? @Centril
Centril added a commit to Centril/rust that referenced this pull request Jun 27, 2019
Add regression test for MIR drop generation in async loops

Fixes rust-lang#61986.

r? @Centril
bors added a commit that referenced this pull request Jun 28, 2019
Rollup of 16 pull requests

Successful merges:

 - #61878 (improve pinning projection docs)
 - #62043 (Remove `FnBox`)
 - #62067 (Add suggestion for missing `.await` keyword)
 - #62076 (Updated RELEASES.md for 1.36.0)
 - #62102 (call out explicitly that general read needs to be called with an initialized buffer)
 - #62106 (Add more tests for async/await)
 - #62124 (refactor lexer to use idiomatic borrowing)
 - #62131 (libsyntax: Fix some Clippy warnings)
 - #62152 (Don't ICE on item in `.await` expression)
 - #62154 (Remove old fixme)
 - #62155 (Add regression test for MIR drop generation in async loops)
 - #62156 (Update books)
 - #62160 (Remove outdated question_mark_macro_sep lint)
 - #62164 (save-analysis: use buffered writes)
 - #62171 (rustc: Retry SIGILL linker invocations)
 - #62176 (Update RLS)

Failed merges:

r? @ghost
@bors bors merged commit 72ca844 into rust-lang:master Jun 28, 2019
@cramertj cramertj deleted the 61872 branch June 28, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE compiling with futures compat
4 participants