-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve -Ztime-passes #62110
Improve -Ztime-passes #62110
Conversation
454167c
to
27e3b06
Compare
27e3b06
to
f05bd80
Compare
@Zoxc: new code is up. It addresses some of your comments, but not all, as per the discussions above. I think it's a clear improvement over the status quo, see what you think. |
@Zoxc: what do you think about the latest code? |
f05bd80
to
2b749f1
Compare
@Zoxc: I updated the code to use the |
2b749f1
to
7f1671e
Compare
7f1671e
to
718a7c7
Compare
☔ The latest upstream changes (presumably #61775) made this pull request unmergeable. Please resolve the merge conflicts. |
…s` output. Because it pollutes the output with hundreds or thousands of uninteresting lines for which the time duration is always(?) 0.000s.
This is useful for getting the total compilation time at the end. To do this, the patch changes `print_time_passes_entry` to not increment the depth, which means that `print_time_passes_entry_internal` is no longer needed.
718a7c7
to
87b103d
Compare
@Zoxc: I have rebased. As far as I can tell, I have addressed all your concerns and answered all your questions. I think it's ready to land. |
@bors r+ I think we could probably just remove the indentation support. It's broken for LLVM and for the parallel compiler anyway. |
📌 Commit 87b103d has been approved by |
The indentation is crucial to understand which passes are sub-passes. I understand it's broken for the back-end, but even then it's still highly useful for the other passes. |
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
Rollup of 13 pull requests Successful merges: - #61545 (Implement another internal lints) - #62110 (Improve -Ztime-passes) - #62133 (Feature gate `rustc` attributes harder) - #62158 (Add MemoryExtra in InterpretCx constructor params) - #62168 (The (almost) culmination of HirIdification) - #62193 (Create async version of the dynamic-drop test) - #62369 (Remove `compile-pass` from compiletest) - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.) - #62381 (Fix a typo in Write::write_vectored docs) - #62390 (Update README.md) - #62396 (remove Scalar::is_null_ptr) - #62406 (Lint on invalid values passed to x.py --warnings) - #62414 (Remove last use of mem::uninitialized in SGX) Failed merges: r? @ghost
Two improvements that make
-Ztime-passes
more useful.r? @Zoxc