Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compile-pass from compiletest #62369

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Remove compile-pass from compiletest #62369

merged 4 commits into from
Jul 5, 2019

Conversation

JohnTitor
Copy link
Member

This is a part of #62277.
Removes compile-pass from compiletest (and modify some tests' annotations).

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2019
@JohnTitor
Copy link
Member Author

Should we also modify these lines?

rust/src/librustc_mir/error_codes.rs

Line 334 in b43eb42

```compile_pass

rust/src/librustc_mir/error_codes.rs

Line 363 in b43eb42

```compile_pass,no_run

@Centril
Copy link
Contributor

Centril commented Jul 4, 2019

Should we also modify these lines?

Not sure; r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned Centril Jul 4, 2019
@petrochenkov
Copy link
Contributor

@JohnTitor
Could you update rustc-guide to not mention compile-pass as well before this is merged?

Should we also modify these lines?

As I understand, those ```compile_pass annotations are just mistakes and have no effect.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2019
@JohnTitor
Copy link
Member Author

@petrochenkov I opened rust-lang/rustc-dev-guide#380 , could you review it?

As I understand, those ```compile_pass annotations are just mistakes and have no effect.

Okay, I don't touch this time.

@petrochenkov petrochenkov mentioned this pull request Jul 4, 2019
Merged
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 4, 2019 •
edited
Loading

Okay, I don't touch this time.

Why not?

I opened rust-lang/rustc-dev-guide#380 , could you review it?

Could you update the rustc-guide submodule in this PR.

@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 4, 2019 •
edited
Loading

Why not?

Okay, I'll fix, we should only remove compile-pass from them, right?

@JohnTitor
Copy link
Member Author

removed compile_pass annotations and updated rustc-guide

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 4, 2019

📌 Commit 3adad33 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62369 - JohnTitor:remove-compile-pass, r=pe…
e142410 
…trochenkov

Remove `compile-pass` from compiletest

This is a part of rust-lang#62277.
Removes `compile-pass` from compiletest (and modify some tests' annotations).

r? @Centril
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 5, 2019

@bors r-

The test ui/async-await/async-closure-matches-expr.rs needs to be updated to use // build-pass.
Sorry about that!

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2019
@JohnTitor
Copy link
Member Author

@Centril Don't worry, I modified test annotation to build-pass.

@Centril
Copy link
Contributor

Centril commented Jul 5, 2019

Thanks! @bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Jul 5, 2019

📌 Commit 1640ab2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62369 - JohnTitor:remove-compile-pass, r=pe…
07505c9 
…trochenkov

Remove `compile-pass` from compiletest

This is a part of rust-lang#62277.
Removes `compile-pass` from compiletest (and modify some tests' annotations).

r? @Centril
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62369 - JohnTitor:remove-compile-pass, r=pe…
216a187 
…trochenkov

Remove `compile-pass` from compiletest

This is a part of rust-lang#62277.
Removes `compile-pass` from compiletest (and modify some tests' annotations).

r? @Centril
@Centril Centril mentioned this pull request Jul 5, 2019
Merged
bors added a commit that referenced this pull request Jul 5, 2019
@bors
Auto merge of #62419 - Centril:rollup-82umycq, r=Centril
481068a 
Rollup of 13 pull requests

Successful merges:

 - #61545 (Implement another internal lints)
 - #62110 (Improve -Ztime-passes)
 - #62133 (Feature gate `rustc` attributes harder)
 - #62158 (Add MemoryExtra in InterpretCx constructor params)
 - #62168 (The (almost) culmination of HirIdification)
 - #62193 (Create async version of the dynamic-drop test)
 - #62369 (Remove `compile-pass` from compiletest)
 - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.)
 - #62381 (Fix a typo in Write::write_vectored docs)
 - #62390 (Update README.md)
 - #62396 (remove Scalar::is_null_ptr)
 - #62406 (Lint on invalid values passed to x.py --warnings)
 - #62414 (Remove last use of mem::uninitialized in SGX)

Failed merges:

r? @ghost
@bors bors merged commit 1640ab2 into rust-lang:master Jul 5, 2019
@JohnTitor JohnTitor deleted the remove-compile-pass branch July 8, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnTitor @Centril @petrochenkov @bors @rust-highfive