Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reliance on await!(...) macro #62324

Merged
merged 3 commits into from
Jul 5, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 3, 2019

Only the last commit is new.

r? @cramertj

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2019
@bors

This comment has been minimized.

@cramertj
Copy link
Member

cramertj commented Jul 3, 2019

r=me with rebase (and once the async closures change merges, since this is based on that)

@Centril Centril force-pushed the reduce-await-macro-reliance branch from 62725b6 to 3eef0cb Compare July 3, 2019 22:26
@Centril
Copy link
Contributor Author

Centril commented Jul 3, 2019

@bors r=cramertj

(#62292 hasn't landed yet but they don't conflict since the commits are the same thanks to --onto).

@bors
Copy link
Contributor

bors commented Jul 3, 2019

📌 Commit 3eef0cb has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 4, 2019
…, r=cramertj

Reduce reliance on `await!(...)` macro

Only the last commit is new.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jul 4, 2019
…, r=cramertj

Reduce reliance on `await!(...)` macro

Only the last commit is new.

r? @cramertj
"`let` expressions in this position are experimental"
));

for_each_in_lock(&sess.async_closure_spans, |span| gate_feature!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are these not for loops?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's terser and has less repetition this way and I don't really fancy for loops since they invite using break and continue which seems preferable to avoid if possible in favor of a more functional-ish approach.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019
…, r=cramertj

Reduce reliance on `await!(...)` macro

Only the last commit is new.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
…, r=cramertj

Reduce reliance on `await!(...)` macro

Only the last commit is new.

r? @cramertj
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
…, r=cramertj

Reduce reliance on `await!(...)` macro

Only the last commit is new.

r? @cramertj
bors added a commit that referenced this pull request Jul 5, 2019
Rollup of 10 pull requests

Successful merges:

 - #62123 ( Remove needless lifetimes (std))
 - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.)
 - #62169 (Derive which queries to save using the proc macro)
 - #62238 (Fix code block information icon position)
 - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`)
 - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned)
 - #62324 (Reduce reliance on `await!(...)` macro)
 - #62371 (Add tracking issue for Box::into_pin)
 - #62383 (Improve error span for async type inference error)
 - #62388 (Break out of the correct number of scopes in loops)

Failed merges:

r? @ghost
@bors bors merged commit 3eef0cb into rust-lang:master Jul 5, 2019
@Centril Centril deleted the reduce-await-macro-reliance branch July 5, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants