Unsupport the await!(future) macro
#62293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
FYI I'd personally love it if we could hold off on landing this until after I've had a chance to get Fuchsia updated, which has been blocked on #62088 (which should now be addressed once #62287 lands). With out it, I can't do a gradual transition, and it's a great deal of coordination and effort to make the change across multiple repos at once. That said, if someone's dying to have this land (e.g. if it significantly improves diagnostics or something) then I can deal with it ;) |
|
@cramertj That's fine by me; I'll split out a PR from this one to switch all testing as much as possible to EDIT: Tomorrow... 😴 time. |
|
Lifted out parts of this PR into #62324. |
Centril
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
2 times, most recently
from
f2a4015 to
cd89106
Compare
|
Rebased atop of #62324 (still blocked on things mentioned in #62293 (comment) tho). |
|
#62287 has landed. |
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
from
cd89106 to
6b14c32
Compare
|
Rebased and the tests pass now. @cramertj How is the update going for Fuchsia? |
|
@Centril Toolstate is currently broken. I'll follow up here when this can land safely. |
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
2 times, most recently
from
67d5342 to
7ef821c
Compare
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
from
7ef821c to
8a0dcfb
Compare
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
from
8a0dcfb to
02bb3a7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
remove-await-macro
branch
from
c4141f9 to
b21f0a3
Compare
|
I've successfully rolled the toolchain in fuchsia and we're actively migrating to @bors r+ |
|
📌 Commit b21f0a3 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 30, 2019
Unsupport the `await!(future)` macro Unsupport the `await!(future)` "macro" and recognize it in error recovery instead. The `future.await` syntax has been on nightly since 2019-05-08. This was 55 days ago which is 1.31 releases ago. Closes rust-lang#60610. r? @cramertj
bors
added a commit
that referenced
this pull request
Jul 30, 2019
Rollup of 7 pull requests Successful merges: - #62293 (Unsupport the `await!(future)` macro) - #62469 (Add doc links to liballoc crate page) - #63095 (Turn `INCOMPLETE_FEATURES` into lint) - #63117 (Use global variable 'environ' to pass environments to rtpSpawn) - #63123 (`const fn`-ify `std::any::type_name` as laid out in #63084) - #63129 (Subslice patterns: Test passing static & dynamic semantics.) - #63147 (Updated RELEASES.md for 1.37.0) Failed merges: r? @ghost
Xanewok
added a commit
to Xanewok/rustfmt
that referenced
this pull request
Aug 2, 2019
Adapting for changes due to rust-lang/rust#62293
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 5, 2019
This was missed in PR rust-lang#62293.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 5, 2019
…Centril Remove leftover AwaitOrigin This was missed in PR rust-lang#62293.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…Centril Remove leftover AwaitOrigin This was missed in PR rust-lang#62293.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…Centril Remove leftover AwaitOrigin This was missed in PR rust-lang#62293.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 6, 2019
…Centril Remove leftover AwaitOrigin This was missed in PR rust-lang#62293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupport the
await!(future)"macro" and recognize it in error recovery instead.The
future.awaitsyntax has been on nightly since 2019-05-08.This was 55 days ago which is 1.31 releases ago.
Closes #60610.
r? @cramertj