-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to newer nightly #1384
Conversation
`await_macro` feature has been removed in rust-lang/rust#62293.
This false positive has been fixed in rust-lang/rust-clippy#4266.
Lifetime elision in `Pin<&(mut) Self>` has been allowed in rust-lang/rust#61207.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Seems a rustfmt issue the same as #1335 (comment) is still happening (filed rust-lang/rustfmt#3725). I'm not sure about this issue... |
I will try to change the rustfmt version to stable or beta (if it does not break the format by doing that). |
@taiki-e can we stay on an older rust toolchain, I would rather like to stay on one whole chain than use parts. |
@LucioFranco I see. It seems a PR has been submitted to fix the issue, so I will wait for the release of new nightly that including the changes. |
await_macro
feature has been removed in Unsupport theawait!(future)
macro rust-lang/rust#62293.Pin<&(mut) Self>
has been allowed in Allow lifetime elision inPin<&(mut) Self>
rust-lang/rust#61207.