Change untagged_unions to not allow union fields with drop #62330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
added
A-destructors
|
Some changes occurred in diagnostic error codes |
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jul 3, 2019
|
cc tracking issue: #55149 |
SimonSapin
force-pushed
the
no-drop-in-union-fields
branch
from
a51a67a
to
81949b0
Compare
|
☔ The latest upstream changes (presumably #62419) made this pull request unmergeable. Please resolve the merge conflicts. |
SimonSapin
force-pushed
the
no-drop-in-union-fields
branch
from
81949b0
to
0951cca
Compare
|
r? @RalfJung |
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
reviewed
Jul 14, 2019
RalfJung
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #63029) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping from triage: @SimonSapin, any updates on this? you should also resolve conflicts. |
SimonSapin
force-pushed
the
no-drop-in-union-fields
branch
from
0951cca
to
d2a4d57
Compare
|
Rebased, but I’m not the original author of this code so I feel I’m not able to answer some of the review comments. I’d appreciate if someone more familiar with compiler internals is willing to take over. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
force-pushed
the
no-drop-in-union-fields
branch
from
f8b45dd
to
bb5a652
Compare
|
That fixes my reservations. :) Let's finally do this... thanks to everyone involved! @bors r+ |
|
📌 Commit 875bdd5 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 875bdd5 with merge da66b096c142097755e3474b7f1b3f2dafd61f9a... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 21, 2019
… r=RalfJung Change untagged_unions to not allow union fields with drop This is a rebase of rust-lang#56440, massaged to solve merge conflicts and make the test suite pass. Change untagged_unions to not allow union fields with drop Union fields may now never have a type with attached destructor. This for example allows unions to use arbitrary field types only by wrapping them in `ManuallyDrop` (or similar). The stable rule remains, that union fields must be `Copy`. We use the new rule for the `untagged_union` feature. Tracking issue: rust-lang#55149
|
@bors retry rolled up. |
|
⌛ Testing commit 875bdd5 with merge b3e8ca17bd0ec17cd42fb43f92ff37e4a72fa7b1... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 21, 2019
… r=RalfJung Change untagged_unions to not allow union fields with drop This is a rebase of rust-lang#56440, massaged to solve merge conflicts and make the test suite pass. Change untagged_unions to not allow union fields with drop Union fields may now never have a type with attached destructor. This for example allows unions to use arbitrary field types only by wrapping them in `ManuallyDrop` (or similar). The stable rule remains, that union fields must be `Copy`. We use the new rule for the `untagged_union` feature. Tracking issue: rust-lang#55149
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Oct 22, 2019
Rollup of 7 pull requests Successful merges: - #62330 (Change untagged_unions to not allow union fields with drop) - #65092 (make is_power_of_two a const function) - #65621 (miri: add write_bytes method to Memory doing bounds-checks and supporting iterators) - #65647 (Remove unnecessary trait bounds and derivations) - #65653 (keep the root dir clean from debugging) - #65660 (Rename `ConstValue::Infer(InferConst::Canonical(..))` to `ConstValue::Bound(..)`) - #65663 (Fix typo from #65214) Failed merges: r? @ghost
|
Awesome. Thanks to all that worked on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #56440, massaged to solve merge conflicts and make the test suite pass.
Change untagged_unions to not allow union fields with drop
Union fields may now never have a type with attached destructor. This for example allows unions to use arbitrary field types only by wrapping them in
ManuallyDrop(or similar).The stable rule remains, that union fields must be
Copy. We use the new rule for theuntagged_unionfeature.Tracking issue: #55149