Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change untagged_unions to not allow union fields with drop #62330

Merged
merged 20 commits into from
Oct 22, 2019
Merged

Change untagged_unions to not allow union fields with drop #62330

merged 20 commits into from
Oct 22, 2019

Commits on Oct 11, 2019

  1. Remove uses of allow(unions_with_drop_fields) in the standard library

    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    0a08841 View commit details
    Browse the repository at this point in the history

  2. Remove most uses of allow(unions_with_drop_fields) in tests

    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    84ca0a1 View commit details
    Browse the repository at this point in the history

  3. Change untagged_unions to not allow union fields with drop 

    Union fields may now never have a type with attached destructor.
This for example allows unions to use arbitrary field types only by
wrapping
them in ManuallyDrop.

The stable rule remains, that union fields must be Copy. We use the new
rule for the `untagged_union` feature.

See RFC 2514.

Note for ui tests:
We can't test move out through Box's deref-move since we can't
have a Box in a union anymore.
    @bluss @oli-obk
    bluss authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    2f0c821 View commit details
    Browse the repository at this point in the history

  4. Remove unions_with_drop_fields lint 

    Cases where it would trigger are now hard errors.
    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    fe13bbd View commit details
    Browse the repository at this point in the history

  5. Fixes rust-lang#41073, it is no longer an ICE

    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    e247a40 View commit details
    Browse the repository at this point in the history

  6. Update src/librustc_typeck/check/mod.rs 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @SimonSapin @Centril @oli-obk
    2 people authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    05a644e View commit details
    Browse the repository at this point in the history

  7. Update src/librustc_typeck/check/mod.rs 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @SimonSapin @Centril @oli-obk
    2 people authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    8c5ae86 View commit details
    Browse the repository at this point in the history

  8. Update src/librustc_typeck/error_codes.rs 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @SimonSapin @Centril @oli-obk
    2 people authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    0301eaf View commit details
    Browse the repository at this point in the history

  9. Update src/test/run-pass/union/union-nodrop.rs 

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    @SimonSapin @Centril @oli-obk
    2 people authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    bf25a9c View commit details
    Browse the repository at this point in the history

  10. More descriptive variable name

    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    fc512d2 View commit details
    Browse the repository at this point in the history

  11. Extend union-nodrop.rs test

    @SimonSapin @oli-obk
    SimonSapin authored and oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    616cf52 View commit details
    Browse the repository at this point in the history

  12. rpass tests are now part of ui tests

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    50ec10e View commit details
    Browse the repository at this point in the history

  13. Preserve originally intended test semantics

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    9c1ad0f View commit details
    Browse the repository at this point in the history

  14. Prefer ManuallyDrop::{take,new} over ptr::{read,write}

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    2fc257c View commit details
    Browse the repository at this point in the history

  15. Clarify a vague comment

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    fb23a5c View commit details
    Browse the repository at this point in the history

  16. Ensure we do not treat all unions as not having any drop glue.

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    7e1a65d View commit details
    Browse the repository at this point in the history

  17. Update ui stderr

    @oli-obk
    oli-obk committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    f5669eb View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Rebase fallout

    @oli-obk
    oli-obk committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    bb5a652 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Don't silently do nothing on mis_use of check_union_fields

    @oli-obk
    oli-obk committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    0653694 View commit details
    Browse the repository at this point in the history

  2. Report even duplilcate errors in case the feature gat is not active

    @oli-obk
    oli-obk committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    875bdd5 View commit details
    Browse the repository at this point in the history