Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass no_integrated_as option to llvm #62912

Closed
wants to merge 1 commit into from

Conversation

pftbest
Copy link
Contributor

@pftbest pftbest commented Jul 23, 2019

Workaround for #59077

cc @nikic

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2019
@nikic
Copy link
Contributor

nikic commented Jul 24, 2019

#62907 should also resolve the issue, so not sure if we want to change this.

@pftbest
Copy link
Contributor Author

pftbest commented Jul 24, 2019

@nikic ok, please close this if #62907 will solve the problem

@edmilsonefs
Copy link

Hey! This is a ping from triage, we would like to know if you @nikic could give us a few more minutes to update here so we can move forward.

Could you confirm if we can close here?

Thanks.

@edmilsonefs
Copy link

Hey! This is a ping from triage, we would like to know if you @nikic, @cr1901, @pftbest or @eddyb could give us a few more minutes to double check here so we can move forward.

It seems that #62907 got merged, Could any of you guys confirm if we can close here?

Thanks.

@pftbest
Copy link
Contributor Author

pftbest commented Aug 8, 2019

#59077 has been fixed with #62907, so this patch is no longer needed.

@pftbest pftbest closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants