Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the MSP430 AsmParser #62907

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jul 23, 2019

Hopefully fixes #59077.

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 23, 2019

📌 Commit 05be55b1442842a63fe00a3229e1258a87689efa has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-23T20:03:48.6651520Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-23T20:03:48.6833494Z ##[command]git config gc.auto 0
2019-07-23T20:03:48.6894760Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-23T20:03:48.6940819Z ##[command]git config --get-all http.proxy
2019-07-23T20:03:48.7081119Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62907/merge:refs/remotes/pull/62907/merge
---
2019-07-23T20:04:23.9258587Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-23T20:04:23.9258629Z 
2019-07-23T20:04:23.9258833Z   git checkout -b <new-branch-name>
2019-07-23T20:04:23.9258860Z 
2019-07-23T20:04:23.9258901Z HEAD is now at 0eab39b77 Merge 05be55b1442842a63fe00a3229e1258a87689efa into 299ef86e1f8b3e53154f834115752c719b611fa1
2019-07-23T20:04:23.9392732Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-23T20:04:23.9395525Z ==============================================================================
2019-07-23T20:04:23.9395583Z Task         : Bash
2019-07-23T20:04:23.9395648Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-23T20:33:00.5705594Z    Compiling tempfile v3.0.5
2019-07-23T20:34:03.0118175Z     Finished release [optimized] target(s) in 1m 24s
2019-07-23T20:34:03.0195221Z Assembling stage1 compiler (x86_64-unknown-linux-gnu)
2019-07-23T20:34:03.0221311Z Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-23T20:34:03.2305427Z error: process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc -vV` (exit code: 1)
2019-07-23T20:34:03.2305805Z --- stdout
2019-07-23T20:34:03.2306024Z rustc 1.38.0-dev
2019-07-23T20:34:03.2306069Z binary: rustc
2019-07-23T20:34:03.2306268Z commit-hash: unknown
2019-07-23T20:34:03.2306447Z commit-date: unknown
2019-07-23T20:34:03.2306643Z host: x86_64-unknown-linux-gnu
2019-07-23T20:34:03.2306840Z release: 1.38.0-dev
2019-07-23T20:34:03.2307041Z --- stderr
2019-07-23T20:34:03.2307041Z --- stderr
2019-07-23T20:34:03.2307538Z error: couldn't load codegen backend "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so": "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so: undefined symbol: LLVMInitializeMSP430AsmParser"
2019-07-23T20:34:03.2307630Z 
2019-07-23T20:34:03.2326671Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
2019-07-23T20:34:03.2326945Z expected success, got: exit code: 101
2019-07-23T20:34:03.2338392Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-23T20:34:03.2338392Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-23T20:34:03.2338469Z Build completed unsuccessfully in 0:23:12
2019-07-23T20:34:03.8878156Z ##[error]Bash exited with code '1'.
2019-07-23T20:34:03.8914723Z ##[section]Starting: Checkout
2019-07-23T20:34:03.8916249Z ==============================================================================
2019-07-23T20:34:03.8916313Z Task         : Get sources
2019-07-23T20:34:03.8916355Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nikic
Copy link
Contributor Author

nikic commented Jul 23, 2019

@bors r-

I guess we'll have to do something LLVM version dependent here. Didn't expect that we enable the msp430 target on LLVM 6.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2019
@nikic
Copy link
Contributor Author

nikic commented Jul 23, 2019

Pushed a new version that makes the initialization of the parser LLVM version dependent.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 23, 2019

📌 Commit 71717b9 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Rollup of 10 pull requests

Successful merges:

 - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - rust-lang#61890 (Fix some sanity checks)
 - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item)
 - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - rust-lang#62801 (Remove support for -Zlower-128bit-ops)
 - rust-lang#62808 (Revert "Disable stack probing for gnux32.")
 - rust-lang#62819 (Display name of crate requiring rustc_private in error messages.)
 - rust-lang#62904 (Disable d32 on armv6 hf targets)
 - rust-lang#62907 (Initialize the MSP430 AsmParser)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Rollup of 13 pull requests

Successful merges:

 - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - rust-lang#61890 (Fix some sanity checks)
 - rust-lang#62084 (allow clippy::unreadable_literal in unicode tables)
 - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item)
 - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - rust-lang#62801 (Remove support for -Zlower-128bit-ops)
 - rust-lang#62808 (Revert "Disable stack probing for gnux32.")
 - rust-lang#62822 (Improve some pointer-related documentation)
 - rust-lang#62904 (Disable d32 on armv6 hf targets)
 - rust-lang#62907 (Initialize the MSP430 AsmParser)
 - rust-lang#62921 (Add method disambiguation help for trait implementation)
 - rust-lang#62942 (Use match ergonomics in Condvar documentation)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 14 pull requests

Successful merges:

 - #62084 (allow clippy::unreadable_literal in unicode tables)
 - #62421 (Introduce `as_deref` to Option)
 - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
 - #62801 (Remove support for -Zlower-128bit-ops)
 - #62828 (Remove vector fadd/fmul reduction workarounds)
 - #62862 (code cleanup)
 - #62897 (Attempt to fix backtrace tests on i686-msvc)
 - #62904 (Disable d32 on armv6 hf targets)
 - #62907 (Initialize the MSP430 AsmParser)
 - #62956 (Implement slow-path for FirstSets::first)
 - #62963 (Allow lexer to recover from some homoglyphs)
 - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
 - #62983 (Remove needless indirection through Rc)
 - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 22 pull requests

Successful merges:

 - #62084 (allow clippy::unreadable_literal in unicode tables)
 - #62120 (Add missing type links in documentation)
 - #62310 (Add missing doc links in boxed module)
 - #62421 (Introduce `as_deref` to Option)
 - #62583 (Implement Unpin for all raw pointers)
 - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
 - #62801 (Remove support for -Zlower-128bit-ops)
 - #62828 (Remove vector fadd/fmul reduction workarounds)
 - #62862 (code cleanup)
 - #62904 (Disable d32 on armv6 hf targets)
 - #62907 (Initialize the MSP430 AsmParser)
 - #62956 (Implement slow-path for FirstSets::first)
 - #62963 (Allow lexer to recover from some homoglyphs)
 - #62964 (clarify and unify some type test names)
 - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
 - #62980 (std: Add more accessors for `Metadata` on Windows)
 - #62983 (Remove needless indirection through Rc)
 - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)
 - #63002 (error_index_generator should output stdout/stderr when it panics.)
 - #63004 (Add test for issue-54062)
 - #63007 (ci: debug network failures while downloading awscli from PyPI)
 - #63009 (Remove redundant `mut` from variable declaration.)

Failed merges:

r? @ghost
@bors bors merged commit 71717b9 into rust-lang:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSP430 compilation fails with "Error: r2 should not be used in indexed addressing mode"; fixed upstream
4 participants