Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #62936

Closed
wants to merge 43 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jul 24, 2019

Successful merges:

Failed merges:

r? @ghost

varkor and others added 30 commits July 1, 2019 00:52
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
It is broken and unused
Co-Authored-By: Igor Matuszewski <Xanewok@gmail.com>
This allows the same logic used by `include_X!` macros to be used by
`#[doc(include)]`.
This makes them relative to the containing file instead of the crate
root
petrochenkov and others added 13 commits July 24, 2019 12:29
Instead of
```
mod allocator_abi { /* methods */ }
```
we now generate
```
const _: () = { /* methods */ }
```
and use `std_path` for paths referring to standard library entities.

This way we no longer need to generate `use` and `extern crate` imports, and `#[global_allocator]` starts working inside unnamed blocks.
…r=petrochenkov

rustdoc: make #[doc(include)] relative to the containing file

This matches the behavior of other in-source paths like `#[path]` and the `include_X!` macros.

Fixes rust-lang#58373 (comment)
Also addresses rust-lang#44732 (comment)

cc rust-lang#44732

This is still missing a stdsimd change (https://github.com/jonas-schievink/stdsimd/commit/42ed30e0b5fb5e2d11765b5d1e1f36234af85984), so CI will currently fail. I'll land that change once I get initial feedback for this PR.
…=Dylan-DPC

Fix some sanity checks

Update: Changes that made it not to work dropped.

* Fix `building_llvm` in sanity check
  * This was subtly broken: we build LLVM if any of the hosts builds LLVM, and not setting the config meant that LLVM is built for that target. Because of filtering away the targets not configured and the semantics of `Iterator::any`, it currently didn't set the `building_llvm` flag even if we indeed build it.
* Add `swig` sanity check
  * This checks whether there is a `swig` executable needed for LLDB.
…inhabited-subst, r=oli-obk

Take substs into account in `conservative_is_privately_uninhabited`
Add joining slices of slices with a slice separator, not just a single item

rust-lang#27747 (comment)
> It's kinda annoying to be able to join strings with a str (which can have multiple chars), but joining a slice of slices, you can only join with a single element.

This turns out to be fixable, with some possible inference regressions.

# TL;DR

Related trait(s) are unstable and tracked at rust-lang#27747, but the `[T]::join` method that is being extended here is already stable.

Example use of the new insta-stable functionality:

```rust
let nested: Vec<Vec<Foo>> = /* … */;
let separator: &[Foo] = /* … */;  // Previously: could only be a single &Foo
nested.join(separator)
```

Complete API affected by this PR, after changes:

```rust
impl<T> [T] {
    pub fn concat<Item: ?Sized>(&self) -> <Self as Concat<Item>>::Output
        where Self: Concat<Item>
    {
        Concat::concat(self)
    }
    pub fn join<Separator>(&self, sep: Separator) -> <Self as Join<Separator>>::Output
        where Self: Join<Separator>
    {
        Join::join(self, sep)
    }
}

// The `Item` parameter is only useful for the the slice-of-slices impl.
pub trait Concat<Item: ?Sized> {
    type Output;
    fn concat(slice: &Self) -> Self::Output;
}

pub trait Join<Separator> {
    type Output;
    fn join(slice: &Self, sep: Separator) -> Self::Output;
}

impl<T: Clone, V: Borrow<[T]>> Concat<T> for [V] {
    type Output = Vec<T>;
}

impl<T: Clone, V: Borrow<[T]>> Join<&'_ T> for [V] {
    type Output = Vec<T>;
}

// New functionality here!
impl<T: Clone, V: Borrow<[T]>> Join<&'_ [T]> for [V] {
    type Output = Vec<T>;
}

impl<S: Borrow<str>> Concat<str> for [S] {
    type Output = String;
}

impl<S: Borrow<str>> Join<&'_ str> for [S] {
    type Output = String;
}
```

# Details

After rust-lang#62403 but before this PR, the API is:

```rust
impl<T> [T] {
    pub fn concat<Separator: ?Sized>(&self) -> T::Output
        where T: SliceConcat<Separator>
    {
        SliceConcat::concat(self)
    }

    pub fn join<Separator: ?Sized>(&self, sep: &Separator) -> T::Output
        where T: SliceConcat<Separator>
    {
        SliceConcat::join(self, sep)
    }
}

pub trait SliceConcat<Separator: ?Sized>: Sized {
    type Output;
    fn concat(slice: &[Self]) -> Self::Output;
    fn join(slice: &[Self], sep: &Separator) -> Self::Output;
}

impl<T: Clone, V: Borrow<[T]>> SliceConcat<T> for V {
    type Output = Vec<T>;
}

impl<S: Borrow<str>> SliceConcat<str> for S {
    type Output = String;
}
```

By adding a trait impl we should be able to accept a slice of `T` as the separator, as an alternative to a single `T` value.

In a `some_slice.join(some_separator)` call, trait resolution will pick an impl or the other based on the type of `some_separator`. In `some_slice.concat()` however there is no separator, so this call would become ambiguous. Some regression in type inference or trait resolution may be acceptable on principle, but requiring a turbofish for every single call to `concat` isn’t great.

The solution to that is splitting the `SliceConcat` trait into two `Concat` and `Join` traits, one for each eponymous method. Only `Join` would gain a new impl, so that `some_slice.concat()` would not become ambiguous.

Now, at the trait level the `Concat` trait does not need a `Separator` parameter anymore. However, simply removing it causes one of the impls not to be accepted anymore:

```rust
error[E0207]: the type parameter `T` is not constrained by the impl trait, self type, or predicates
  --> src/liballoc/slice.rs:608:6
    |
608 | impl<T: Clone, V: Borrow<[T]>> Concat for [V] {
    |      ^ unconstrained type parameter
```

This makes sense: if `[V]::concat` is a method that is itself not generic, then its return type (which is the `Concat::Output` associated type) needs to be determined based on solely `V`. And although there is no such type in the standard library, there is nothing stopping another crate from defining a `V` type that implements both `Borrow<[Foo]>` and `Borrow<[Bar]>`. It might not be a good idea, but it’s possible. Both would apply here, and there would be no way to determine `T`.

This could be a warning sign that this API is too generic. Perhaps we’d be better off having one less type variable, and only implement `Concat for [&'_ [T]]` and `Concat for [Vec<T>]` etc. However this aspect of `[V]::concat` is already stable, so we’re stuck with it.

The solution is to keep a dummy type parameter on the `Concat` trait. That way, if a type has multiple `Borrow<[_]>` impls, it’ll end up with multiple corresponding `Concat<_>` impls.

In `impl<S: Borrow<str>> Concat<str> for [S]`, the second occurrence of `str` is not meaningful. It could be any type. As long as there is only once such type with an applicable impl, trait resolution will be appeased without demanding turbofishes.

# Joining strings with `char`

For symmetry I also tried adding this impl (because why not):

```rust
impl<S: Borrow<str>> Join<char> for [S] {
    type Output = String;
}
```

This immediately caused an inference regression in a dependency of rustc:

```rust
error[E0277]: the trait bound `std::string::String: std::borrow::Borrow<[std::string::String]>` is not satisfied
   --> /home/simon/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/getopts-0.2.19/src/lib.rs:595:37
    |
595 |             row.push_str(&desc_rows.join(&desc_sep));
    |                                     ^^^^ the trait `std::borrow::Borrow<[std::string::String]>` is not implemented for `std::string::String`
    |
    = help: the following implementations were found:
              <std::string::String as std::borrow::Borrow<str>>
    = note: required because of the requirements on the impl of `std::slice::Join<&std::string::String>` for `[std::string::String]`
```

In the context of this code, two facts are known:

* `desc_rows` is a `Vec<String>`
* `desc_sep` is a `String`

Previously the first fact alone reduces the resolution of `join` to only one solution, where its argument it expected to be `&str`. Then, `&String` is coerced to `&str`.

With the new `Join` impl, the first fact leavs two applicable impls where the separator can be either `&str` or `char`. But `&String` is neither of these things. It appears that possible coercions are not accounted for, in the search for a solution in trait resolution.

I have not included this new impl in this PR. It’s still possible to add later, but the `getopts` breakage does not need to block the rest of the PR. And the functionality easy for end-user to duplicate: `slice_of_strings.join(&*char_separator.encode_utf8(&mut [0_u8, 4]))`

The `&*` part of that last code snippet is another case of the same issue: `encode_utf8` returns `&mut str` which can be coerced to `&str`, but isn’t when trait resolution is ambiguous.
Turn `#[global_allocator]` into a regular attribute macro

It was a 99% macro with exception of some diagnostic details.

As a result of the change, `#[global_allocator]` now works in nested modules and even in nameless blocks.

Fixes rust-lang#44113
Fixes rust-lang#58072
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
Display name of crate requiring rustc_private in error messages.

This is extraction and rebase of one part of rust-lang#59440 that doesn't involve external things.

r? @oli-obk
Disable d32 on armv6 hf targets

We already do this on armv7 targets. It seems that this now gets enabled by default if '+vfp2` is specified, so disable it explicitly.

Hopefully fixes rust-lang#62841.

r? @alexcrichton
@Centril
Copy link
Contributor Author

Centril commented Jul 24, 2019

@bors r+ p=9 rollup=never

@bors
Copy link
Contributor

bors commented Jul 24, 2019

📌 Commit c9cdfa1 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Rollup of 10 pull requests

Successful merges:

 - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - rust-lang#61890 (Fix some sanity checks)
 - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item)
 - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - rust-lang#62801 (Remove support for -Zlower-128bit-ops)
 - rust-lang#62808 (Revert "Disable stack probing for gnux32.")
 - rust-lang#62819 (Display name of crate requiring rustc_private in error messages.)
 - rust-lang#62904 (Disable d32 on armv6 hf targets)
 - rust-lang#62907 (Initialize the MSP430 AsmParser)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 24, 2019

⌛ Testing commit c9cdfa1 with merge 9d09b7cacbf1cb8df3db70dc267d865b8f3880c8...

@rust-highfive
Copy link
Collaborator

The job LinuxTools of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-24T14:32:16.7905866Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-24T14:32:16.8130300Z ##[command]git config gc.auto 0
2019-07-24T14:32:16.8185070Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-24T14:32:16.8237612Z ##[command]git config --get-all http.proxy
2019-07-24T14:32:16.8394534Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62936/merge:refs/remotes/pull/62936/merge
---
2019-07-24T14:32:52.3607453Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-24T14:32:52.3607488Z 
2019-07-24T14:32:52.3607729Z   git checkout -b <new-branch-name>
2019-07-24T14:32:52.3607761Z 
2019-07-24T14:32:52.3607833Z HEAD is now at 9028d037b Merge c9cdfa110b543c307f3c89594fa7e6bdb48ac910 into 27a6a304e2baaabca88059753f020377f2476978
2019-07-24T14:32:52.3775655Z ##[section]Finishing: Checkout
2019-07-24T14:32:52.3783941Z ##[section]Starting: Decide whether to run this job
2019-07-24T14:32:52.3787569Z Task         : Bash
2019-07-24T14:32:52.3787622Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-07-24T14:32:52.3787714Z Version      : 3.151.3
2019-07-24T14:32:52.3787767Z Author       : Microsoft Corporation
2019-07-24T14:32:52.3787767Z Author       : Microsoft Corporation
2019-07-24T14:32:52.3787825Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
2019-07-24T14:32:52.3787906Z ==============================================================================
2019-07-24T14:32:52.5105934Z Generating script.
2019-07-24T14:32:52.5134705Z ========================== Starting Command Output ===========================
2019-07-24T14:32:52.5153660Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/ad3ec21f-903f-4025-a251-9baccd55a3e7.sh
2019-07-24T14:32:52.7510219Z Executing the job since submodules are updated
2019-07-24T14:32:52.7612460Z ##[section]Finishing: Decide whether to run this job
2019-07-24T14:32:52.7624559Z ==============================================================================
2019-07-24T14:32:52.7624624Z Task         : Bash
2019-07-24T14:32:52.7624782Z Description  : Run a Bash script on macOS, Linux, or Windows
2019-07-24T14:32:52.7624833Z Version      : 3.151.3
---
2019-07-24T16:41:05.8252425Z Cloning into 'rust-toolstate'...
2019-07-24T16:41:06.6545002Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-24T16:41:06.6824097Z [master b97cf8f] (linux CI update)
2019-07-24T16:41:06.6824280Z  1 file changed, 1 insertion(+)
2019-07-24T16:41:07.4877129Z remote: Invalid username or password.
2019-07-24T16:41:07.4879385Z fatal: Authentication failed for 'https://github.com/rust-lang-nursery/rust-toolstate.git/'
2019-07-24T16:41:09.8231744Z  * branch            master     -> FETCH_HEAD
2019-07-24T16:41:09.8448405Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:09.8600502Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-24T16:41:09.8809397Z [master f8373b4] (linux CI update)
2019-07-24T16:41:09.8809397Z [master f8373b4] (linux CI update)
2019-07-24T16:41:09.8809943Z  1 file changed, 1 insertion(+)
2019-07-24T16:41:10.1999921Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-24T16:41:11.5489823Z  * branch            master     -> FETCH_HEAD
2019-07-24T16:41:11.5676323Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:11.5800261Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-24T16:41:11.6006058Z [master e31501c] (linux CI update)
2019-07-24T16:41:11.6006058Z [master e31501c] (linux CI update)
2019-07-24T16:41:11.6006677Z  1 file changed, 1 insertion(+)
2019-07-24T16:41:11.8953379Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-24T16:41:14.2603161Z  * branch            master     -> FETCH_HEAD
2019-07-24T16:41:14.2763561Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:14.2875595Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-24T16:41:14.3076313Z [master 5f03b4c] (linux CI update)
2019-07-24T16:41:14.3076313Z [master 5f03b4c] (linux CI update)
2019-07-24T16:41:14.3076761Z  1 file changed, 1 insertion(+)
2019-07-24T16:41:14.7278485Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-24T16:41:17.0898720Z  * branch            master     -> FETCH_HEAD
2019-07-24T16:41:17.1129730Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:17.1286578Z The state of "rustc-guide" has changed from "test-pass" to ""
2019-07-24T16:41:17.1487249Z [master 03439b9] (linux CI update)
2019-07-24T16:41:17.1487249Z [master 03439b9] (linux CI update)
2019-07-24T16:41:17.1487448Z  1 file changed, 1 insertion(+)
2019-07-24T16:41:17.4403577Z fatal: could not read Username for 'https://github.com': No such device or address
2019-07-24T16:41:20.7596734Z  * branch            master     -> FETCH_HEAD
2019-07-24T16:41:20.7766980Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:20.7766980Z HEAD is now at e6a5387 (windows CI update)
2019-07-24T16:41:21.7031854Z ##[error]Bash exited with code '1'.
2019-07-24T16:41:21.7074927Z ##[section]Starting: Checkout
2019-07-24T16:41:21.7076893Z ==============================================================================
2019-07-24T16:41:21.7076975Z Task         : Get sources
2019-07-24T16:41:21.7077027Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jul 24, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

The job i686-apple of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-24T20:54:40.2845060Z 
2019-07-24T20:54:40.2845750Z ---- [ui] ui/feature-gate/rustc-private.rs stdout ----
2019-07-24T20:54:40.2845880Z diff of stderr:
2019-07-24T20:54:40.2845930Z 
2019-07-24T20:54:40.2846780Z - error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-24T20:54:40.2847670Z + error[E0658]: use of unstable library feature 'rustc_private': crate "libc" is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-24T20:54:40.2848490Z 3    |
2019-07-24T20:54:40.2848570Z 4 LL | extern crate libc;
2019-07-24T20:54:40.2848620Z 
2019-07-24T20:54:40.2848670Z 
2019-07-24T20:54:40.2848670Z 
2019-07-24T20:54:40.2848770Z The actual stderr differed from the expected stderr.
2019-07-24T20:54:40.2849540Z Actual stderr saved to /Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/ui/feature-gate/rustc-private/rustc-private.stderr
2019-07-24T20:54:40.2850220Z To update references, rerun the tests and pass the `--bless` flag
2019-07-24T20:54:40.2851220Z To only update this specific test, also pass `--test-args feature-gate/rustc-private.rs`
2019-07-24T20:54:40.2851390Z error: 1 errors occurred comparing output.
2019-07-24T20:54:40.2851480Z status: exit code: 1
2019-07-24T20:54:40.2851480Z status: exit code: 1
2019-07-24T20:54:40.2852930Z command: "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/vsts/agent/2.154.3/work/1/s/src/test/ui/feature-gate/rustc-private.rs" "-Zthreads=1" "--target=i686-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/ui/feature-gate/rustc-private" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "-L" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/ui/feature-gate/rustc-private/auxiliary" "-A" "unused"
2019-07-24T20:54:40.2853860Z ------------------------------------------
2019-07-24T20:54:40.2853950Z 
2019-07-24T20:54:40.2854570Z ------------------------------------------
2019-07-24T20:54:40.2854670Z stderr:
2019-07-24T20:54:40.2854670Z stderr:
2019-07-24T20:54:40.2855270Z ------------------------------------------
2019-07-24T20:54:40.2856100Z error[E0658]: use of unstable library feature 'rustc_private': crate "libc" is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
2019-07-24T20:54:40.2856980Z    |
2019-07-24T20:54:40.2856980Z    |
2019-07-24T20:54:40.2857630Z LL | extern crate libc; //~ ERROR  use of unstable library feature 'rustc_private'
2019-07-24T20:54:40.2857840Z    |
2019-07-24T20:54:40.2858510Z    = note: for more information, see https://github.com/rust-lang/rust/issues/27812
2019-07-24T20:54:40.2858510Z    = note: for more information, see https://github.com/rust-lang/rust/issues/27812
2019-07-24T20:54:40.2858630Z    = help: add `#![feature(rustc_private)]` to the crate attributes to enable
2019-07-24T20:54:40.2858800Z error: aborting due to previous error
2019-07-24T20:54:40.2858860Z 
2019-07-24T20:54:40.2859500Z For more information about this error, try `rustc --explain E0658`.
2019-07-24T20:54:40.2859580Z 
---
2019-07-24T20:54:40.2903330Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-24T20:54:40.2903560Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-24T20:54:40.2916420Z 
2019-07-24T20:54:40.2916620Z 
2019-07-24T20:54:40.2920290Z command did not execute successfully: "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/vsts/agent/2.154.3/work/1/s/src/test/ui" "--build-base" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/test/ui" "--stage-id" "stage2-i686-apple-darwin" "--mode" "ui" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/vsts/agent/2.154.3/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.38.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-24T20:54:40.2921500Z 
2019-07-24T20:54:40.2921590Z 
2019-07-24T20:54:40.2932840Z failed to run: /Users/vsts/agent/2.154.3/work/1/s/build/bootstrap/debug/bootstrap test
2019-07-24T20:54:40.2933240Z Build completed unsuccessfully in 0:57:37
2019-07-24T20:54:40.2933240Z Build completed unsuccessfully in 0:57:37
2019-07-24T20:54:40.3179260Z ##[error]Bash exited with code '1'.
2019-07-24T20:54:40.3226140Z ##[section]Starting: Upload CPU usage statistics
2019-07-24T20:54:40.3256190Z ==============================================================================
2019-07-24T20:54:40.3256310Z Task         : Bash
2019-07-24T20:54:40.3256390Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2019
@Centril Centril closed this Jul 24, 2019
@Centril Centril deleted the rollup-d702q3x branch July 24, 2019 22:52
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.