Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #63194

Merged
merged 18 commits into from
Aug 1, 2019
Merged

Rollup of 8 pull requests #63194

merged 18 commits into from
Aug 1, 2019

Commits on Jul 13, 2019

  1. simplify std::io::Write::write rustdoc

    The std::io::Write::write method currensly suggests consumers guaranteed
    that `0 <= n <= buf.len()`, for `Ok(n)`, however `n` is of type `usize`
    causing the compiler to emit a warning:
    ```
    warning: comparison is useless due to type limits
     --> lib.rs:6:18
      |
    6 |         Ok(n) => 0 <= n && n <= output.len(),
      |                  ^^^^^^
      |
      = note: #[warn(unused_comparisons)] on by default
    ```
    
    This PR removes the suggestion to check `0 <= n` since it is moot.
    
    r? @steveklabnik
    urandom2 committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    e8e13f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Configuration menu
    Copy the full SHA
    08a8de8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Configuration menu
    Copy the full SHA
    f3a3290 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Add test for issue-58951

    JohnTitor committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    bca1c3c View commit details
    Browse the repository at this point in the history
  2. cleanup StringReader fields

    matklad committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    3f461f5 View commit details
    Browse the repository at this point in the history
  3. Address review comments.

    Centril committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6551285 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Change to check-pass

    JohnTitor committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    d033e8d View commit details
    Browse the repository at this point in the history
  2. issue-2214.rs: lgamma is lgamma on vxWorks

    ignore process-envs.rs and process-remove-from-env.rs as there is no 'env' on vxWorks
    bpangWR committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    8d93778 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b091356 View commit details
    Browse the repository at this point in the history
  4. ci: forward the TOOLSTATE_PUBLISH environment variable inside docker

    A recent commit modified toolstate to only push updated data when the
    TOOLSTATE_PUBLISH environment variable is present. This worked fine on
    Windows but failed on Linux, since Linux jobs run inside Docker
    containers and the variable wasn't forwarded inside it.
    
    This changes the Docker startup code to set the TOOLSTATE_PUBLISH
    enviornment variable inside the container if it's present outside.
    pietroalbini committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    8f8b3f2 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#62644 - arnottcr:std_io-doc, r=steveklabnik

    simplify std::io::Write::write rustdoc
    
    The std::io::Write::write method currensly suggests consumers guaranteed
    that `0 <= n <= buf.len()`, for `Ok(n)`, however `n` is of type `usize`
    causing the compiler to emit a warning:
    ```
    warning: comparison is useless due to type limits
     --> lib.rs:6:18
      |
    6 |         Ok(n) => 0 <= n && n <= output.len(),
      |                  ^^^^^^
      |
      = note: #[warn(unused_comparisons)] on by default
    ```
    
    This PR removes the suggestion to check `0 <= n` since it is moot.
    
    r? @steveklabnik
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    9ff5275 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#62971 - GuillaumeGomez:keyword-sidebar, r=n…

    …obody
    
    Add keywords item into the sidebar
    
    Fixes rust-lang#62939.
    
    cc @pravic
    
    screenshot of the result:
    
    ![Screenshot from 2019-07-25 14-29-48](https://user-images.githubusercontent.com/3050060/61874545-f9512080-aee8-11e9-8e8b-aa50216aec94.png)
    
    r? @QuietMisdreavus
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    e2934ba View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#63122 - Centril:fix-63115, r=petrochenkov

    Account for `maybe_whole_expr` in range patterns
    
    Fixes rust-lang#63115 (fallout from rust-lang#62550).
    
    r? @petrochenkov
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    810ffe2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#63158 - JohnTitor:add-test-for-58951, r=Cen…

    …tril
    
    Add test for issue-58951
    
    Closes rust-lang#58951
    
    r? @Centril
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    aaec6df View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#63170 - matklad:cleanup-fields, r=petrochenkov

    cleanup StringReader fields
    
    reduce visibility and replace `Lrc<SourceFile>` with `start_pos`: the single bit we actually *need* from the file.
    
    r? @petrochenkov
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    7a7fcad View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#63179 - BaoshanPang:testcases, r=alexcrichton

    update test cases for vxWorks
    
    issue-2214.rs: lgamma is lgamma on vxWorks
    ignore process-envs.rs and process-remove-from-env.rs as there is no 'env' on vxWorks
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    f5e2390 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#63188 - waywardmonkeys:release-note-typo-fi…

    …xes, r=Centril
    
    Fix typos in release notes.
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    aa15dad View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#63191 - pietroalbini:really-fix-toolstate, …

    …r=alexcrichton
    
    ci: fix toolstate not pushing data for Linux
    
    A recent commit modified toolstate to only push updated data when the `TOOLSTATE_PUBLISH` environment variable is present. This worked fine on Windows but failed on Linux, since Linux jobs run inside Docker containers and the variable wasn't forwarded inside it.
    
    This changes the Docker startup code to set the `TOOLSTATE_PUBLISH` enviornment variable inside the container if it's present outside.
    
    r? @alexcrichton
    fixes rust-lang#63190
    pietroalbini authored Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b1d5e52 View commit details
    Browse the repository at this point in the history