Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test output #63403

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Improve test output #63403

merged 4 commits into from
Aug 9, 2019

Conversation

ohsayan
Copy link
Contributor

@ohsayan ohsayan commented Aug 9, 2019

I'm continuing to improve the test output for liballoc and libcore

@rust-highfive
Copy link
Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2019
@hellow554
Copy link
Contributor 

rg -g '*.rs' 'assert' | rg == | wc -l
889

rg -g '*.rs' 'assert' src/test | rg == | wc -l
160

😲 (TBH: that snippet has some flaws, but it shows my point ;) )
Can we maybe script that?

@Centril
Copy link
Contributor

Centril commented Aug 9, 2019

Let's land this subset for now.

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2019

📌 Commit fb3a013 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned TimNN Aug 9, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019
@Centril
Rollup merge of rust-lang#63403 - sntdevco:master, r=Centril
171e845 
Improve test output

I'm continuing to improve the test output for liballoc and libcore
@Centril Centril mentioned this pull request Aug 9, 2019
Merged
bors added a commit that referenced this pull request Aug 9, 2019
@bors
Auto merge of #63408 - Centril:rollup-skqrez3, r=Centril
534b423 
Rollup of 7 pull requests

Successful merges:

 - #62672 (Deprecate `try!` macro)
 - #62950 (Check rustbook links on all platforms when running locally)
 - #63114 (Remove gensym in format_args)
 - #63397 (Add tests for some ICEs)
 - #63403 (Improve test output)
 - #63404 (enable flt2dec tests in Miri)
 - #63407 (reduce some test sizes in Miri)

Failed merges:

r? @ghost
@bors bors merged commit fb3a013 into rust-lang:master Aug 9, 2019
@ohsayan ohsayan mentioned this pull request Oct 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ohsayan @rust-highfive @hellow554 @Centril @bors @TimNN