Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable flt2dec tests in Miri #63404

Merged
merged 2 commits into from
Aug 9, 2019
Merged

enable flt2dec tests in Miri #63404

merged 2 commits into from
Aug 9, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 9, 2019

With ldexp implemented (thanks to @christianpoveda), we can finally enable these tests in Miri. Well, most of them -- some are just too slow.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2019
@Centril
Copy link
Contributor

Centril commented Aug 9, 2019

Nice :)

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 9, 2019

📌 Commit 29ca428 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned joshtriplett Aug 9, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019
enable flt2dec tests in Miri

With ldexp implemented (thanks to @christianpoveda), we can finally enable these tests in Miri. Well, most of them -- some are just too slow.
bors added a commit that referenced this pull request Aug 9, 2019
Rollup of 7 pull requests

Successful merges:

 - #62672 (Deprecate `try!` macro)
 - #62950 (Check rustbook links on all platforms when running locally)
 - #63114 (Remove gensym in format_args)
 - #63397 (Add tests for some ICEs)
 - #63403 (Improve test output)
 - #63404 (enable flt2dec tests in Miri)
 - #63407 (reduce some test sizes in Miri)

Failed merges:

r? @ghost
@bors bors merged commit 29ca428 into rust-lang:master Aug 9, 2019
@RalfJung RalfJung mentioned this pull request Aug 9, 2019
@RalfJung RalfJung deleted the flt2dec branch August 9, 2019 16:43
bors added a commit that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants