Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc use -Ccodegen-units=1 by default for test compile #64032

Merged
merged 1 commit into from
Sep 1, 2019
Merged

rustdoc use -Ccodegen-units=1 by default for test compile #64032

merged 1 commit into from
Sep 1, 2019

Conversation

andjo403
Copy link
Contributor

as the test is small we do not want split up in multiple codegen units
and also as there is multiple test running at the same time this
will reduce the number of concurrent threads

tested the test time with ./x.py test src/libcore --doc
for my 16 core 32 thread cpu i get about 6% faster execution
and my 2 core 4 thread cpu I get about 10% faster execution

cc #63638
r? @Mark-Simulacrum

@andjo403
rustdoc use -Ccodegen-units=1 by default for test compile
0b478e6 
as the test is small we do not want split up in multiple codegen units
and also as there is multiple test running at the same time this
will reduce the number of concurrent threads
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 31, 2019

📌 Commit 0b478e6 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 31, 2019
@bors
Copy link
Contributor

bors commented Aug 31, 2019

⌛ Testing commit 0b478e6 with merge 26d5e13...

bors added a commit that referenced this pull request Aug 31, 2019
@bors
Auto merge of #64032 - andjo403:codegen-units, r=Mark-Simulacrum
26d5e13 
rustdoc use -Ccodegen-units=1 by default for test compile

as the test is small we do not want split up in multiple codegen units
and also as there is multiple test running at the same time this
will reduce the number of concurrent threads

tested the test time with `./x.py test src/libcore --doc`
for my 16 core 32 thread cpu i get about 6% faster execution
and my 2 core 4 thread cpu I get about 10% faster execution

cc #63638
 r? @Mark-Simulacrum
@bors
Copy link
Contributor

bors commented Aug 31, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

The job x86_64-msvc-1 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-08-31T14:40:36.4089421Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-31T14:40:36.4089511Z 
2019-08-31T14:40:36.4089589Z   git checkout -b <new-branch-name>
2019-08-31T14:40:36.4089635Z 
2019-08-31T14:40:36.4089732Z HEAD is now at 26d5e13ef Auto merge of #64032 - andjo403:codegen-units, r=Mark-Simulacrum
2019-08-31T14:40:36.4558722Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-31T14:40:36.4668430Z ==============================================================================
2019-08-31T14:40:36.4668542Z Task         : Bash
2019-08-31T14:40:36.4668616Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2019
@andjo403
Copy link
Contributor Author

failed with some network problem error: failed to download from https://crates.io/api/v1/crates/cmake/0.1.38/download

@Mark-Simulacrum
Copy link
Member

@bors retry

possibly related to aws outage

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
@Centril
Rollup merge of rust-lang#64032 - andjo403:codegen-units, r=Mark-Simu…
5d813c5 
…lacrum

rustdoc use -Ccodegen-units=1 by default for test compile

as the test is small we do not want split up in multiple codegen units
and also as there is multiple test running at the same time this
will reduce the number of concurrent threads

tested the test time with `./x.py test src/libcore --doc`
for my 16 core 32 thread cpu i get about 6% faster execution
and my 2 core 4 thread cpu I get about 10% faster execution

cc rust-lang#63638
 r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 1, 2019
Closed
bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64053 - Centril:rollup-ljvn1wm, r=Centril
24bbe79 
Rollup of 4 pull requests

Successful merges:

 - #63410 (Update BufWriter example to include call to flush())
 - #64032 (rustdoc use -Ccodegen-units=1 by default for test compile)
 - #64039 (Update sync condvar doc style)
 - #64042 (Fix word repetition in str documentation)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
@Centril
Rollup merge of rust-lang#64032 - andjo403:codegen-units, r=Mark-Simu…
6eadfc3 
…lacrum

rustdoc use -Ccodegen-units=1 by default for test compile

as the test is small we do not want split up in multiple codegen units
and also as there is multiple test running at the same time this
will reduce the number of concurrent threads

tested the test time with `./x.py test src/libcore --doc`
for my 16 core 32 thread cpu i get about 6% faster execution
and my 2 core 4 thread cpu I get about 10% faster execution

cc rust-lang#63638
 r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Sep 1, 2019
Merged
bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64057 - Centril:rollup-nwtk2fb, r=Centril
e29faf0 
Rollup of 5 pull requests

Successful merges:

 - #63410 (Update BufWriter example to include call to flush())
 - #64029 (Account for rounding errors when deciding the diagnostic boundaries)
 - #64032 (rustdoc use -Ccodegen-units=1 by default for test compile)
 - #64039 (Update sync condvar doc style)
 - #64042 (Fix word repetition in str documentation)

Failed merges:

r? @ghost
@bors bors merged commit 0b478e6 into rust-lang:master Sep 1, 2019
@bors
Copy link
Contributor

bors commented Sep 1, 2019

☔ The latest upstream changes (presumably #64057) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2019
@andjo403 andjo403 deleted the codegen-units branch September 1, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andjo403 @Mark-Simulacrum @bors @rust-highfive