Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sync condvar doc style #64039

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Update sync condvar doc style #64039

merged 1 commit into from
Sep 1, 2019

Conversation

pickfire
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @KodrAus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2019
@jonas-schievink
Copy link
Contributor

Thanks!

r? @jonas-schievink @bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 31, 2019

📌 Commit e2e1175 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
@Centril
Rollup merge of rust-lang#64039 - pickfire:patch-1, r=jonas-schievink
8cbbf97 
Update sync condvar doc style
@Centril Centril mentioned this pull request Sep 1, 2019
Closed
bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64053 - Centril:rollup-ljvn1wm, r=Centril
24bbe79 
Rollup of 4 pull requests

Successful merges:

 - #63410 (Update BufWriter example to include call to flush())
 - #64032 (rustdoc use -Ccodegen-units=1 by default for test compile)
 - #64039 (Update sync condvar doc style)
 - #64042 (Fix word repetition in str documentation)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
@Centril
Rollup merge of rust-lang#64039 - pickfire:patch-1, r=jonas-schievink
a7ba1be 
Update sync condvar doc style
@Centril Centril mentioned this pull request Sep 1, 2019
Merged
bors added a commit that referenced this pull request Sep 1, 2019
@bors
Auto merge of #64057 - Centril:rollup-nwtk2fb, r=Centril
e29faf0 
Rollup of 5 pull requests

Successful merges:

 - #63410 (Update BufWriter example to include call to flush())
 - #64029 (Account for rounding errors when deciding the diagnostic boundaries)
 - #64032 (rustdoc use -Ccodegen-units=1 by default for test compile)
 - #64039 (Update sync condvar doc style)
 - #64042 (Fix word repetition in str documentation)

Failed merges:

r? @ghost
@bors bors merged commit e2e1175 into rust-lang:master Sep 1, 2019
@bors
Copy link
Contributor

bors commented Sep 1, 2019

☔ The latest upstream changes (presumably #64057) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2019
@pickfire pickfire deleted the patch-1 branch September 5, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pickfire @rust-highfive @jonas-schievink @bors @KodrAus