Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use just one name when parameters and fields are the same #64071

Merged
merged 1 commit into from
Sep 3, 2019
Merged

use just one name when parameters and fields are the same #64071

merged 1 commit into from
Sep 3, 2019

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Sep 1, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2019
@Centril
Copy link
Contributor

Centril commented Sep 1, 2019

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 1, 2019

📌 Commit ab12dfe has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned alexcrichton Sep 1, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2019
@bors
Copy link
Contributor

bors commented Sep 1, 2019

⌛ Testing commit ab12dfe with merge 63ac607ce74adb382b6f3c0fbede1f335c9c516d...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-debug of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 1, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2019
@Centril
Copy link
Contributor

Centril commented Sep 1, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 1, 2019
@Centril
Rollup merge of rust-lang#64071 - guanqun:style-fix, r=Centril
36282e6 
use just one name when parameters and fields are the same
@Centril Centril mentioned this pull request Sep 1, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
@Centril
Rollup merge of rust-lang#64071 - guanqun:style-fix, r=Centril
ed13e27 
use just one name when parameters and fields are the same
@Centril Centril mentioned this pull request Sep 3, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
@Centril
Rollup merge of rust-lang#64071 - guanqun:style-fix, r=Centril
7bfbaca 
use just one name when parameters and fields are the same
@Centril Centril mentioned this pull request Sep 3, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Sep 3, 2019
@Centril
Rollup merge of rust-lang#64071 - guanqun:style-fix, r=Centril
a906a83 
use just one name when parameters and fields are the same
@Centril Centril mentioned this pull request Sep 3, 2019
Merged
bors added a commit that referenced this pull request Sep 3, 2019
@bors
Auto merge of #64127 - Centril:rollup-dfgb9h8, r=Centril
b9de4ef 
Rollup of 5 pull requests

Successful merges:

 - #64049 (Emit a single error on if expr with expectation and no else clause)
 - #64056 (Account for arbitrary self types in E0599)
 - #64058 (librustc_errors: Extract sugg/subst handling into method)
 - #64071 (use just one name when parameters and fields are the same)
 - #64104 (Emit error on intrinsic to fn ptr casts)

Failed merges:

r? @ghost
@bors bors merged commit ab12dfe into rust-lang:master Sep 3, 2019
@guanqun guanqun deleted the style-fix branch September 4, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guanqun @rust-highfive @Centril @bors @alexcrichton