-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #64076
Rollup of 5 pull requests #64076
Conversation
An initial refactoring before working on rust-lang#61809. This moves the whole block into a method so that it can be reused in the annotate-snippet output. It's already used in the new emitter, but there's no UI tests with suggestions included in this PR. A first look at some UI tests with suggestions showed that there's some more work to do in [annotate-snippet-rs][annotate-snippet-rs] before the new output is closer to the current one.
Emit a single error on if expr with expectation and no else clause Fix rust-lang#60254. r? @Centril
…ntril Account for arbitrary self types in E0599 Fix rust-lang#62373
…bank librustc_errors: Extract sugg/subst handling into method An initial refactoring before working on rust-lang#61809. This moves the whole block into a method so that it can be reused in the annotate-snippet emitter. The method is already used in the new emitter, but there's no UI tests with suggestions included in this PR. A first look at some UI tests with suggestions showed that there's some more work to do in [annotate-snippet-rs][annotate-snippet-rs] before the new output is closer to the current one, so I opted to do that in a second step. r? @estebank [annotate-snippet-rs]: https://github.com/rust-lang/annotate-snippets-rs
Fix const_err with `-(-0.0)` Fixes rust-lang#64059 r? @oli-obk
use just one name when parameters and fields are the same
@bors r+ p=5 rollup=never |
📌 Commit 36282e6 has been approved by |
⌛ Testing commit 36282e6 with merge 3fb1229d70551beb25904c501154c66f8571622c... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
FYI, this is at least the 3rd, if not more, build I've seen fail on a TLS error. |
@bors retry |
⌛ Testing commit 36282e6 with merge 1963d025216789ebb7e3e6e9acd6a7b8df81e0e6... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
-(-0.0)
#64063 (Fix const_err with-(-0.0)
)Failed merges:
r? @ghost