Upload toolstates.json to rust-lang-ci2 #65274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
added
the
T-infra
rust-highfive
added
the
S-waiting-on-review
pietroalbini
force-pushed
the
ci-upload-toolstate
branch
from
9660f36
to
57a827e
Compare
RalfJung
reviewed
Oct 10, 2019
pietroalbini
force-pushed
the
ci-upload-toolstate
branch
2 times, most recently
from
abb6d9f
to
cc77a24
Compare
|
r=me on cc77a24, feel free to merge when ready |
|
@alexcrichton did you also review 25e606978ab6417fa93cc19099e05f16b3081d83? |
|
I did not, but I did now, and seems fine! |
|
☔ The latest upstream changes (presumably #65762) made this pull request unmergeable. Please resolve the merge conflicts. |
Uploading the toolstate data for each commit will help our release tooling understand which components are failing, to possibly skip shipping broken tools to users.
pietroalbini
force-pushed
the
ci-upload-toolstate
branch
from
cc77a24
to
0200050
Compare
pietroalbini
changed the title
|
Rebased this on top of master. @bors r=alexcrichton |
|
📌 Commit 0200050 has been approved by |
bors
added
S-waiting-on-bors
tesuji
reviewed
Oct 29, 2019
Co-Authored-By: lzutao <taolzu@gmail.com>
|
@bors r=alexcrichton |
|
📌 Commit bdfcde4 has been approved by |
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 30, 2019
…=alexcrichton Upload toolstates.json to rust-lang-ci2 This PR does two things: * Following up with rust-lang#65202, it migrates deploying artifacts to CI in a script. Both uploading release artifacts and CPU stats were merged into the same script, designing it to be easily extended. * Uploads the toolstate JSON to `rust-lang-ci2` along with the release artifacts, both for Linux and Windows. This is needed because @RalfJung wants to stop shipping MIRI when its tests are failing, and the toolstate repo doesn't have entries for each commit. Having the toolstate data (just for that specific commit) on `rust-lang-ci2` will simplify the code a lot. r? @alexcrichton cc @RalfJung
|
⌛ Testing commit bdfcde4 with merge 1ce210ad823e29aed485f7a250ffc1b3f220aedd... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors try |
|
⌛ Trying commit a2a2a788152cd30188cdf4d79c21fe4ed11399bb with merge 573370ea7720b8b8755299ad0464ae5ce9cd2166... |
|
💔 Test failed - checks-azure |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors try |
|
⌛ Trying commit a2a2a788152cd30188cdf4d79c21fe4ed11399bb with merge ff69cc2c1a81e79cdc48d0e7c4195a3ac06a2923... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
pietroalbini
force-pushed
the
ci-upload-toolstate
branch
from
a2a2a78
to
f10cf1d
Compare
|
@bors try |
bors
added a commit
that referenced
this pull request
Oct 30, 2019
Upload toolstates.json to rust-lang-ci2 This PR does two things: * Following up with #65202, it migrates deploying artifacts to CI in a script. Both uploading release artifacts and CPU stats were merged into the same script, designing it to be easily extended. * Uploads the toolstate JSON to `rust-lang-ci2` along with the release artifacts, both for Linux and Windows. This is needed because @RalfJung wants to stop shipping MIRI when its tests are failing, and the toolstate repo doesn't have entries for each commit. Having the toolstate data (just for that specific commit) on `rust-lang-ci2` will simplify the code a lot. r? @alexcrichton cc @RalfJung
Before this commit toolstates.json was stored in /tmp and it wasn't mounted outside the build container. That caused uploading the file in the upload-artifacts task to fail, as the file was missing on the host. Mounting /tmp/toolstates.json alone is not the best approach: if the file is missing when the container is started the Docker engine will create a *directory* named /tmp/toolstates.json. The Docker issue could be solved by pre-creating an empty file named /tmp/toolstates.json, but doing that could cause problems if bootstrap fails to generate the file and the toolstate scripts receive an empty JSON. The approach I took in this commit is to instead mount a /tmp/toolstate directory inside Docker, and create the toolstates.json file in it. That also required a small bootstrap change to ensure the directory is created if it's missing.
pietroalbini
force-pushed
the
ci-upload-toolstate
branch
from
f10cf1d
to
ca34687
Compare
|
Ok the last try build seems to be going through. @alexcrichton I had to add ca34687 as well, could you review it and |
|
@bors: r+ sure! I'll leave the |
|
📌 Commit ca34687 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 31, 2019
…=alexcrichton Upload toolstates.json to rust-lang-ci2 This PR does two things: * Following up with rust-lang#65202, it migrates deploying artifacts to CI in a script. Both uploading release artifacts and CPU stats were merged into the same script, designing it to be easily extended. * Uploads the toolstate JSON to `rust-lang-ci2` along with the release artifacts, both for Linux and Windows. This is needed because @RalfJung wants to stop shipping MIRI when its tests are failing, and the toolstate repo doesn't have entries for each commit. Having the toolstate data (just for that specific commit) on `rust-lang-ci2` will simplify the code a lot. r? @alexcrichton cc @RalfJung
bors
added a commit
that referenced
this pull request
Oct 31, 2019
Rollup of 7 pull requests Successful merges: - #65274 (Upload toolstates.json to rust-lang-ci2) - #65434 (Add long error explanation for E0577) - #65850 (Update comments re type parameter hack in object safety) - #65955 (ci: revert msys2 ca-certificates hack) - #65959 (Fix an incorrect docstring for Immediate in librustc_mir/interpret.) - #65979 (Switch CrateMetadata's source_map_import_info from RwLock to Once) - #65981 (work around aggressive syntax feature gating) Failed merges: r? @ghost
|
Thanks a lot @pietroalbini! I will get back to #60301 based on top of this on the week-end. |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Nov 5, 2019
…bini when Miri tests are not passing, do not add Miri component Second attempt, this time based on the JSON files that exist since rust-lang#65274. Fixes rust-lang#60301 r? @pietroalbini @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
rust-lang-ci2along with the release artifacts, both for Linux and Windows. This is needed because @RalfJung wants to stop shipping MIRI when its tests are failing, and the toolstate repo doesn't have entries for each commit. Having the toolstate data (just for that specific commit) onrust-lang-ci2will simplify the code a lot.r? @alexcrichton
cc @RalfJung