Switch CrateMetadata's source_map_import_info from RwLock to Once #65979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
approved these changes
Oct 30, 2019
|
r=me modulo comments |
This field is created lazily on first use and after that is read only. That's exactly what Once is for.
spastorino
force-pushed
the
crate-metadata-mutexes
branch
from
0cc9939
to
53f3e9b
Compare
spastorino
force-pushed
the
crate-metadata-mutexes
branch
from
53f3e9b
to
d8e9a63
Compare
spastorino
force-pushed
the
crate-metadata-mutexes
branch
2 times, most recently
from
014cc3e
to
12273cb
Compare
|
@bors r+ rollup |
|
📌 Commit 12273cb has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 31, 2019
…r=Mark-Simulacrum Switch CrateMetadata's source_map_import_info from RwLock to Once
bors
added a commit
that referenced
this pull request
Oct 31, 2019
Rollup of 7 pull requests Successful merges: - #65274 (Upload toolstates.json to rust-lang-ci2) - #65434 (Add long error explanation for E0577) - #65850 (Update comments re type parameter hack in object safety) - #65955 (ci: revert msys2 ca-certificates hack) - #65959 (Fix an incorrect docstring for Immediate in librustc_mir/interpret.) - #65979 (Switch CrateMetadata's source_map_import_info from RwLock to Once) - #65981 (work around aggressive syntax feature gating) Failed merges: r? @ghost
therealprof
reviewed
Oct 31, 2019
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 31, 2019
…, r=Mark-Simulacrum Fix outdated rustdoc of Once::init_locking function r? @Mark-Simulacrum related to rust-lang#65979
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 1, 2019
…, r=Mark-Simulacrum Fix outdated rustdoc of Once::init_locking function r? @Mark-Simulacrum related to rust-lang#65979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.