Make ItemContext available for better diagnositcs #65902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
gilescope
changed the title
|
Fixes #62570 |
|
r? @estebank |
estebank
reviewed
Oct 28, 2019
estebank
reviewed
Oct 28, 2019
estebank
reviewed
Oct 28, 2019
estebank
reviewed
Oct 28, 2019
estebank
reviewed
Oct 28, 2019
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Oct 29, 2019
gilescope
force-pushed
the
issue62570
branch
2 times, most recently
from
803f1da to
8c5f0f6
Compare
estebank
reviewed
Oct 30, 2019
gilescope
changed the title
|
@bors r+ |
|
📌 Commit d7869ec has been approved by |
bors
added
S-waiting-on-bors
estebank
changed the title
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Nov 1, 2019
Make ItemContext available for better diagnositcs Fix rust-lang#62570
bors
added a commit
that referenced
this pull request
Nov 1, 2019
Rollup of 16 pull requests Successful merges: - #65112 (Add lint and tests for unnecessary parens around types) - #65470 (Don't hide ICEs from previous incremental compiles) - #65471 (Add long error explanation for E0578) - #65857 (rustdoc: Resolve module-level doc references more locally) - #65902 (Make ItemContext available for better diagnositcs) - #65914 (Use structured suggestion for unnecessary bounds in type aliases) - #65946 (Make `promote_consts` emit the errors when required promotion fails) - #65960 (doc: reword iter module example and mention other methods) - #65963 (update submodules to rust-lang) - #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets) - #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type) - #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function") - #65997 (Fix outdated rustdoc of Once::init_locking function) - #66002 (Stabilize float_to_from_bytes feature) - #66005 (vxWorks: remove code related unix socket) - #66018 (Revert PR 64324: dylibs export generics again (for now)) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #62570