Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error code E0743 for "C-variadic has been used on a non-foreign function" #65995

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add error code E0743 for "C-variadic has been used on a non-foreign function" #65995

merged 2 commits into from
Nov 1, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #65967

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2019
@eddyb
Copy link
Member

eddyb commented Oct 31, 2019

Please don't use error code numbers without also describing what error they refer to.
(I'm referring to the PR title in this case)

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned eddyb Oct 31, 2019
@GuillaumeGomez GuillaumeGomez changed the title Add error code E0743 Add error code E0743 for "C-variadic has been used on a non-foreign function" Oct 31, 2019
@GuillaumeGomez
Copy link
Member Author

Sorry, updated the title.

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 31, 2019

📌 Commit fcbf77e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 31, 2019
@tmandry
Rollup merge of rust-lang#65995 - GuillaumeGomez:add-err-code-E0743, …
0682fc0 
…r=estebank

Add error code E0743 for "C-variadic has been used on a non-foreign function"

Fixes rust-lang#65967
@tmandry tmandry mentioned this pull request Oct 31, 2019
Closed
bors added a commit that referenced this pull request Oct 31, 2019
@bors
Auto merge of #66009 - tmandry:rollup-jt3wtfr, r=tmandry
a143325 
Rollup of 14 pull requests

Successful merges:

 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65459 (Fix `-Zunpretty=mir-cfg` to render multiple items)
 - #65471 (Add long error explanation for E0578)
 - #65857 (rustdoc: Resolve module-level doc references more locally)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65945 (Optimize long-linker-command-line test)
 - #65946 (Make `promote_consts` emit the errors when required promotion fails)
 - #65960 (doc: reword iter module example and mention other methods)
 - #65963 (update submodules to rust-lang)
 - #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets)
 - #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type)
 - #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function")
 - #65997 (Fix outdated rustdoc of Once::init_locking function)
 - #66005 (vxWorks: remove code related unix socket)

Failed merges:

r? @ghost
tmandry added a commit to tmandry/rust that referenced this pull request Nov 1, 2019
@tmandry
Rollup merge of rust-lang#65995 - GuillaumeGomez:add-err-code-E0743, …
1ea6685 
…r=estebank

Add error code E0743 for "C-variadic has been used on a non-foreign function"

Fixes rust-lang#65967
@tmandry tmandry mentioned this pull request Nov 1, 2019
Merged
bors added a commit that referenced this pull request Nov 1, 2019
@bors
Auto merge of #66021 - tmandry:rollup-y13l6n9, r=tmandry
87cbf0a 
Rollup of 16 pull requests

Successful merges:

 - #65112 (Add lint and tests for unnecessary parens around types)
 - #65470 (Don't hide ICEs from previous incremental compiles)
 - #65471 (Add long error explanation for E0578)
 - #65857 (rustdoc: Resolve module-level doc references more locally)
 - #65902 (Make ItemContext available for better diagnositcs)
 - #65914 (Use structured suggestion for unnecessary bounds in type aliases)
 - #65946 (Make `promote_consts` emit the errors when required promotion fails)
 - #65960 (doc: reword iter module example and mention other methods)
 - #65963 (update submodules to rust-lang)
 - #65972 (Fix libunwind build: Define __LITTLE_ENDIAN__ for LE targets)
 - #65977 (Fix incorrect diagnostics for expected type in E0271 with an associated type)
 - #65995 (Add error code E0743 for "C-variadic has been used on a non-foreign function")
 - #65997 (Fix outdated rustdoc of Once::init_locking function)
 - #66002 (Stabilize float_to_from_bytes feature)
 - #66005 (vxWorks: remove code related unix socket)
 - #66018 (Revert PR 64324: dylibs export generics again (for now))

Failed merges:

r? @ghost
@bors bors merged commit fcbf77e into rust-lang:master Nov 1, 2019
@GuillaumeGomez GuillaumeGomez deleted the add-err-code-E0743 branch November 1, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error that doesn't have an error code
5 participants
@GuillaumeGomez @rust-highfive @eddyb @estebank @bors