Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RELEASES.md for 1.40.0 #66377

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Update RELEASES.md for 1.40.0 #66377

merged 2 commits into from
Dec 11, 2019

Conversation

XAMPPRocky
Copy link
Member

Rendered

r? @Mark-Simulacrum
cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2019
Centril
Centril reviewed Nov 13, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
jonas-schievink
jonas-schievink reviewed Nov 13, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
ehuss
ehuss reviewed Nov 13, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

Please add #65294 (comment) to compatibility notes (the PR; that link points at example crates that broke, but we should not list those).

@XAMPPRocky
Copy link
Member Author

@Mark-Simulacrum What's the compat note in this case? Rustc now warns when #[inline] is ignored?

@Mark-Simulacrum
Copy link
Member

There are some error cases added as well, e.g. inline on trait items I believe is now a hard error. @varkor -- can you maybe write up a quick blurb?

@varkor
Copy link
Member

varkor commented Nov 18, 2019

Is something like this sufficient?

Using #[inline] on function prototypes and consts now emits a warning under unused_attribute.
Using #[inline] anywhere else inside traits or extern blocks now correctly emits an error.

@XAMPPRocky
Copy link
Member Author

Added to notes.

petrochenkov
petrochenkov reviewed Nov 18, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
tspiteri
tspiteri reviewed Nov 24, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
tspiteri
tspiteri reviewed Nov 24, 2019
View reviewed changes
RELEASES.md Show resolved Hide resolved
ollie27
ollie27 reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@ollie27 ollie27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#63803 also needs to be included.

Mark-Simulacrum
Mark-Simulacrum reviewed Dec 3, 2019
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

This looks great, thanks! Will let it sit for a week or so and aim to merge around the Friday before release week.

@XAMPPRocky @Mark-Simulacrum
Update RELEASES.md
dbfb00c 
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@imp
Copy link

imp commented Dec 10, 2019

Shouldn't stabilization of feature(result_map_or_else) (#66322) be mentioned as well?

@XAMPPRocky
Copy link
Member Author

XAMPPRocky commented Dec 10, 2019 •
edited
Loading

@imp That PR mentions that it is stabilised in 1.41.0 and these are release notes for 1.40.0. Also this seems to be actual stabilisation PR #66570

@imp
Copy link

imp commented Dec 10, 2019

@XAMPPRocky Right, my bad

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=always

Let's get this landed and we can send followup PRs if needed.

@bors
Copy link
Contributor

bors commented Dec 10, 2019

📌 Commit dbfb00c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 10, 2019
@JohnTitor
Rollup merge of rust-lang#66377 - XAMPPRocky:relnotes-1.40.0, r=Mark-…
9b1b12b 
…Simulacrum

Update RELEASES.md for 1.40.0

### [Rendered](https://github.com/XAMPPRocky/rust/blob/relnotes-1.40.0/RELEASES.md)

r? @Mark-Simulacrum
cc @rust-lang/release
@JohnTitor JohnTitor mentioned this pull request Dec 10, 2019
Merged
bors added a commit that referenced this pull request Dec 11, 2019
@bors
Auto merge of #67202 - JohnTitor:rollup-0xjm5pz, r=JohnTitor
ddca1e0 
Rollup of 9 pull requests

Successful merges:

 - #66377 (Update RELEASES.md for 1.40.0)
 - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…)
 - #67152 (Sort auto trait and blanket implementations display)
 - #67154 (Fix typos in src/libcore/alloc.rs docs)
 - #67168 (corrected comment in E0478)
 - #67178 (Move non clean impls items)
 - #67180 (doc: Use .copied() instead of .cloned() in Vec example)
 - #67181 (Update hashmap doc)
 - #67193 (In which we start tracking polonius in `-Z self-profile`)

Failed merges:

r? @ghost
@bors bors merged commit dbfb00c into rust-lang:master Dec 11, 2019
@XAMPPRocky XAMPPRocky deleted the relnotes-1.40.0 branch December 11, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tspiteri tspiteri tspiteri left review comments

@ollie27 ollie27 ollie27 left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@pietroalbini pietroalbini pietroalbini left review comments

@jonas-schievink jonas-schievink jonas-schievink left review comments

@Centril Centril Centril left review comments

@ehuss ehuss ehuss left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.