-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort auto trait and blanket implementations display #67152
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
f9db411
to
9e3e421
Compare
@GuillaumeGomez Is there a useful way to add a test for this? |
We could through the UI tests. Still kinda blocked for the moment until highfive is fixed... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the code seems to provide sorted auto-trait and blanket impls.
I'm not fond of the crate fn foo()
syntax, though I appreciate it's the style in the code at the moment, it'd be nice if new code were pub(crate) fn foo()
in future. No need to change things on this PR though.
@bors r+ |
📌 Commit 9e3e421 has been approved by |
…innison Sort auto trait and blanket implementations display Fixes rust-lang#63042 r? @kinnison
Rollup of 9 pull requests Successful merges: - #66377 (Update RELEASES.md for 1.40.0) - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…) - #67152 (Sort auto trait and blanket implementations display) - #67154 (Fix typos in src/libcore/alloc.rs docs) - #67168 (corrected comment in E0478) - #67178 (Move non clean impls items) - #67180 (doc: Use .copied() instead of .cloned() in Vec example) - #67181 (Update hashmap doc) - #67193 (In which we start tracking polonius in `-Z self-profile`) Failed merges: r? @ghost
Fixes #63042
r? @kinnison