Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort auto trait and blanket implementations display #67152

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

GuillaumeGomez
Copy link
Member

Fixes #63042

r? @kinnison

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-08T12:57:48.1171760Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-08T12:57:48.1188978Z ##[command]git config gc.auto 0
2019-12-08T12:57:48.1192627Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-08T12:57:48.1194909Z ##[command]git config --get-all http.proxy
2019-12-08T12:57:48.1201231Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67152/merge:refs/remotes/pull/67152/merge
---
2019-12-08T13:03:35.6961203Z    Compiling serde_json v1.0.40
2019-12-08T13:03:37.3861027Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-08T13:03:48.1633929Z     Finished release [optimized] target(s) in 1m 26s
2019-12-08T13:03:48.1741288Z tidy check
2019-12-08T13:03:48.8105376Z tidy error: /checkout/src/librustdoc/html/render.rs:2295: line longer than 100 chars
2019-12-08T13:03:50.9029129Z Found 485 error codes
2019-12-08T13:03:50.9029239Z Found 0 error codes with no tests
2019-12-08T13:03:50.9033440Z Done!
2019-12-08T13:03:50.9033494Z some tidy checks failed
2019-12-08T13:03:50.9033494Z some tidy checks failed
2019-12-08T13:03:50.9038792Z 
2019-12-08T13:03:50.9045036Z 
2019-12-08T13:03:50.9051743Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-08T13:03:50.9052257Z 
2019-12-08T13:03:50.9052294Z 
2019-12-08T13:03:50.9077043Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-08T13:03:50.9077122Z Build completed unsuccessfully in 0:01:30
2019-12-08T13:03:50.9077122Z Build completed unsuccessfully in 0:01:30
2019-12-08T13:03:50.9111204Z == clock drift check ==
2019-12-08T13:03:50.9125953Z   local time: Sun Dec  8 13:03:50 UTC 2019
2019-12-08T13:03:51.0422610Z   network time: Sun, 08 Dec 2019 13:03:51 GMT
2019-12-08T13:03:51.0427394Z == end clock drift check ==
2019-12-08T13:03:52.4660629Z 
2019-12-08T13:03:52.4768256Z ##[error]Bash exited with code '1'.
2019-12-08T13:03:52.4797707Z ##[section]Starting: Checkout
2019-12-08T13:03:52.4799647Z ==============================================================================
2019-12-08T13:03:52.4799702Z Task         : Get sources
2019-12-08T13:03:52.4799765Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kinnison
Copy link
Contributor

kinnison commented Dec 8, 2019

@GuillaumeGomez Is there a useful way to add a test for this?

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 8, 2019
@GuillaumeGomez
Copy link
Member Author

We could through the UI tests. Still kinda blocked for the moment until highfive is fixed...

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the code seems to provide sorted auto-trait and blanket impls.

I'm not fond of the crate fn foo() syntax, though I appreciate it's the style in the code at the moment, it'd be nice if new code were pub(crate) fn foo() in future. No need to change things on this PR though.

@kinnison
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 10, 2019

📌 Commit 9e3e421 has been approved by kinnison

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 10, 2019
…innison

Sort auto trait and blanket implementations display

Fixes rust-lang#63042

r? @kinnison
bors added a commit that referenced this pull request Dec 11, 2019
Rollup of 9 pull requests

Successful merges:

 - #66377 (Update RELEASES.md for 1.40.0)
 - #67134 (Ensure that we get a hard error on generic ZST constants if their bod…)
 - #67152 (Sort auto trait and blanket implementations display)
 - #67154 (Fix typos in src/libcore/alloc.rs docs)
 - #67168 (corrected comment in E0478)
 - #67178 (Move non clean impls items)
 - #67180 (doc: Use .copied() instead of .cloned() in Vec example)
 - #67181 (Update hashmap doc)
 - #67193 (In which we start tracking polonius in `-Z self-profile`)

Failed merges:

r? @ghost
@bors bors merged commit 9e3e421 into rust-lang:master Dec 11, 2019
@GuillaumeGomez GuillaumeGomez deleted the sort-auto-impls branch December 11, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] auto impl trait should be sorted
5 participants