-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM upgrades #6713
LLVM upgrades #6713
Conversation
This includes some of @brson's patches, plus one of mine. A multithreaded-llvm is necessary for running `rusti` tests in parallel, and in general is a good idea for running `rustc` in parallel.
It turns out that this change completely breaks rusti. After a lot of debugging, it turned out that the @brson, can you pull in the upstream LLVM changes into your branch? I could do so as well, but I'm not sure how many patches are custom to rust. I don't mind testing to make sure that LLVM passes by pushing through try. I don't think that bors will be able to handle this request normally. It'll need to be pushed to incoming manually, and then the bots need to all get their llvm workspaces wiped. |
@alexcrichton I rebased onto llvm trunk and pushed a rust commit that you can cherry-pick to my 'llvm' branch https://github.com/brson/rust/tree/llvm. Still testing it here. |
@alexcrichton Thanks for porting rustllvm. Sadly this branch doesn't build for me:
|
@brson I've been debugging this today, I've got a fix on the way, just going to make sure that it passes |
The build failures/bugs are probably best explained by the commits |
Just to keep this updated, this is currently blocked on a mysterious windows failure which comes from the upstream LLVM changes. |
…=graydon This is a reopening of #6570, and almost fixes #6511. Note that this doesn't actually enable building a threadsafe LLVM, because that will require an LLVM rebuild which will be bundled with the upgrades in #6713. What this does do, however, is removes all thread-unsafe usage of LLVM from the compiler.
…=graydon This is a reopening of #6570, and almost fixes #6511. Note that this doesn't actually enable building a threadsafe LLVM, because that will require an LLVM rebuild which will be bundled with the upgrades in #6713. What this does do, however, is removes all thread-unsafe usage of LLVM from the compiler.
* LLVM now has a C interface to LLVMBuildAtomicRMW * The exception handling support for the JIT seems to have been dropped * Various interfaces have been added or headers have changed
At the same time create a more robust wrapper to try to prevent this type of issue from cropping up in the future.
This is a reopening of #6713 This is still blocked on windows failures. I'll re-push try once the existing crisis has passed.
This is a reopening of #6713 This is still blocked on windows failures. I'll re-push try once the existing crisis has passed.
Add the from_str_radix_10 lint changelog: added the new `from_str_radix_10` which sometimes replaces calls to `primitive::from_str_radix` to `str::parse` This is ready to be merged, although maybe the category should be `pedantic` instead of `style`? I'm not sure where it fits better. Closes rust-lang#6713.
This includes some of @brson's patches, plus one of mine. A multithreaded-llvm is necessary for running
rusti
tests in parallel, and in general is a good idea for runningrustc
in parallel.