Use LLVM in a threadsafe fashion #7040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows parallel usage of the rustc library
Also stop leaking the ExecutionEngine created for jit code by forcibly disposing of it after the JIT code has finished executing
bors
added a commit
that referenced
this pull request
Jun 11, 2013
…=graydon This is a reopening of #6570, and almost fixes #6511. Note that this doesn't actually enable building a threadsafe LLVM, because that will require an LLVM rebuild which will be bundled with the upgrades in #6713. What this does do, however, is removes all thread-unsafe usage of LLVM from the compiler.
|
@catamorphism, does this look like a similar error to #7006? Running this locally everything passes just fine, so could bors retry this? |
|
@alexcrichton Yeah, could be a race condition in that test :-( |
bors
added a commit
that referenced
this pull request
Jun 11, 2013
…=graydon This is a reopening of #6570, and almost fixes #6511. Note that this doesn't actually enable building a threadsafe LLVM, because that will require an LLVM rebuild which will be bundled with the upgrades in #6713. What this does do, however, is removes all thread-unsafe usage of LLVM from the compiler.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 14, 2022
new lint that detects useless match expression fixes rust-lang#7040 changelog: Add new lint [`needless_match`] under complexity lint group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reopening of #6570, and almost fixes #6511.
Note that this doesn't actually enable building a threadsafe LLVM, because that will require an LLVM rebuild which will be bundled with the upgrades in #6713.
What this does do, however, is removes all thread-unsafe usage of LLVM from the compiler.