Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #67846

Closed
wants to merge 22 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jan 3, 2020

Successful merges:

Failed merges:

r? @ghost

RalfJung and others added 22 commits December 22, 2019 18:37
The test checks that we reuse the CGU of a crate when the implementation
details of an `extern crate` have changed.

Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.
- remove syntax::{help!, span_help!, span_note!}
- remove unused syntax::{struct_span_fatal, struct_span_err_or_warn!, span_err_or_warn!}
- lintify check_for_bindings_named_same_as_variants + conflicting_repr_hints
- inline syntax::{struct_span_warn!, diagnostic_used!}
- stringify_error_code! -> error_code! & use it more.
- find_plugin_registrar: de-fatalize an error
- de-fatalize metadata errors
- move type_error_struct! to rustc_typeck
- struct_span_err! -> rustc_errors
Suggest calling method when first argument is `self`

Closes: rust-lang#66782

I've explored different approaches for this MR but I think the most straightforward is the best one.

I've tried to find out if the methods for given type exist (to maybe have a better suggestion), but we don't collect them anywhere and collecting them is quite problematic. Moreover, collecting all the methods would require rewriting big part of the code and also could potentially include performance degradation, which I don't think is necessary for this simple case.
…akis

no longer promote non-pattern const functions

This is trying to pack-pedal a bit on promotion feature creep, as proposed by @eddyb [here](rust-lang/const-eval#19 (comment)): possibly, a sane subset of `const fn` that we could promote are those that are just constructors -- the same subset that we might want to allow in pattern position at some point.

So, this removes the `rustc_promotable` attribute from the three functions they identified that do not fit this pattern. The first step is to run crater to see if there is code in the wild that relies on this being promotable.

r? @oli-obk
…chenkov

More reductions in error handling diversity

In this follow up to rust-lang#67744, we:

- Remove all fatal / error / warning macros in `syntax` except for `struct_span_err`, which is moved to `rustc_errors`.

- Lintify some hard-coded warnings which used warning macros.

- Defatalize some errors.

In general, the goal here is to make it painful to use fatal or unstructured errors and so we hopefully won't see many of these creep in.
…sakis

Add a test for rust-lang#37333

The test checks that we reuse the CGU of a crate when the implementation
details of an `extern crate` have changed.

Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
…komatsakis

Cleanup linkchecker whitelist

linkchecker is no longer run on the compiler docs so they can be removed from the whitelist.
…r=Manishearth

Implement uncommon_codepoints lint.

Part of rust-lang#55467 .  The checks of `$crate` and `{{root}}` are very unfortunate. But i'm not sure where they belongs to.
tweak wording of mismatched delimiter errors

This PR improves the wording of the "incorrect delimiter" error messages. Here's a quick rationale:

- *"un-closed" -> "unclosed"*: "unclosed" is valid English, so there's no need to hyphenate the prefix. This should be pretty uncontroversial, I think.
- *"close delimiter" -> "closing delimiter"*: In my anecdotal experience, I've always heard "closing delimiter" or "closing parenthesis". In addition, the codebase already uses this terminology in comments and function names more than "close delimiter", which could indicate that it's more intuitive.
- "incorrect delimiter" -> "mismatched delimiter": "Incorrect delimiter" is vague; why is it incorrect? "mismatched" clearly indicates why the delimiter is causing the error.

r? @estebank
@Centril
Copy link
Contributor Author

Centril commented Jan 3, 2020

@bors r+ p=8 rollup=never

@bors
Copy link
Contributor

bors commented Jan 3, 2020

📌 Commit 3f83bc8 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 3, 2020
@Centril Centril added the rollup A PR which is a rollup label Jan 3, 2020
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-03T23:23:05.9162179Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-03T23:23:05.9429178Z ##[command]git config gc.auto 0
2020-01-03T23:23:05.9513009Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-03T23:23:05.9567462Z ##[command]git config --get-all http.proxy
2020-01-03T23:23:05.9745762Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67846/merge:refs/remotes/pull/67846/merge
---
2020-01-04T00:18:13.6340123Z .................................................................................................... 1500/9472
2020-01-04T00:18:19.4993552Z .................................................................................................... 1600/9472
2020-01-04T00:18:24.8802411Z .................................................................................................... 1700/9472
2020-01-04T00:18:34.6781000Z .................................................................................................... 1800/9472
2020-01-04T00:18:42.9850903Z i................................................................................................... 1900/9472
2020-01-04T00:18:50.0714868Z ......................................................................................iiiii......... 2000/9472
2020-01-04T00:19:12.5095851Z .................................................................................................... 2200/9472
2020-01-04T00:19:14.9865186Z .................................................................................................... 2300/9472
2020-01-04T00:19:17.5526056Z .................................................................................................... 2400/9472
2020-01-04T00:19:23.7995594Z .................................................................................................... 2500/9472
---
2020-01-04T00:22:29.8456337Z ..................i...............i................................................................. 4900/9472
2020-01-04T00:22:39.9366744Z .................................................................................................... 5000/9472
2020-01-04T00:22:46.0748512Z ...............................................................i.................................... 5100/9472
2020-01-04T00:22:54.4644375Z .................................................................................................... 5200/9472
2020-01-04T00:23:02.0177844Z ..............................ii.ii...........i..................................................... 5300/9472
2020-01-04T00:23:11.5665837Z .................................................................................................... 5500/9472
2020-01-04T00:23:21.8807666Z .................................................................................................... 5600/9472
2020-01-04T00:23:28.8520226Z ..............i..................................................................................... 5700/9472
2020-01-04T00:23:34.9904742Z .................................................................................................... 5800/9472
2020-01-04T00:23:34.9904742Z .................................................................................................... 5800/9472
2020-01-04T00:23:46.5547090Z .................................................................................................... 5900/9472
2020-01-04T00:23:58.4750648Z ...ii...i..ii...........i........................................................................... 6000/9472
2020-01-04T00:24:15.8491380Z .................................................................................................... 6200/9472
2020-01-04T00:24:23.7361023Z .................................................................................................... 6300/9472
2020-01-04T00:24:23.7361023Z .................................................................................................... 6300/9472
2020-01-04T00:24:42.5789712Z ..............................i..ii................................................................. 6400/9472
2020-01-04T00:25:03.3318696Z .................................................................................................... 6600/9472
2020-01-04T00:25:05.5908471Z ......i............................................................................................. 6700/9472
2020-01-04T00:25:07.9833402Z .................................................................................................... 6800/9472
2020-01-04T00:25:11.2592910Z .....i.............................................................................................. 6900/9472
---
2020-01-04T00:26:50.2110327Z .................................................................................................... 7500/9472
2020-01-04T00:26:54.9167825Z .................................................................................................... 7600/9472
2020-01-04T00:26:59.9522723Z .................................................................................................... 7700/9472
2020-01-04T00:27:11.1189257Z .................................................................................................... 7800/9472
2020-01-04T00:27:18.9908129Z ........................................iiii........................................................ 7900/9472
2020-01-04T00:27:34.2056769Z .................................................................................................... 8100/9472
2020-01-04T00:27:42.8369506Z .................................................................................................... 8200/9472
2020-01-04T00:27:56.8085605Z .................................................................................................... 8300/9472
2020-01-04T00:28:04.6833510Z .................................................................................................... 8400/9472
---
2020-01-04T00:30:08.0300111Z ---- [ui] ui/pattern/issue-67776-match-same-name-enum-variant-refs.rs stdout ----
2020-01-04T00:30:08.0300384Z diff of stderr:
2020-01-04T00:30:08.0300483Z 
2020-01-04T00:30:08.0300551Z 3    |
2020-01-04T00:30:08.0300641Z 4 LL |         Bar => {},
2020-01-04T00:30:08.0300697Z 5    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T00:30:08.0301240Z +    = note: `#[warn(bindings_with_variant_name)]` on by default
2020-01-04T00:30:08.0301290Z 6 
2020-01-04T00:30:08.0301290Z 6 
2020-01-04T00:30:08.0301518Z 7 warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0301994Z 
2020-01-04T00:30:08.0302023Z 
2020-01-04T00:30:08.0302089Z The actual stderr differed from the expected stderr.
2020-01-04T00:30:08.0302489Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/issue-67776-match-same-name-enum-variant-refs.stderr
2020-01-04T00:30:08.0302489Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/issue-67776-match-same-name-enum-variant-refs.stderr
2020-01-04T00:30:08.0302763Z To update references, rerun the tests and pass the `--bless` flag
2020-01-04T00:30:08.0303106Z To only update this specific test, also pass `--test-args pattern/issue-67776-match-same-name-enum-variant-refs.rs`
2020-01-04T00:30:08.0303205Z error: 1 errors occurred comparing output.
2020-01-04T00:30:08.0303483Z status: exit code: 0
2020-01-04T00:30:08.0303483Z status: exit code: 0
2020-01-04T00:30:08.0304536Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/auxiliary" "-A" "unused"
2020-01-04T00:30:08.0304950Z ------------------------------------------
2020-01-04T00:30:08.0304991Z 
2020-01-04T00:30:08.0305489Z ------------------------------------------
2020-01-04T00:30:08.0305546Z stderr:
2020-01-04T00:30:08.0305546Z stderr:
2020-01-04T00:30:08.0305956Z ------------------------------------------
2020-01-04T00:30:08.0306189Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0306658Z    |
2020-01-04T00:30:08.0306703Z LL |         Bar => {},
2020-01-04T00:30:08.0306703Z LL |         Bar => {},
2020-01-04T00:30:08.0306907Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T00:30:08.0307033Z    = note: `#[warn(bindings_with_variant_name)]` on by default
2020-01-04T00:30:08.0307219Z 
2020-01-04T00:30:08.0307219Z 
2020-01-04T00:30:08.0307342Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0307942Z    |
2020-01-04T00:30:08.0308038Z LL |         Baz => {},
2020-01-04T00:30:08.0308038Z LL |         Baz => {},
2020-01-04T00:30:08.0308092Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T00:30:08.0308127Z 
2020-01-04T00:30:08.0308188Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0308852Z    |
2020-01-04T00:30:08.0308948Z LL |         Bar => {},
2020-01-04T00:30:08.0308948Z LL |         Bar => {},
2020-01-04T00:30:08.0309024Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T00:30:08.0309059Z 
2020-01-04T00:30:08.0309136Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0309570Z    |
2020-01-04T00:30:08.0309769Z LL |         Baz => {},
2020-01-04T00:30:08.0309769Z LL |         Baz => {},
2020-01-04T00:30:08.0310093Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T00:30:08.0310153Z 
2020-01-04T00:30:08.0310227Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0310966Z    |
2020-01-04T00:30:08.0311060Z LL |         Bar => {},
2020-01-04T00:30:08.0311060Z LL |         Bar => {},
2020-01-04T00:30:08.0311113Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T00:30:08.0311174Z 
2020-01-04T00:30:08.0311264Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T00:30:08.0311842Z    |
2020-01-04T00:30:08.0311953Z LL |         Baz => {},
2020-01-04T00:30:08.0311953Z LL |         Baz => {},
2020-01-04T00:30:08.0312006Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T00:30:08.0312079Z 
2020-01-04T00:30:08.0312380Z ------------------------------------------
2020-01-04T00:30:08.0312416Z 
2020-01-04T00:30:08.0312443Z 
---
2020-01-04T00:30:08.0326897Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-04T00:30:08.0327390Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-04T00:30:08.0337769Z 
2020-01-04T00:30:08.0338031Z 
2020-01-04T00:30:08.0340051Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-04T00:30:08.0340634Z 
2020-01-04T00:30:08.0340801Z 
2020-01-04T00:30:08.0346903Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-04T00:30:08.0347309Z Build completed unsuccessfully in 1:00:23
2020-01-04T00:30:08.0347309Z Build completed unsuccessfully in 1:00:23
2020-01-04T00:30:08.0401029Z == clock drift check ==
2020-01-04T00:30:08.0421366Z   local time: Sat Jan  4 00:30:08 UTC 2020
2020-01-04T00:30:08.5715145Z   network time: Sat, 04 Jan 2020 00:30:08 GMT
2020-01-04T00:30:08.5716743Z == end clock drift check ==
2020-01-04T00:30:09.6231772Z 
2020-01-04T00:30:09.6335033Z ##[error]Bash exited with code '1'.
2020-01-04T00:30:09.6410384Z ##[section]Starting: Checkout
2020-01-04T00:30:09.6412313Z ==============================================================================
2020-01-04T00:30:09.6412533Z Task         : Get sources
2020-01-04T00:30:09.6412586Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jan 4, 2020

⌛ Testing commit 3f83bc8 with merge d933e2f717fc60f05f6faa7a7f1754255be7841c...

@Centril Centril closed this Jan 4, 2020
@Centril Centril deleted the rollup-9zaegqp branch January 4, 2020 01:18
@rust-highfive
Copy link
Collaborator

The job i686-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-04T02:09:32.7494790Z ---- [ui] ui/pattern/issue-67776-match-same-name-enum-variant-refs.rs stdout ----
2020-01-04T02:09:32.7495160Z diff of stderr:
2020-01-04T02:09:32.7495220Z 
2020-01-04T02:09:32.7495280Z 3    |
2020-01-04T02:09:32.7495340Z 4 LL |         Bar => {},
2020-01-04T02:09:32.7495560Z 5    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T02:09:32.7495720Z +    = note: `#[warn(bindings_with_variant_name)]` on by default
2020-01-04T02:09:32.7495800Z 6 
2020-01-04T02:09:32.7495800Z 6 
2020-01-04T02:09:32.7495890Z 7 warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7496610Z 
2020-01-04T02:09:32.7496660Z 
2020-01-04T02:09:32.7496730Z The actual stderr differed from the expected stderr.
2020-01-04T02:09:32.7497450Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/issue-67776-match-same-name-enum-variant-refs.stderr
2020-01-04T02:09:32.7497450Z Actual stderr saved to /Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/issue-67776-match-same-name-enum-variant-refs.stderr
2020-01-04T02:09:32.7498080Z To update references, rerun the tests and pass the `--bless` flag
2020-01-04T02:09:32.7498840Z To only update this specific test, also pass `--test-args pattern/issue-67776-match-same-name-enum-variant-refs.rs`
2020-01-04T02:09:32.7499000Z error: 1 errors occurred comparing output.
2020-01-04T02:09:32.7499070Z status: exit code: 0
2020-01-04T02:09:32.7499070Z status: exit code: 0
2020-01-04T02:09:32.7501110Z command: "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs.rs" "-Zthreads=1" "--target=i686-apple-darwin" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui/pattern/issue-67776-match-same-name-enum-variant-refs/auxiliary" "-A" "unused"
2020-01-04T02:09:32.7502430Z ------------------------------------------
2020-01-04T02:09:32.7502720Z 
2020-01-04T02:09:32.7503360Z ------------------------------------------
2020-01-04T02:09:32.7503700Z stderr:
2020-01-04T02:09:32.7503700Z stderr:
2020-01-04T02:09:32.7504300Z ------------------------------------------
2020-01-04T02:09:32.7504670Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7505740Z    |
2020-01-04T02:09:32.7505870Z LL |         Bar => {},
2020-01-04T02:09:32.7505870Z LL |         Bar => {},
2020-01-04T02:09:32.7505980Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T02:09:32.7506220Z    = note: `#[warn(bindings_with_variant_name)]` on by default
2020-01-04T02:09:32.7506310Z 
2020-01-04T02:09:32.7506310Z 
2020-01-04T02:09:32.7506420Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7507480Z    |
2020-01-04T02:09:32.7507600Z LL |         Baz => {},
2020-01-04T02:09:32.7507600Z LL |         Baz => {},
2020-01-04T02:09:32.7507730Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T02:09:32.7507810Z 
2020-01-04T02:09:32.7507940Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7508970Z    |
2020-01-04T02:09:32.7509320Z LL |         Bar => {},
2020-01-04T02:09:32.7509320Z LL |         Bar => {},
2020-01-04T02:09:32.7509430Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T02:09:32.7509500Z 
2020-01-04T02:09:32.7509610Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7510670Z    |
2020-01-04T02:09:32.7510810Z LL |         Baz => {},
2020-01-04T02:09:32.7510810Z LL |         Baz => {},
2020-01-04T02:09:32.7510940Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T02:09:32.7511020Z 
2020-01-04T02:09:32.7511140Z warning[E0170]: pattern binding `Bar` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7512320Z    |
2020-01-04T02:09:32.7512450Z LL |         Bar => {},
2020-01-04T02:09:32.7512450Z LL |         Bar => {},
2020-01-04T02:09:32.7512580Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Bar`
2020-01-04T02:09:32.7512660Z 
2020-01-04T02:09:32.7512790Z warning[E0170]: pattern binding `Baz` is named the same as one of the variants of the type `Foo`
2020-01-04T02:09:32.7513850Z    |
2020-01-04T02:09:32.7513980Z LL |         Baz => {},
2020-01-04T02:09:32.7513980Z LL |         Baz => {},
2020-01-04T02:09:32.7514260Z    |         ^^^ help: to match on the variant, qualify the path: `Foo::Baz`
2020-01-04T02:09:32.7514810Z 
2020-01-04T02:09:32.7515530Z ------------------------------------------
2020-01-04T02:09:32.7515880Z 
2020-01-04T02:09:32.7515990Z 
---
2020-01-04T02:09:32.7585770Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2020-01-04T02:09:32.7585910Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-04T02:09:32.7603070Z 
2020-01-04T02:09:32.7603160Z 
2020-01-04T02:09:32.7606650Z command did not execute successfully: "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/lib/rustlib/i686-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.163.1/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/test/ui" "--stage-id" "stage2-i686-apple-darwin" "--mode" "ui" "--target" "i686-apple-darwin" "--host" "i686-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.163.1/work/1/s/build/i686-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.42.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-04T02:09:32.7607820Z 
2020-01-04T02:09:32.7607870Z 
2020-01-04T02:09:32.7617650Z failed to run: /Users/runner/runners/2.163.1/work/1/s/build/bootstrap/debug/bootstrap test
2020-01-04T02:09:32.7617780Z Build completed unsuccessfully in 0:48:43
2020-01-04T02:09:32.7617780Z Build completed unsuccessfully in 0:48:43
2020-01-04T02:09:32.7678420Z == clock drift check ==
2020-01-04T02:09:32.7735000Z   local time: Sat Jan  4 02:09:32 UTC 2020
2020-01-04T02:09:32.8274350Z   network time: Sat, 04 Jan 2020 02:09:32 GMT
2020-01-04T02:09:32.8276030Z == end clock drift check ==
2020-01-04T02:09:32.8318930Z 
2020-01-04T02:09:32.8424620Z ##[error]Bash exited with code '1'.
2020-01-04T02:09:32.8467720Z ##[section]Starting: Checkout
2020-01-04T02:09:32.8470410Z ==============================================================================
2020-01-04T02:09:32.8470530Z Task         : Get sources
2020-01-04T02:09:32.8470610Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants