Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use named fields for {ast,hir}::ItemKind::Impl #68204

Merged
merged 2 commits into from
Jan 18, 2020

Conversation

ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Jan 14, 2020

Currently, the widely used ItemKind::Impl variant is a tuple with seven fields. I want to add an eighth in #68140, which means I have to update most matches on this variant anyways. Giving a name to each field improves readability and makes future changes of this nature much simpler.

This change will cause several tools to break. I will fix them once this is merged.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-14T05:54:21.4389751Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-14T05:54:21.4493036Z ##[command]git config gc.auto 0
2020-01-14T05:54:21.4579987Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-14T05:54:21.4637046Z ##[command]git config --get-all http.proxy
2020-01-14T05:54:21.4799017Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68204/merge:refs/remotes/pull/68204/merge
---
2020-01-14T06:56:32.8836763Z ........................................i...............i........................................... 4900/9518
2020-01-14T06:56:42.4230536Z .................................................................................................... 5000/9518
2020-01-14T06:56:49.1492669Z ...................................................................................i................ 5100/9518
2020-01-14T06:56:54.8150985Z .................................................................................................... 5200/9518
2020-01-14T06:57:05.6256054Z ......................................................ii.ii...........i............................. 5300/9518
2020-01-14T06:57:15.0942867Z .................................................................................................... 5500/9518
2020-01-14T06:57:25.5587173Z .................................................................................................... 5600/9518
2020-01-14T06:57:32.5033550Z .......................................i............................................................ 5700/9518
2020-01-14T06:57:39.2699669Z .................................................................................................... 5800/9518
2020-01-14T06:57:39.2699669Z .................................................................................................... 5800/9518
2020-01-14T06:57:50.6601535Z .................................................................................................... 5900/9518
2020-01-14T06:58:00.9753060Z ..............................ii...i..ii...........i................................................ 6000/9518
2020-01-14T06:58:20.3360162Z .................................................................................................... 6200/9518
2020-01-14T06:58:28.7009630Z .................................................................................................... 6300/9518
2020-01-14T06:58:28.7009630Z .................................................................................................... 6300/9518
2020-01-14T06:58:41.2569903Z ..........................................................i..ii..................................... 6400/9518
2020-01-14T06:59:10.2379943Z .................................................................................................... 6600/9518
2020-01-14T06:59:12.5355760Z ..................................i................................................................. 6700/9518
2020-01-14T06:59:14.8320693Z .................................................................................................... 6800/9518
2020-01-14T06:59:17.4795154Z ..................................i................................................................. 6900/9518
---
2020-01-14T07:00:53.5152852Z .................................................................................................... 7400/9518
2020-01-14T07:00:58.8072096Z .................................................................................................... 7500/9518
2020-01-14T07:01:03.2588495Z .................................................................................................... 7600/9518
2020-01-14T07:01:09.5196863Z .................................................................................................... 7700/9518
2020-01-14T07:01:17.0281254Z .....................................................FF............................................. 7800/9518
2020-01-14T07:01:27.2587948Z ....................................................................................iiii............ 7900/9518
2020-01-14T07:01:44.4946088Z .................i......i........................................................................... 8100/9518
2020-01-14T07:01:49.9100097Z .................................................................................................... 8200/9518
2020-01-14T07:02:04.0548925Z .................................................................................................... 8300/9518
2020-01-14T07:02:14.4945888Z .................................................................................................... 8400/9518
---
2020-01-14T07:04:20.7255296Z failures:
2020-01-14T07:04:20.7275270Z 
2020-01-14T07:04:20.7276396Z ---- [ui] ui/rfc-2632-const-trait-impl/feature-gate.rs#gated stdout ----
2020-01-14T07:04:20.7276704Z 
2020-01-14T07:04:20.7276930Z error in revision `gated`: ui test compiled successfully!
2020-01-14T07:04:20.7277251Z status: exit code: 0
2020-01-14T07:04:20.7278453Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2632-const-trait-impl/feature-gate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "gated" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2632-const-trait-impl/feature-gate.gated" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2632-const-trait-impl/feature-gate.gated/auxiliary" "-A" "unused"
2020-01-14T07:04:20.7279283Z ------------------------------------------
2020-01-14T07:04:20.7279550Z 
2020-01-14T07:04:20.7280010Z ------------------------------------------
2020-01-14T07:04:20.7280268Z stderr:
---
2020-01-14T07:04:20.7281844Z 
2020-01-14T07:04:20.7282316Z ---- [ui] ui/rfc-2632-const-trait-impl/feature-gate.rs#stock stdout ----
2020-01-14T07:04:20.7282579Z diff of stderr:
2020-01-14T07:04:20.7282796Z 
2020-01-14T07:04:20.7283431Z 7    = note: for more information, see ***/issues/67792
2020-01-14T07:04:20.7283972Z 9 
2020-01-14T07:04:20.7284428Z - error: const trait impls are not yet implemented
2020-01-14T07:04:20.7284932Z -   --> $DIR/feature-gate.rs:9:1
2020-01-14T07:04:20.7285541Z -    |
2020-01-14T07:04:20.7285541Z -    |
2020-01-14T07:04:20.7288534Z - LL | impl const T for S {}
2020-01-14T07:04:20.7290945Z - 
2020-01-14T07:04:20.7291190Z - error: aborting due to 2 previous errors
2020-01-14T07:04:20.7296486Z + error: aborting due to previous error
2020-01-14T07:04:20.7297018Z 17 
2020-01-14T07:04:20.7297018Z 17 
2020-01-14T07:04:20.7298296Z 18 For more information about this error, try `rustc --explain E0658`.
2020-01-14T07:04:20.7299461Z 19 
2020-01-14T07:04:20.7299857Z 
2020-01-14T07:04:20.7299981Z 
2020-01-14T07:04:20.7300051Z The actual stderr differed from the expected stderr.
2020-01-14T07:04:20.7300681Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2632-const-trait-impl/feature-gate.stock/feature-gate.stock.stderr
2020-01-14T07:04:20.7301164Z To update references, rerun the tests and pass the `--bless` flag
2020-01-14T07:04:20.7301518Z To only update this specific test, also pass `--test-args rfc-2632-const-trait-impl/feature-gate.rs`
2020-01-14T07:04:20.7301580Z 
2020-01-14T07:04:20.7301749Z error in revision `stock`: 1 errors occurred comparing output.
2020-01-14T07:04:20.7301797Z status: exit code: 1
2020-01-14T07:04:20.7302770Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2632-const-trait-impl/feature-gate.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "stock" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2632-const-trait-impl/feature-gate.stock" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2632-const-trait-impl/feature-gate.stock/auxiliary" "-A" "unused"
2020-01-14T07:04:20.7303131Z ------------------------------------------
2020-01-14T07:04:20.7303166Z 
2020-01-14T07:04:20.7303388Z ------------------------------------------
2020-01-14T07:04:20.7303618Z stderr:
2020-01-14T07:04:20.7303618Z stderr:
2020-01-14T07:04:20.7303904Z ------------------------------------------
2020-01-14T07:04:20.7303955Z error[E0658]: const trait impls are experimental
2020-01-14T07:04:20.7304221Z   --> /checkout/src/test/ui/rfc-2632-const-trait-impl/feature-gate.rs:9:6
2020-01-14T07:04:20.7304269Z    |
2020-01-14T07:04:20.7304314Z LL | impl const T for S {}
2020-01-14T07:04:20.7304468Z    |
2020-01-14T07:04:20.7304468Z    |
2020-01-14T07:04:20.7304793Z    = note: for more information, see ***/issues/67792
2020-01-14T07:04:20.7304901Z 
2020-01-14T07:04:20.7304943Z error: aborting due to previous error
2020-01-14T07:04:20.7304971Z 
2020-01-14T07:04:20.7305404Z For more information about this error, try `rustc --explain E0658`.
---
2020-01-14T07:04:20.7307453Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:387:22
2020-01-14T07:04:20.7307518Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2020-01-14T07:04:20.7324133Z 
2020-01-14T07:04:20.7324219Z 
2020-01-14T07:04:20.7326268Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-14T07:04:20.7326639Z 
2020-01-14T07:04:20.7326693Z 
2020-01-14T07:04:20.7335038Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-14T07:04:20.7335115Z Build completed unsuccessfully in 1:04:17
2020-01-14T07:04:20.7335115Z Build completed unsuccessfully in 1:04:17
2020-01-14T07:04:20.7397982Z == clock drift check ==
2020-01-14T07:04:20.7417755Z   local time: Tue Jan 14 07:04:20 UTC 2020
2020-01-14T07:04:21.0579853Z   network time: Tue, 14 Jan 2020 07:04:21 GMT
2020-01-14T07:04:21.0584416Z == end clock drift check ==
2020-01-14T07:04:21.4782996Z 
2020-01-14T07:04:21.4901824Z ##[error]Bash exited with code '1'.
2020-01-14T07:04:21.4941703Z ##[section]Starting: Checkout
2020-01-14T07:04:21.4943346Z ==============================================================================
2020-01-14T07:04:21.4943396Z Task         : Get sources
2020-01-14T07:04:21.4943468Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 14, 2020

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Jan 14, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 14, 2020

cc @petrochenkov @Centril

@Centril
Copy link
Contributor

Centril commented Jan 15, 2020

Seems fine to me; just make sure to use exhaustive matching where appropriate by enumerating the fields with field: _, but it seems like that's already done.

polarity: _,
defaultness: _,
ref generics,
ref of_trait,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "of" signifies here. I would rename this to trait_ref and let the type system speak to the Option<_>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Some if the item is an impl of a trait.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what does the f stand for? (I know what the field means.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"of" like the preposition. An impl of a trait.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Well that was far from obvious. :) Given that you had to ELI5 it for me, could we change it to something else?

Copy link
Contributor Author

@ecstatic-morse ecstatic-morse Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could, although to be honest I'm not enthusiastic about it. On a personal note, I have less time to contribute to open source this year, and having to spend some of it arguing over trivial choices like this has left me feeling a bit bummed out 😢.

edit: I'm aware that "arguing" requires two parties, so I'm partly responsible for using my time this way. I suppose I just don't see the value in this kind of extremely granular review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Fwiw, I didn't think we were arguing -- I was just confused as to what it signified.)

@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 15, 2020

📌 Commit 134692b904dcbb12ca8d15d96bba4c7ca487e4e3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 15, 2020

@bors r- oh overlooked the of_trait thing

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2020

@bors r+ while i did stumble over of_trait, too, there are docs explaining it

@bors
Copy link
Contributor

bors commented Jan 16, 2020

📌 Commit 134692b904dcbb12ca8d15d96bba4c7ca487e4e3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2020

In case this bitrots, rebase and r=me with p=1

bors added a commit that referenced this pull request Jan 16, 2020
Rollup of 5 pull requests

Successful merges:

 - #67780 (Move some queries from rustc::ty to librustc_ty.)
 - #68096 (Clean up some diagnostics by making them more consistent)
 - #68223 (Use 3.6 instead of 3.5 in float fract() documentation)
 - #68265 (Fix some issue numbers of unstable features)
 - #68266 (Changed docs for f32 and f64.)

Failed merges:

 - #68204 (Use named fields for `{ast,hir}::ItemKind::Impl`)

r? @ghost
@bors
Copy link
Contributor

bors commented Jan 16, 2020

☔ The latest upstream changes (presumably #68272) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2020

@bors p=1

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-01-18T00:09:27.8278748Z ========================== Starting Command Output ===========================
2020-01-18T00:09:27.8280396Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/5f8a4a81-d1d0-4182-bc87-bca63d09ab62.sh
2020-01-18T00:09:27.8280437Z 
2020-01-18T00:09:27.8283905Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-18T00:09:27.8290640Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68204/merge to s
2020-01-18T00:09:27.8292559Z Task         : Get sources
2020-01-18T00:09:27.8292585Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-18T00:09:27.8292634Z Version      : 1.0.0
2020-01-18T00:09:27.8292659Z Author       : Microsoft
---
2020-01-18T00:09:28.8234499Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-18T00:09:28.8245654Z ##[command]git config gc.auto 0
2020-01-18T00:09:28.8247925Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-18T00:09:28.8251402Z ##[command]git config --get-all http.proxy
2020-01-18T00:09:28.8257106Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68204/merge:refs/remotes/pull/68204/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ecstatic-morse
Copy link
Contributor Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jan 18, 2020

📌 Commit 4743995 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2020
tmandry added a commit to tmandry/rust that referenced this pull request Jan 18, 2020
…i-obk

Use named fields for `{ast,hir}::ItemKind::Impl`

Currently, the widely used `ItemKind::Impl` variant is a tuple with seven fields. I want to add an eighth in rust-lang#68140, which means I have to update most matches on this variant anyways. Giving a name to each field improves readability and makes future changes of this nature much simpler.

This change will cause several tools to break. I will fix them once this is merged.
bors added a commit that referenced this pull request Jan 18, 2020
Rollup of 9 pull requests

Successful merges:

 - #66660 (Don't warn about snake case for field puns.)
 - #68093 (Fix deref impl typedef)
 - #68204 (Use named fields for `{ast,hir}::ItemKind::Impl`)
 - #68256 (Do not ICE on malformed suggestion spans)
 - #68279 (Clean up E0198 explanation)
 - #68291 (Update sanitizer tests)
 - #68312 (Add regression test for integer literals in generic arguments in where clauses)
 - #68314 (Stop treating `FalseEdges` and `FalseUnwind` as having semantic value for const eval)
 - #68317 (Clean up E0199 explanation)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jan 18, 2020

⌛ Testing commit 4743995 with merge 8c28fe8...

@bors bors merged commit 4743995 into rust-lang:master Jan 18, 2020
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 18, 2020
JohnTitor added a commit to JohnTitor/rust-clippy that referenced this pull request Jan 18, 2020
ecstatic-morse added a commit to ecstatic-morse/rust-clippy that referenced this pull request Jan 18, 2020
`{ast,hir}::ItemKind::Impl` use named fields now
bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 18, 2020
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 18, 2020
Changes:
````
Downgrade range_plus_one to pedantic
Rustup to rust-lang#68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily
````
bors added a commit that referenced this pull request Jan 18, 2020
submodules: update clippy from a8d90f6 to 7ae2442

Changes:
````
Downgrade range_plus_one to pedantic
Rustup to #68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily
````
Fixes #68331
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 19, 2020
Changes:
````
Treat more strange pattern
Split up `if_same_then_else` ui test
Apply review comments
Run `update_lints`
Reduce span range
Rename `ok_if_let` to `if_let_some_result`
Apply review comments
Add suggestion in `if_let_some_result`
rustup rust-lang#67712
Allow `unused_self` lint at the function level
Downgrade range_plus_one to pedantic
Rustup to rust-lang#68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily
Split up `booleans` ui test
Fix the ordering on `nonminimal_bool`
````
bors added a commit that referenced this pull request Jan 19, 2020
submodules: update clippy from a8d90f6 to 7ae2442

Changes:
````
Downgrade range_plus_one to pedantic
Rustup to #68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily
````
Fixes #68331
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
Changes:
````
Treat more strange pattern
Split up `if_same_then_else` ui test
Apply review comments
Run `update_lints`
Reduce span range
Rename `ok_if_let` to `if_let_some_result`
Apply review comments
Add suggestion in `if_let_some_result`
rustup rust-lang/rust#67712
Allow `unused_self` lint at the function level
Downgrade range_plus_one to pedantic
Rustup to rust-lang/rust#68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily
Split up `booleans` ui test
Fix the ordering on `nonminimal_bool`
````
@ecstatic-morse ecstatic-morse deleted the item-kind-impl branch October 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants