submodules: update clippy from a8d90f6a to 7ae24429 #68343

matthiaskrgr · 2020-01-18T14:39:46Z

Changes:

Downgrade range_plus_one to pedantic
Rustup to rust-lang/rust#68204
Add lifetimes to `LateLintPass`
Fix rustc lint import paths generated by `new_lint`
Add lint for default lint description
Update documentation for adding new lints
Generate new lints easily

Fixes #68331

rust-highfive · 2020-01-18T14:39:57Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-01-18T14:39:57Z

⚠️ Warning ⚠️

These commits modify submodules.

matthiaskrgr · 2020-01-18T14:40:00Z

r? @oli-obk @Manishearth

oli-obk · 2020-01-18T16:02:15Z

@bors r+ p=1

bors · 2020-01-18T16:02:17Z

📌 Commit 716f47a has been approved by oli-obk

bors · 2020-01-18T22:08:44Z

⌛ Testing commit 716f47a with merge e72f17c...

submodules: update clippy from a8d90f6 to 7ae2442 Changes: ```` Downgrade range_plus_one to pedantic Rustup to #68204 Add lifetimes to `LateLintPass` Fix rustc lint import paths generated by `new_lint` Add lint for default lint description Update documentation for adding new lints Generate new lints easily ```` Fixes #68331

bors · 2020-01-19T00:38:44Z

💔 Test failed - checks-azure

rust-highfive · 2020-01-19T00:38:45Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-18T23:59:21.2985063Z test [ui] ui/path_buf_push_overwrite.rs ... ok
2020-01-18T23:59:21.3945592Z 
2020-01-18T23:59:21.3949974Z error: failed to compile fixed code
2020-01-18T23:59:21.3953067Z status: exit code: 1
2020-01-18T23:59:21.3963984Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools-bin/clippy-driver" "tests/ui/patterns.fixed" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-50e1ee08d654e11f/out/test_build_base" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-50e1ee08d654e11f/out/test_build_base/patterns.stage-id" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps" "-Dwarnings" "-Zui-testing" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libserde-e872394251f07f48.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libregex-2b50a9c81f92b99d.rlib" "--extern" "clippy_lints=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libclippy_lints-2cea9c273f40f029.rlib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/clippy-50e1ee08d654e11f/out/test_build_base/patterns.stage-id.aux"
2020-01-18T23:59:21.3965123Z ------------------------------------------
2020-01-18T23:59:21.3969035Z 
2020-01-18T23:59:21.3969610Z ------------------------------------------
2020-01-18T23:59:21.3969676Z stderr:
2020-01-18T23:59:21.3969676Z stderr:
2020-01-18T23:59:21.3969895Z ------------------------------------------
2020-01-18T23:59:21.3975957Z {"message":"the feature `slice_patterns` has been stable since 1.42.0 and no longer requires an attribute to enable","code":{"code":"stable_features","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/patterns.fixed","byte_start":66,"byte_end":80,"line_start":4,"line_end":4,"column_start":12,"column_end":26,"is_primary":true,"text":[{"text":"#![feature(slice_patterns)]","highlight_start":12,"highlight_end":26}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D stable-features` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: the feature `slice_patterns` has been stable since 1.42.0 and no longer requires an attribute to enable\n  --> tests/ui/patterns.fixed:4:12\n   |\nLL | #![feature(slice_patterns)]\n   |            ^^^^^^^^^^^^^^\n   |\n   = note: `-D stable-features` implied by `-D warnings`\n\n"}
2020-01-18T23:59:21.3981056Z 
2020-01-18T23:59:21.3981463Z ------------------------------------------
2020-01-18T23:59:21.3981506Z 
2020-01-18T23:59:21.3989951Z test [ui] ui/patterns.rs ... FAILED
---
2020-01-19T00:36:43.7015358Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2020-01-19T00:36:43.7015415Z 
2020-01-19T00:36:43.7015851Z We detected that this PR updated 'clippy-driver', but its tests failed.
2020-01-19T00:36:43.7015905Z 
2020-01-19T00:36:43.7016182Z If you do intend to update 'clippy-driver', please check the error messages above and
2020-01-19T00:36:43.7016275Z commit another update.
2020-01-19T00:36:43.7016331Z 
2020-01-19T00:36:43.7016942Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2020-01-19T00:36:43.7017238Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2020-01-19T00:36:43.7017671Z proper steps.
2020-01-19T00:36:43.7021579Z Build completed unsuccessfully in 0:00:01
2020-01-19T00:36:43.7069809Z == clock drift check ==
2020-01-19T00:36:43.7085350Z   local time: Sun Jan 19 00:36:43 UTC 2020
2020-01-19T00:36:44.2370363Z   network time: Sun, 19 Jan 2020 00:36:44 GMT
2020-01-19T00:36:44.2370363Z   network time: Sun, 19 Jan 2020 00:36:44 GMT
2020-01-19T00:36:44.2370477Z == end clock drift check ==
2020-01-19T00:36:45.5469573Z 
2020-01-19T00:36:45.5562701Z ##[error]Bash exited with code '1'.
2020-01-19T00:36:45.5598256Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-01-19T00:36:45.5600381Z ==============================================================================
2020-01-19T00:36:45.5600476Z Task         : Get sources
2020-01-19T00:36:45.5600579Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Changes: ```` Treat more strange pattern Split up `if_same_then_else` ui test Apply review comments Run `update_lints` Reduce span range Rename `ok_if_let` to `if_let_some_result` Apply review comments Add suggestion in `if_let_some_result` rustup rust-lang#67712 Allow `unused_self` lint at the function level Downgrade range_plus_one to pedantic Rustup to rust-lang#68204 Add lifetimes to `LateLintPass` Fix rustc lint import paths generated by `new_lint` Add lint for default lint description Update documentation for adding new lints Generate new lints easily Split up `booleans` ui test Fix the ordering on `nonminimal_bool` ````

matthiaskrgr · 2020-01-19T13:08:05Z

updated

oli-obk · 2020-01-19T13:15:05Z

@bors r+

bors · 2020-01-19T13:15:06Z

📌 Commit 188f0bb has been approved by oli-obk

bors · 2020-01-19T20:37:51Z

⌛ Testing commit 188f0bb with merge 7da653f...

submodules: update clippy from a8d90f6 to 7ae2442 Changes: ```` Downgrade range_plus_one to pedantic Rustup to #68204 Add lifetimes to `LateLintPass` Fix rustc lint import paths generated by `new_lint` Add lint for default lint description Update documentation for adding new lints Generate new lints easily ```` Fixes #68331

bors · 2020-01-20T00:10:37Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 7da653f to master...

rust-highfive · 2020-01-20T00:12:00Z

📣 Toolstate changed by #68343!

Tested on commit 7da653f.
Direct link to PR: #68343

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@7da653f. Direct link to PR: <rust-lang/rust#68343> 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive assigned alexcrichton Jan 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2020

rust-highfive assigned oli-obk and unassigned alexcrichton Jan 18, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2020

matthiaskrgr force-pushed the submodule_upd branch from 716f47a to 188f0bb Compare January 19, 2020 13:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 20, 2020

bors merged commit 188f0bb into rust-lang:master Jan 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

submodules: update clippy from a8d90f6a to 7ae24429 #68343

submodules: update clippy from a8d90f6a to 7ae24429 #68343

matthiaskrgr commented Jan 18, 2020

rust-highfive commented Jan 18, 2020

rust-highfive commented Jan 18, 2020

matthiaskrgr commented Jan 18, 2020

oli-obk commented Jan 18, 2020

bors commented Jan 18, 2020

bors commented Jan 18, 2020

bors commented Jan 19, 2020

rust-highfive commented Jan 19, 2020

matthiaskrgr commented Jan 19, 2020

oli-obk commented Jan 19, 2020

bors commented Jan 19, 2020

bors commented Jan 19, 2020

bors commented Jan 20, 2020

rust-highfive commented Jan 20, 2020

submodules: update clippy from a8d90f6a to 7ae24429 #68343

submodules: update clippy from a8d90f6a to 7ae24429 #68343

Conversation

matthiaskrgr commented Jan 18, 2020

rust-highfive commented Jan 18, 2020

rust-highfive commented Jan 18, 2020

matthiaskrgr commented Jan 18, 2020

oli-obk commented Jan 18, 2020

bors commented Jan 18, 2020

bors commented Jan 18, 2020

bors commented Jan 19, 2020

rust-highfive commented Jan 19, 2020

matthiaskrgr commented Jan 19, 2020

oli-obk commented Jan 19, 2020

bors commented Jan 19, 2020

bors commented Jan 19, 2020

bors commented Jan 20, 2020

rust-highfive commented Jan 20, 2020