Use BufWriter for emitting MIR #68460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
A quick grep for |
|
Ping from triage. @Mark-Simulacrum any updates on this? Thanks. |
|
Thanks, missed that a second commit was pushed. r=me once they're squashed into one. |
sinkuu
force-pushed
the
emit_mir_buffered
branch
from
05746e0
to
482c761
Compare
|
Squashed. |
|
@bors r+ rollup Thanks! |
|
📌 Commit 482c761 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
bors
added a commit
that referenced
this pull request
Feb 1, 2020
Rollup of 7 pull requests Successful merges: - #68460 (Use BufWriter for emitting MIR) - #68681 (Suggest path separator for single-colon typos) - #68688 ([docs] remind bug reporters to update nightly) - #68704 (Ignore `build` dir formatting) - #68727 (Remove a comment about pretty printer in formatting tests) - #68736 (Remove `Alloc` in favor of `AllocRef`) - #68740 (Do not suggest things named underscore) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
--emit=mirtakes long time on a large crate. #64344 seem to have fixed-Zdump-mir, but not--emit=mir.