Do not suggest things named underscore #68740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Feb 1, 2020
|
r? @Centril r=me with mine/@matthewjasper's suggestion (it's the same) applied. |
JohnTitor
force-pushed
the
do-not-sugg-underscore
branch
from
c7c07ec
to
726568b
Compare
|
@bors r+ rollup |
|
Thanks, both! Applied suggestion. |
|
📌 Commit 726568b has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…=Centril Do not suggest things named underscore Fixes rust-lang#68719 r? @estebank
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2020
…=Centril Do not suggest things named underscore Fixes rust-lang#68719 r? @estebank
bors
added a commit
that referenced
this pull request
Feb 1, 2020
Rollup of 7 pull requests Successful merges: - #68460 (Use BufWriter for emitting MIR) - #68681 (Suggest path separator for single-colon typos) - #68688 ([docs] remind bug reporters to update nightly) - #68704 (Ignore `build` dir formatting) - #68727 (Remove a comment about pretty printer in formatting tests) - #68736 (Remove `Alloc` in favor of `AllocRef`) - #68740 (Do not suggest things named underscore) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68719
r? @estebank