Add io::Write::write_all_vectored #70612

Thomasdezeeuw · 2020-03-31T13:18:35Z

Similar to io::Write::write_all but uses io::Write::write_vectored
instead.

rust-highfive · 2020-03-31T13:18:39Z

(rust_highfive has picked a reviewer for you, use r? to override)

Thomasdezeeuw · 2020-03-31T13:20:10Z

I went with the original implementation I suggested, just to get some experience with it. I was thinking that maybe we could always set bufs to an empty array, even in case of an error, as is already the case if everything gets written.

Centril · 2020-03-31T13:29:41Z

@Thomasdezeeuw Can you split the module after this PR? It's getting close to the 3000 LOC threshold.

Thomasdezeeuw · 2020-03-31T14:00:07Z

@Centril Sure, anything you suggest that should move to its own file? Or should I start with moving the tests?

Also I only ran libcore tests locally, so I'll fix the pr and push :)

Centril · 2020-03-31T14:30:14Z

@Thomasdezeeuw Some themes to consider:

Move out the traits vs. data types
Separate Read from Write
IoSlice (and vectored stuff) in its own module

rust-highfive · 2020-03-31T14:38:53Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-31T13:19:12.7180329Z ========================== Starting Command Output ===========================
2020-03-31T13:19:12.7182872Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d496787d-95fc-4938-8730-47e3869b3504.sh
2020-03-31T13:19:12.7183120Z 
2020-03-31T13:19:12.7186743Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-31T13:19:12.7207566Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T13:19:12.7210734Z Task         : Get sources
2020-03-31T13:19:12.7211057Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-31T13:19:12.7211350Z Version      : 1.0.0
2020-03-31T13:19:12.7211552Z Author       : Microsoft
---
2020-03-31T13:19:13.7245502Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-31T13:19:13.7250669Z ##[command]git config gc.auto 0
2020-03-31T13:19:13.7254471Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-31T13:19:13.7257750Z ##[command]git config --get-all http.proxy
2020-03-31T13:19:13.7263611Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70612/merge:refs/remotes/pull/70612/merge
---
2020-03-31T13:27:40.6970922Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-31T13:27:42.0363553Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-31T13:27:43.5182648Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-31T13:27:43.6672048Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-31T13:27:52.5517928Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T13:27:54.0168907Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-31T13:27:58.0764343Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-31T13:28:01.8545331Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-31T13:28:10.8617346Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-31T13:48:28.6446653Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-31T13:48:30.2544339Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-31T13:48:32.1201798Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-31T13:48:32.9584659Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-31T13:48:43.3120668Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T13:48:45.3506853Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-31T13:48:50.1833333Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-31T13:48:55.0603310Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-31T13:49:05.9805243Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-31T14:12:37.7771440Z .................................................................................................... 1700/9856
2020-03-31T14:12:41.4170171Z .................................................................................................... 1800/9856
2020-03-31T14:12:50.4147795Z ..........................................................................................i......... 1900/9856
2020-03-31T14:12:56.6989626Z .................................................................................................... 2000/9856
2020-03-31T14:13:02.4906645Z ................................................................................iiiii............... 2100/9856
2020-03-31T14:13:21.6085439Z .................................................................................................... 2300/9856
2020-03-31T14:13:23.5682806Z .................................................................................................... 2400/9856
2020-03-31T14:13:25.7774319Z .................................................................................................... 2500/9856
2020-03-31T14:13:31.7962839Z .................................................................................................... 2600/9856
---
2020-03-31T14:16:08.7399116Z ......................................................i...............i............................. 5000/9856
2020-03-31T14:16:16.0231730Z .................................................................................................... 5100/9856
2020-03-31T14:16:22.6791385Z ...................................................................................................i 5200/9856
2020-03-31T14:16:27.3834551Z .................................................................................................... 5300/9856
2020-03-31T14:16:37.1040253Z .....................................................................................ii.ii........i. 5400/9856
2020-03-31T14:16:40.4687696Z ..i................................................................................................. 5500/9856
2020-03-31T14:16:48.7290382Z ..............................i..................................................................... 5700/9856
2020-03-31T14:16:57.6795265Z ................................................ii....................................i............. 5800/9856
2020-03-31T14:17:04.4878261Z .................................................................................................... 5900/9856
2020-03-31T14:17:09.0076203Z .................................................................................................... 6000/9856
2020-03-31T14:17:09.0076203Z .................................................................................................... 6000/9856
2020-03-31T14:17:17.5523593Z ................................................................................ii...i..ii.......... 6100/9856
2020-03-31T14:17:29.0170143Z .i.................................................................................................. 6200/9856
2020-03-31T14:17:41.2154183Z .................................................................................................... 6400/9856
2020-03-31T14:17:44.4898548Z .................................................................................................... 6500/9856
2020-03-31T14:17:44.4898548Z .................................................................................................... 6500/9856
2020-03-31T14:17:55.5866802Z ..........i..ii..................................................................................... 6600/9856
2020-03-31T14:18:14.5667433Z .................................................................................................... 6800/9856
2020-03-31T14:18:16.5535450Z ..........i......................................................................................... 6900/9856
2020-03-31T14:18:18.5567743Z .................................................................................................... 7000/9856
2020-03-31T14:18:20.6105910Z ...............................................i.................................................... 7100/9856
---
2020-03-31T14:19:54.1465483Z .................................................................................................... 7800/9856
2020-03-31T14:19:59.0027672Z .................................................................................................... 7900/9856
2020-03-31T14:20:04.6018916Z .................................................................................................... 8000/9856
2020-03-31T14:20:12.1973926Z .......i............................................................................................ 8100/9856
2020-03-31T14:20:20.1600330Z ........................................................iiiiiiiiii.i................................ 8200/9856
2020-03-31T14:20:33.2158330Z i......i............................................................................................ 8400/9856
2020-03-31T14:20:38.0462509Z .................................................................................................... 8500/9856
2020-03-31T14:20:49.9567621Z .................................................................................................... 8600/9856
2020-03-31T14:20:59.0423085Z .................................................................................................... 8700/9856
---
2020-03-31T14:23:09.5337978Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-03-31T14:23:09.5516795Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T14:23:09.7436854Z 
2020-03-31T14:23:09.7437283Z running 183 tests
2020-03-31T14:23:12.3579051Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/183
2020-03-31T14:23:14.7629352Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-03-31T14:23:14.7631982Z 
2020-03-31T14:23:14.7637288Z  finished in 5.212
2020-03-31T14:23:14.7641264Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-03-31T14:23:14.7822025Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T14:23:16.6996342Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-03-31T14:23:16.7180523Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T14:23:16.8643713Z 
2020-03-31T14:23:16.8644488Z running 9 tests
2020-03-31T14:23:16.8646116Z iiiiiiiii
2020-03-31T14:23:16.8647689Z 
2020-03-31T14:23:16.8653834Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-03-31T14:23:16.8654536Z  finished in 0.146
2020-03-31T14:23:16.8845005Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T14:23:35.7454911Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-03-31T14:23:35.7686255Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T14:23:35.9482284Z 
2020-03-31T14:23:35.9483215Z running 115 tests
2020-03-31T14:23:48.5487763Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-31T14:23:50.0660489Z ...iiii.....ii.
2020-03-31T14:23:50.0672296Z 
2020-03-31T14:23:50.0672456Z  finished in 14.297
2020-03-31T14:23:50.0676778Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-03-31T14:23:50.0681445Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T14:35:05.0944627Z 
2020-03-31T14:35:05.0947227Z    Doc-tests core
2020-03-31T14:35:09.1847627Z 
2020-03-31T14:35:09.1848271Z running 2489 tests
2020-03-31T14:35:17.7690649Z ......iiiii......................................................................................... 100/2489
2020-03-31T14:35:26.0385716Z .....................................................................................ii............. 200/2489
2020-03-31T14:35:45.0300101Z ....................i............................................................................... 400/2489
2020-03-31T14:35:45.0300101Z ....................i............................................................................... 400/2489
2020-03-31T14:35:54.1550259Z ..........................................................................i..i..................iiii 500/2489
2020-03-31T14:36:09.3280965Z .................................................................................................... 700/2489
2020-03-31T14:36:17.1723352Z .................................................................................................... 800/2489
2020-03-31T14:36:25.0036904Z .................................................................................................... 900/2489
2020-03-31T14:36:32.6578566Z .................................................................................................... 1000/2489
---
2020-03-31T14:38:36.0468106Z    Compiling std v0.0.0 (/checkout/src/libstd)
2020-03-31T14:38:37.6888787Z error[E0425]: cannot find value `cx` in this scope
2020-03-31T14:38:37.6889628Z     --> src/libstd/io/mod.rs:2890:33
2020-03-31T14:38:37.6890272Z      |
2020-03-31T14:38:37.6891117Z 2890 |             self.write_vectored(cx, &[IoSlice::new(buf)])
2020-03-31T14:38:37.6892724Z 
2020-03-31T14:38:37.6892724Z 
2020-03-31T14:38:37.6952830Z error[E0425]: cannot find value `n_bus` in this scope
2020-03-31T14:38:37.6953656Z     --> src/libstd/io/mod.rs:2968:46
2020-03-31T14:38:37.6954293Z      |
2020-03-31T14:38:37.6955087Z 2968 |                 let mut writer = test_writer(n_bus, per_call);
2020-03-31T14:38:37.6956438Z      |                                              ^^^^^ help: a local variable with a similar name exists: `n_bufs`
2020-03-31T14:38:41.0993052Z error[E0061]: this function takes 1 argument but 2 arguments were supplied
2020-03-31T14:38:41.0994888Z     --> src/libstd/io/mod.rs:2890:18
2020-03-31T14:38:41.0995736Z      |
2020-03-31T14:38:41.0995736Z      |
2020-03-31T14:38:41.0996908Z 1303 |     fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> Result<usize> {
2020-03-31T14:38:41.0999260Z ...
2020-03-31T14:38:41.0999260Z ...
2020-03-31T14:38:41.1000244Z 2890 |             self.write_vectored(cx, &[IoSlice::new(buf)])
2020-03-31T14:38:41.1001813Z      |                  ^^^^^^^^^^^^^^ --  -------------------- supplied 2 arguments
2020-03-31T14:38:41.1004022Z      |                  expected 1 argument
2020-03-31T14:38:41.1004517Z 
2020-03-31T14:38:41.1004517Z 
2020-03-31T14:38:41.1236680Z error[E0599]: no method named `poll_write` found for struct `io::tests::TestWriter` in the current scope
2020-03-31T14:38:41.1238166Z     --> src/libstd/io/mod.rs:2914:27
2020-03-31T14:38:41.1239839Z 2882 |     struct TestWriter {
2020-03-31T14:38:41.1239839Z 2882 |     struct TestWriter {
2020-03-31T14:38:41.1241034Z      |     ----------------- method `poll_write` not found for this
2020-03-31T14:38:41.1241920Z ...
2020-03-31T14:38:41.1242863Z 2914 |         assert_eq!(writer.poll_write(&[]).unwrap(), 0);
2020-03-31T14:38:41.1244225Z      |                           ^^^^^^^^^^ method not found in `io::tests::TestWriter`
2020-03-31T14:38:41.1244960Z 
2020-03-31T14:38:41.1266735Z error[E0599]: no method named `poll_write_vectored` found for struct `io::tests::TestWriter` in the current scope
2020-03-31T14:38:41.1267938Z     --> src/libstd/io/mod.rs:2915:27
2020-03-31T14:38:41.1269539Z 2882 |     struct TestWriter {
2020-03-31T14:38:41.1269539Z 2882 |     struct TestWriter {
2020-03-31T14:38:41.1270745Z      |     ----------------- method `poll_write_vectored` not found for this
2020-03-31T14:38:41.1271663Z ...
2020-03-31T14:38:41.1272598Z 2915 |         assert_eq!(writer.poll_write_vectored(&[]).unwrap(), 0);
2020-03-31T14:38:41.1274014Z      |                           ^^^^^^^^^^^^^^^^^^^ method not found in `io::tests::TestWriter`
2020-03-31T14:38:41.1304776Z error[E0600]: cannot apply unary operator `!` to type `core::result::Result<usize, io::error::Error>`
2020-03-31T14:38:41.1306010Z     --> src/libstd/io/mod.rs:2924:9
2020-03-31T14:38:41.1306803Z      |
2020-03-31T14:38:41.1306803Z      |
2020-03-31T14:38:41.1307754Z 2924 |           assert!(writer.write_vectored(bufs), 1);
2020-03-31T14:38:41.1310002Z      |           |
2020-03-31T14:38:41.1311182Z      |           cannot apply unary operator `!`
2020-03-31T14:38:41.1313665Z      |           in this macro invocation
2020-03-31T14:38:41.1314294Z      | 
2020-03-31T14:38:41.1314294Z      | 
2020-03-31T14:38:41.1315005Z     ::: /checkout/src/libcore/macros/mod.rs:1297:5
2020-03-31T14:38:41.1315630Z      |
2020-03-31T14:38:41.1316397Z 1297 | /     macro_rules! assert {
2020-03-31T14:38:41.1317514Z 1298 | |         ($cond:expr) => {{ /* compiler built-in */ }};
2020-03-31T14:38:41.1318693Z 1299 | |         ($cond:expr,) => {{ /* compiler built-in */ }};
2020-03-31T14:38:41.1319867Z 1300 | |         ($cond:expr, $($arg:tt)+) => {{ /* compiler built-in */ }};
2020-03-31T14:38:41.1321560Z      | |_____- in this expansion of `assert!`
2020-03-31T14:38:41.1321883Z 
2020-03-31T14:38:41.1860021Z error[E0308]: mismatched types
2020-03-31T14:38:41.1860802Z     --> src/libstd/io/mod.rs:2950:14
2020-03-31T14:38:41.1860802Z     --> src/libstd/io/mod.rs:2950:14
2020-03-31T14:38:41.1861432Z      |
2020-03-31T14:38:41.1862246Z 2950 |             (&[IoSlice::new(&[1])], &[1]),
2020-03-31T14:38:41.1863469Z      |              ^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.1865151Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.1866075Z                 found reference `&[io::IoSlice<'_>; 1]`
2020-03-31T14:38:41.1866403Z 
2020-03-31T14:38:41.2298211Z error[E0308]: mismatched types
2020-03-31T14:38:41.2298211Z error[E0308]: mismatched types
2020-03-31T14:38:41.2299024Z     --> src/libstd/io/mod.rs:2950:37
2020-03-31T14:38:41.2299614Z      |
2020-03-31T14:38:41.2300396Z 2950 |             (&[IoSlice::new(&[1])], &[1]),
2020-03-31T14:38:41.2301683Z      |                                     ^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.2722640Z error[E0308]: mismatched types
2020-03-31T14:38:41.2723416Z     --> src/libstd/io/mod.rs:2951:14
2020-03-31T14:38:41.2724008Z      |
2020-03-31T14:38:41.2724008Z      |
2020-03-31T14:38:41.2724831Z 2951 |             (&[IoSlice::new(&[1, 2])], &[1, 2]),
2020-03-31T14:38:41.2726070Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.2727930Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.2728912Z                 found reference `&[io::IoSlice<'_>; 1]`
2020-03-31T14:38:41.2729261Z 
2020-03-31T14:38:41.3166403Z error[E0308]: mismatched types
2020-03-31T14:38:41.3166403Z error[E0308]: mismatched types
2020-03-31T14:38:41.3167179Z     --> src/libstd/io/mod.rs:2951:40
2020-03-31T14:38:41.3167765Z      |
2020-03-31T14:38:41.3168605Z 2951 |             (&[IoSlice::new(&[1, 2])], &[1, 2]),
2020-03-31T14:38:41.3169879Z      |                                        ^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.3602308Z error[E0308]: mismatched types
2020-03-31T14:38:41.3603078Z     --> src/libstd/io/mod.rs:2952:14
2020-03-31T14:38:41.3603725Z      |
2020-03-31T14:38:41.3603725Z      |
2020-03-31T14:38:41.3604543Z 2952 |             (&[IoSlice::new(&[1, 2, 3])], &[1, 2, 3]),
2020-03-31T14:38:41.3605795Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.3607479Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.3608394Z                 found reference `&[io::IoSlice<'_>; 1]`
2020-03-31T14:38:41.3608727Z 
2020-03-31T14:38:41.4040831Z error[E0308]: mismatched types
2020-03-31T14:38:41.4040831Z error[E0308]: mismatched types
2020-03-31T14:38:41.4041659Z     --> src/libstd/io/mod.rs:2952:43
2020-03-31T14:38:41.4042271Z      |
2020-03-31T14:38:41.4043089Z 2952 |             (&[IoSlice::new(&[1, 2, 3])], &[1, 2, 3]),
2020-03-31T14:38:41.4044405Z      |                                           ^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 3 elements
2020-03-31T14:38:41.4475350Z error[E0308]: mismatched types
2020-03-31T14:38:41.4476157Z     --> src/libstd/io/mod.rs:2953:14
2020-03-31T14:38:41.4476744Z      |
2020-03-31T14:38:41.4476744Z      |
2020-03-31T14:38:41.4477589Z 2953 |             (&[IoSlice::new(&[1, 2, 3, 4])], &[1, 2, 3, 4]),
2020-03-31T14:38:41.4478925Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.4480596Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.4481512Z                 found reference `&[io::IoSlice<'_>; 1]`
2020-03-31T14:38:41.4481837Z 
2020-03-31T14:38:41.4906395Z error[E0308]: mismatched types
2020-03-31T14:38:41.4906395Z error[E0308]: mismatched types
2020-03-31T14:38:41.4907219Z     --> src/libstd/io/mod.rs:2953:46
2020-03-31T14:38:41.4907803Z      |
2020-03-31T14:38:41.4908644Z 2953 |             (&[IoSlice::new(&[1, 2, 3, 4])], &[1, 2, 3, 4]),
2020-03-31T14:38:41.4910300Z      |                                              ^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 4 elements
2020-03-31T14:38:41.5321882Z error[E0308]: mismatched types
2020-03-31T14:38:41.5322688Z     --> src/libstd/io/mod.rs:2954:14
2020-03-31T14:38:41.5323276Z      |
2020-03-31T14:38:41.5323276Z      |
2020-03-31T14:38:41.5324134Z 2954 |             (&[IoSlice::new(&[1, 2, 3, 4, 5])], &[1, 2, 3, 4, 5]),
2020-03-31T14:38:41.5325468Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 1 element
2020-03-31T14:38:41.5327188Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.5328089Z                 found reference `&[io::IoSlice<'_>; 1]`
2020-03-31T14:38:41.5328411Z 
2020-03-31T14:38:41.5724456Z error[E0308]: mismatched types
2020-03-31T14:38:41.5724456Z error[E0308]: mismatched types
2020-03-31T14:38:41.5725215Z     --> src/libstd/io/mod.rs:2954:49
2020-03-31T14:38:41.5725804Z      |
2020-03-31T14:38:41.5726680Z 2954 |             (&[IoSlice::new(&[1, 2, 3, 4, 5])], &[1, 2, 3, 4, 5]),
2020-03-31T14:38:41.5728039Z      |                                                 ^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 5 elements
2020-03-31T14:38:41.6211479Z error[E0308]: mismatched types
2020-03-31T14:38:41.6212257Z     --> src/libstd/io/mod.rs:2955:14
2020-03-31T14:38:41.6212894Z      |
2020-03-31T14:38:41.6212894Z      |
2020-03-31T14:38:41.6214016Z 2955 |             (&[IoSlice::new(&[1]), IoSlice::new(&[2])], &[1, 2]),
2020-03-31T14:38:41.6215359Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.6217074Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.6217979Z                 found reference `&[io::IoSlice<'_>; 2]`
2020-03-31T14:38:41.6218305Z 
2020-03-31T14:38:41.6578252Z error[E0308]: mismatched types
2020-03-31T14:38:41.6578252Z error[E0308]: mismatched types
2020-03-31T14:38:41.6579018Z     --> src/libstd/io/mod.rs:2955:57
2020-03-31T14:38:41.6579639Z      |
2020-03-31T14:38:41.6580510Z 2955 |             (&[IoSlice::new(&[1]), IoSlice::new(&[2])], &[1, 2]),
2020-03-31T14:38:41.6581882Z      |                                                         ^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.6983932Z error[E0308]: mismatched types
2020-03-31T14:38:41.6984689Z     --> src/libstd/io/mod.rs:2956:14
2020-03-31T14:38:41.6985496Z      |
2020-03-31T14:38:41.6985496Z      |
2020-03-31T14:38:41.6986412Z 2956 |             (&[IoSlice::new(&[1, 1]), IoSlice::new(&[2, 2])], &[1, 1, 2, 2]),
2020-03-31T14:38:41.6987878Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.6989629Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.6990529Z                 found reference `&[io::IoSlice<'_>; 2]`
2020-03-31T14:38:41.6990875Z 
2020-03-31T14:38:41.7351375Z error[E0308]: mismatched types
2020-03-31T14:38:41.7351375Z error[E0308]: mismatched types
2020-03-31T14:38:41.7352133Z     --> src/libstd/io/mod.rs:2956:63
2020-03-31T14:38:41.7352762Z      |
2020-03-31T14:38:41.7353678Z 2956 |             (&[IoSlice::new(&[1, 1]), IoSlice::new(&[2, 2])], &[1, 1, 2, 2]),
2020-03-31T14:38:41.7355121Z      |                                                               ^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 4 elements
2020-03-31T14:38:41.7777722Z error[E0308]: mismatched types
2020-03-31T14:38:41.7779178Z     --> src/libstd/io/mod.rs:2957:14
2020-03-31T14:38:41.7780025Z      |
2020-03-31T14:38:41.7780025Z      |
2020-03-31T14:38:41.7781149Z 2957 |             (&[IoSlice::new(&[1, 1, 1]), IoSlice::new(&[2, 2, 2])], &[1, 1, 1, 2, 2, 2]),
2020-03-31T14:38:41.7782810Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.7785140Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.7786209Z                 found reference `&[io::IoSlice<'_>; 2]`
2020-03-31T14:38:41.7786697Z 
2020-03-31T14:38:41.8216086Z error[E0308]: mismatched types
2020-03-31T14:38:41.8216086Z error[E0308]: mismatched types
2020-03-31T14:38:41.8216695Z     --> src/libstd/io/mod.rs:2957:69
2020-03-31T14:38:41.8217182Z      |
2020-03-31T14:38:41.8217927Z 2957 |             (&[IoSlice::new(&[1, 1, 1]), IoSlice::new(&[2, 2, 2])], &[1, 1, 1, 2, 2, 2]),
2020-03-31T14:38:41.8219143Z      |                                                                     ^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 6 elements
2020-03-31T14:38:41.8630285Z error[E0308]: mismatched types
2020-03-31T14:38:41.8631083Z     --> src/libstd/io/mod.rs:2958:14
2020-03-31T14:38:41.8631679Z      |
2020-03-31T14:38:41.8631679Z      |
2020-03-31T14:38:41.8632690Z 2958 |             (&[IoSlice::new(&[1, 1, 1, 1]), IoSlice::new(&[2, 2, 2, 2])], &[1, 1, 1, 1, 2, 2, 2, 2]),
2020-03-31T14:38:41.8634167Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 2 elements
2020-03-31T14:38:41.8636205Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.8637128Z                 found reference `&[io::IoSlice<'_>; 2]`
2020-03-31T14:38:41.8637473Z 
2020-03-31T14:38:41.9045841Z error[E0308]: mismatched types
2020-03-31T14:38:41.9045841Z error[E0308]: mismatched types
2020-03-31T14:38:41.9046612Z     --> src/libstd/io/mod.rs:2958:75
2020-03-31T14:38:41.9047240Z      |
2020-03-31T14:38:41.9048229Z 2958 |             (&[IoSlice::new(&[1, 1, 1, 1]), IoSlice::new(&[2, 2, 2, 2])], &[1, 1, 1, 1, 2, 2, 2, 2]),
2020-03-31T14:38:41.9049804Z      |                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 8 elements
2020-03-31T14:38:41.9505793Z error[E0308]: mismatched types
2020-03-31T14:38:41.9506568Z     --> src/libstd/io/mod.rs:2959:14
2020-03-31T14:38:41.9507153Z      |
2020-03-31T14:38:41.9507153Z      |
2020-03-31T14:38:41.9508120Z 2959 |             (&[IoSlice::new(&[1]), IoSlice::new(&[2]), IoSlice::new(&[3])], &[1, 2, 3]),
2020-03-31T14:38:41.9509586Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 3 elements
2020-03-31T14:38:41.9511358Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:41.9512307Z                 found reference `&[io::IoSlice<'_>; 3]`
2020-03-31T14:38:41.9512654Z 
2020-03-31T14:38:41.9917330Z error[E0308]: mismatched types
2020-03-31T14:38:41.9917330Z error[E0308]: mismatched types
2020-03-31T14:38:41.9918111Z     --> src/libstd/io/mod.rs:2959:77
2020-03-31T14:38:41.9918738Z      |
2020-03-31T14:38:41.9919687Z 2959 |             (&[IoSlice::new(&[1]), IoSlice::new(&[2]), IoSlice::new(&[3])], &[1, 2, 3]),
2020-03-31T14:38:41.9921211Z      |                                                                             ^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 3 elements
2020-03-31T14:38:42.0350540Z error[E0308]: mismatched types
2020-03-31T14:38:42.0351345Z     --> src/libstd/io/mod.rs:2960:14
2020-03-31T14:38:42.0351965Z      |
2020-03-31T14:38:42.0351965Z      |
2020-03-31T14:38:42.0353001Z 2960 |             (&[IoSlice::new(&[1, 1]), IoSlice::new(&[2, 2]), IoSlice::new(&[3, 3])], &[1, 1, 2, 2, 3, 3]),
2020-03-31T14:38:42.0354528Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 3 elements
2020-03-31T14:38:42.0356308Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:42.0357396Z                 found reference `&[io::IoSlice<'_>; 3]`
2020-03-31T14:38:42.0357741Z 
2020-03-31T14:38:42.0747117Z error[E0308]: mismatched types
2020-03-31T14:38:42.0747117Z error[E0308]: mismatched types
2020-03-31T14:38:42.0748055Z     --> src/libstd/io/mod.rs:2960:86
2020-03-31T14:38:42.0748708Z      |
2020-03-31T14:38:42.0749719Z 2960 |             (&[IoSlice::new(&[1, 1]), IoSlice::new(&[2, 2]), IoSlice::new(&[3, 3])], &[1, 1, 2, 2, 3, 3]),
2020-03-31T14:38:42.0751334Z      |                                                                                      ^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 6 elements
2020-03-31T14:38:42.1211425Z error[E0308]: mismatched types
2020-03-31T14:38:42.1212268Z     --> src/libstd/io/mod.rs:2961:14
2020-03-31T14:38:42.1212866Z      |
2020-03-31T14:38:42.1212866Z      |
2020-03-31T14:38:42.1214376Z 2961 |             (&[IoSlice::new(&[1, 1, 1]), IoSlice::new(&[2, 2, 2]), IoSlice::new(&[3, 3, 3])], &[1, 1, 1, 2, 2, 2, 3, 3, 3]),
2020-03-31T14:38:42.1215982Z      |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 3 elements
2020-03-31T14:38:42.1217785Z      = note: expected reference `&[io::IoSlice<'_>; 0]`
2020-03-31T14:38:42.1218689Z                 found reference `&[io::IoSlice<'_>; 3]`
2020-03-31T14:38:42.1219039Z 
2020-03-31T14:38:42.1620054Z error[E0308]: mismatched types
2020-03-31T14:38:42.1620054Z error[E0308]: mismatched types
2020-03-31T14:38:42.1623323Z     --> src/libstd/io/mod.rs:2961:95
2020-03-31T14:38:42.1623962Z      |
2020-03-31T14:38:42.1625043Z 2961 |             (&[IoSlice::new(&[1, 1, 1]), IoSlice::new(&[2, 2, 2]), IoSlice::new(&[3, 3, 3])], &[1, 1, 1, 2, 2, 2, 3, 3, 3]),
2020-03-31T14:38:42.1626752Z      |                                                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 0 elements, found one with 9 elements
2020-03-31T14:38:42.1645785Z error[E0308]: mismatched types
2020-03-31T14:38:42.1646550Z     --> src/libstd/io/mod.rs:2968:53
2020-03-31T14:38:42.1647157Z      |
2020-03-31T14:38:42.1647157Z      |
2020-03-31T14:38:42.1647969Z 2968 |                 let mut writer = test_writer(n_bus, per_call);
2020-03-31T14:38:42.1649852Z      |                                                     |
2020-03-31T14:38:42.1649852Z      |                                                     |
2020-03-31T14:38:42.1650892Z      |                                                     expected `usize`, found `&{integer}`
2020-03-31T14:38:42.1652117Z      |                                                     help: consider dereferencing the borrow: `*per_call`
2020-03-31T14:38:42.1657965Z 
2020-03-31T14:38:42.1673630Z error[E0277]: can't compare `[u8]` with `&[{integer}; 0]`
2020-03-31T14:38:42.1674985Z      |
2020-03-31T14:38:42.1675648Z 66   | / macro_rules! assert_eq {
2020-03-31T14:38:42.1675648Z 66   | / macro_rules! assert_eq {
2020-03-31T14:38:42.1676551Z 67   | |     ($left:expr, $right:expr) => ({
2020-03-31T14:38:42.1677449Z 68   | |         match (&$left, &$right) {
2020-03-31T14:38:42.1678291Z 69   | |             (left_val, right_val) => {
2020-03-31T14:38:42.1679189Z 70   | |                 if !(*left_val == *right_val) {
2020-03-31T14:38:42.1680228Z      | |                                ^^ no implementation for `[u8] == &[{integer}; 0]`
2020-03-31T14:38:42.1681646Z 98   | |     });
2020-03-31T14:38:42.1682352Z 99   | | }
2020-03-31T14:38:42.1683125Z      | |_- in this expansion of `assert_eq!`
2020-03-31T14:38:42.1683768Z      | 
2020-03-31T14:38:42.1683768Z      | 
2020-03-31T14:38:42.1684282Z     ::: src/libstd/io/mod.rs:2970:17
2020-03-31T14:38:42.1684948Z      |
2020-03-31T14:38:42.1685616Z 2970 |                   assert_eq!(&*writer.written, &*wanted);
2020-03-31T14:38:42.1687238Z      |
2020-03-31T14:38:42.1687238Z      |
2020-03-31T14:38:42.1687971Z      = help: the trait `core::cmp::PartialEq<&[{integer}; 0]>` is not implemented for `[u8]`
2020-03-31T14:38:42.1689018Z      = note: required because of the requirements on the impl of `core::cmp::PartialEq<&&[{integer}; 0]>` for `&[u8]`
2020-03-31T14:38:48.5139529Z error: aborting due to 32 previous errors
2020-03-31T14:38:48.5140423Z 
2020-03-31T14:38:48.5141416Z Some errors have detailed explanations: E0061, E0277, E0308, E0425, E0599, E0600.
2020-03-31T14:38:48.5142444Z For more information about an error, try `rustc --explain E0061`.
---
2020-03-31T14:38:48.5428645Z   local time: Tue Mar 31 14:38:48 UTC 2020
2020-03-31T14:38:48.6496575Z   network time: Tue, 31 Mar 2020 14:38:48 GMT
2020-03-31T14:38:48.6501189Z == end clock drift check ==
2020-03-31T14:38:49.1265617Z 
2020-03-31T14:38:49.1328879Z ##[error]Bash exited with code '1'.
2020-03-31T14:38:49.1342739Z ##[section]Finishing: Run build
2020-03-31T14:38:49.1394794Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T14:38:49.1399876Z Task         : Get sources
2020-03-31T14:38:49.1400193Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-31T14:38:49.1400507Z Version      : 1.0.0
2020-03-31T14:38:49.1400718Z Author       : Microsoft
2020-03-31T14:38:49.1400718Z Author       : Microsoft
2020-03-31T14:38:49.1401059Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-31T14:38:49.1401453Z ==============================================================================
2020-03-31T14:38:49.4583700Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-31T14:38:49.4638530Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T14:38:49.4720334Z Cleaning up task key
2020-03-31T14:38:49.4721253Z Start cleaning up orphan processes.
2020-03-31T14:38:49.4888595Z Terminate orphan process: pid (3582) (python)
2020-03-31T14:38:49.5082228Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Similar to io::Write::write_all but uses io::Write::write_vectored instead.

src/libstd/io/mod.rs

rust-highfive · 2020-03-31T20:25:34Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-31T18:44:50.9034189Z ========================== Starting Command Output ===========================
2020-03-31T18:44:50.9037749Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/e7cc0360-b5f5-4278-bc75-fa91e44ca3c4.sh
2020-03-31T18:44:50.9038029Z 
2020-03-31T18:44:50.9042367Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-31T18:44:50.9060639Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T18:44:50.9063882Z Task         : Get sources
2020-03-31T18:44:50.9064196Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-31T18:44:50.9064504Z Version      : 1.0.0
2020-03-31T18:44:50.9064708Z Author       : Microsoft
---
2020-03-31T18:44:52.0957197Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-31T18:44:52.0967417Z ##[command]git config gc.auto 0
2020-03-31T18:44:52.0973914Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-31T18:44:52.0979830Z ##[command]git config --get-all http.proxy
2020-03-31T18:44:52.0986996Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70612/merge:refs/remotes/pull/70612/merge
---
2020-03-31T18:52:41.0938021Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-31T18:52:42.4488377Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-31T18:52:43.9693418Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-31T18:52:44.0037596Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-31T18:52:53.2647093Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T18:52:54.7855183Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-31T18:52:58.9040778Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-31T18:53:02.8485791Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-31T18:53:11.8381032Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-31T19:14:19.2820709Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-31T19:14:20.9652775Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-31T19:14:22.9447865Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-31T19:14:23.8106408Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-31T19:14:34.5098472Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T19:14:36.8275534Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-31T19:14:41.9694689Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-31T19:14:47.1581862Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-31T19:14:58.2813524Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-31T19:39:18.6652731Z .................................................................................................... 1700/9861
2020-03-31T19:39:22.5209152Z .................................................................................................... 1800/9861
2020-03-31T19:39:30.9527904Z ..............................................................................................i..... 1900/9861
2020-03-31T19:39:38.3719369Z .................................................................................................... 2000/9861
2020-03-31T19:39:44.4224749Z ....................................................................................iiiii........... 2100/9861
2020-03-31T19:40:04.4455604Z .................................................................................................... 2300/9861
2020-03-31T19:40:06.5865709Z .................................................................................................... 2400/9861
2020-03-31T19:40:08.7754914Z .................................................................................................... 2500/9861
2020-03-31T19:40:14.5648778Z .................................................................................................... 2600/9861
---
2020-03-31T19:42:59.5363868Z ..........................................................i...............i......................... 5000/9861
2020-03-31T19:43:06.9065825Z .................................................................................................... 5100/9861
2020-03-31T19:43:14.2260710Z .................................................................................................... 5200/9861
2020-03-31T19:43:19.0889695Z ...i................................................................................................ 5300/9861
2020-03-31T19:43:29.0167586Z .........................................................................................ii.ii...... 5400/9861
2020-03-31T19:43:33.0023863Z ..i...i............................................................................................. 5500/9861
2020-03-31T19:43:41.4217193Z ..................................i................................................................. 5700/9861
2020-03-31T19:43:50.8793315Z ....................................................ii....................................i......... 5800/9861
2020-03-31T19:43:58.0823251Z .................................................................................................... 5900/9861
2020-03-31T19:44:02.7281398Z .................................................................................................... 6000/9861
2020-03-31T19:44:02.7281398Z .................................................................................................... 6000/9861
2020-03-31T19:44:11.6747297Z ....................................................................................ii...i..ii...... 6100/9861
2020-03-31T19:44:31.8444679Z .................................................................................................... 6300/9861
2020-03-31T19:44:35.7853957Z .................................................................................................... 6400/9861
2020-03-31T19:44:38.7608730Z .................................................................................................... 6500/9861
2020-03-31T19:44:38.7608730Z .................................................................................................... 6500/9861
2020-03-31T19:44:50.7811266Z ..............i..ii................................................................................. 6600/9861
2020-03-31T19:45:10.5172864Z .................................................................................................... 6800/9861
2020-03-31T19:45:12.5623998Z ..............i..................................................................................... 6900/9861
2020-03-31T19:45:14.6231687Z .................................................................................................... 7000/9861
2020-03-31T19:45:16.8002420Z ....................................................i............................................... 7100/9861
---
2020-03-31T19:46:51.9594265Z .................................................................................................... 7800/9861
2020-03-31T19:46:56.8684832Z .................................................................................................... 7900/9861
2020-03-31T19:47:01.9672493Z .................................................................................................... 8000/9861
2020-03-31T19:47:10.0463337Z ............i....................................................................................... 8100/9861
2020-03-31T19:47:18.0049422Z .............................................................iiiiiiiiii.i........................... 8200/9861
2020-03-31T19:47:32.0045935Z .....i......i....................................................................................... 8400/9861
2020-03-31T19:47:36.6809714Z .................................................................................................... 8500/9861
2020-03-31T19:47:47.8185949Z .................................................................................................... 8600/9861
2020-03-31T19:47:57.9769714Z .................................................................................................... 8700/9861
---
2020-03-31T19:50:13.2966738Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-03-31T19:50:13.3157054Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T19:50:13.5051209Z 
2020-03-31T19:50:13.5051525Z running 183 tests
2020-03-31T19:50:16.1344879Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/183
2020-03-31T19:50:18.6227951Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-03-31T19:50:18.6231723Z 
2020-03-31T19:50:18.6232321Z  finished in 5.306
2020-03-31T19:50:18.6237919Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-03-31T19:50:18.6425185Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T19:50:20.6449304Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-03-31T19:50:20.6645611Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T19:50:20.8217960Z 
2020-03-31T19:50:20.8219410Z running 9 tests
2020-03-31T19:50:20.8220519Z iiiiiiiii
2020-03-31T19:50:20.8221485Z 
2020-03-31T19:50:20.8221699Z  finished in 0.157
2020-03-31T19:50:20.8225525Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-03-31T19:50:20.8418944Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T19:50:40.1629274Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-03-31T19:50:40.1848120Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T19:50:40.3634260Z 
2020-03-31T19:50:40.3634564Z running 115 tests
2020-03-31T19:50:53.2222224Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-03-31T19:50:54.8383491Z ...iiii.....ii.
2020-03-31T19:50:54.8384751Z 
2020-03-31T19:50:54.8387466Z  finished in 14.653
2020-03-31T19:50:54.8394309Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-03-31T19:50:54.8398354Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-03-31T20:02:39.8318828Z 
2020-03-31T20:02:39.8320560Z    Doc-tests core
2020-03-31T20:02:44.1407052Z 
2020-03-31T20:02:44.1407933Z running 2489 tests
2020-03-31T20:02:52.8537216Z ......iiiii......................................................................................... 100/2489
2020-03-31T20:03:01.3110488Z .....................................................................................ii............. 200/2489
2020-03-31T20:03:21.1272241Z ....................i............................................................................... 400/2489
2020-03-31T20:03:21.1272241Z ....................i............................................................................... 400/2489
2020-03-31T20:03:30.4741219Z ..........................................................................i..i..................iiii 500/2489
2020-03-31T20:03:45.8550761Z .................................................................................................... 700/2489
2020-03-31T20:03:53.7841864Z .................................................................................................... 800/2489
2020-03-31T20:04:01.8290634Z .................................................................................................... 900/2489
2020-03-31T20:04:09.9658598Z .................................................................................................... 1000/2489
---
2020-03-31T20:07:21.0411657Z .................................................................................................... 500/763
2020-03-31T20:07:21.0777635Z .....................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-03-31T20:07:21.0789358Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:21
2020-03-31T20:07:21.0794388Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-03-31T20:07:21.0812341Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-03-31T20:07:21.5500417Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997:22
2020-03-31T20:07:21.5513126Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2022:17
2020-03-31T20:07:21.5524831Z ...thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError.', src/libstd/sync/mpsc/mod.rs:2034:21
2020-03-31T20:07:21.5547347Z ...thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-03-31T20:07:23.6154947Z .........................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-03-31T20:07:23.6155761Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-03-31T20:07:23.6156571Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-03-31T20:07:23.6162152Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
---
2020-03-31T20:07:32.5563958Z 
2020-03-31T20:07:32.5564372Z running 1019 tests
2020-03-31T20:07:49.1326058Z i................................................................................................... 100/1019
2020-03-31T20:07:58.7400817Z .................................................................................................... 200/1019
2020-03-31T20:08:05.8328066Z ..................iii......i......i...i......i...................................................... 300/1019
2020-03-31T20:08:17.0204744Z ...................................................i....i......................................ii... 500/1019
2020-03-31T20:08:24.4524955Z .................................................................................................... 600/1019
2020-03-31T20:08:29.2137264Z .................................................................................................... 700/1019
2020-03-31T20:08:29.2137264Z .................................................................................................... 700/1019
2020-03-31T20:08:36.0206605Z .............................................iiii................................................... 800/1019
2020-03-31T20:08:49.3059298Z .................................................................................................... 900/1019
2020-03-31T20:08:55.3200527Z ...................................................................iiii............................. 1000/1019
2020-03-31T20:08:56.5519717Z test result: ok. 999 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-03-31T20:08:56.5520975Z 
2020-03-31T20:08:56.5619935Z  finished in 158.165
2020-03-31T20:08:56.5622324Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-03-31T20:11:54.7732057Z 
2020-03-31T20:11:54.7732510Z test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2020-03-31T20:11:54.7732918Z 
2020-03-31T20:11:54.7790726Z  finished in 0.898
2020-03-31T20:11:54.7791847Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
2020-03-31T20:11:54.7807253Z Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-03-31T20:11:54.9583976Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-31T20:11:55.8865221Z      Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-8f684ad7079c0468
2020-03-31T20:11:55.8901421Z 
2020-03-31T20:11:55.8902028Z running 0 tests
2020-03-31T20:11:55.8902400Z 
---
2020-03-31T20:25:18.7836763Z     Checking backtrace v0.3.46
2020-03-31T20:25:20.7274688Z     Checking rustc-std-workspace-alloc v1.99.0 (/checkout/src/tools/rustc-std-workspace-alloc)
2020-03-31T20:25:20.7276791Z     Checking panic_unwind v0.0.0 (/checkout/src/libpanic_unwind)
2020-03-31T20:25:21.4678962Z  Documenting std v0.0.0 (/checkout/src/libstd)
2020-03-31T20:25:25.8142943Z error: `[write_vectored]` cannot be resolved, ignoring it.
2020-03-31T20:25:25.8146934Z     --> src/libstd/io/mod.rs:1382:45
2020-03-31T20:25:25.8162049Z      |
2020-03-31T20:25:25.8163837Z 1382 |     /// This method will continuously call [`write_vectored`] until there is no
2020-03-31T20:25:25.8167644Z      |
2020-03-31T20:25:25.8168954Z note: the lint level is defined here
2020-03-31T20:25:25.8170381Z     --> src/libstd/lib.rs:213:9
2020-03-31T20:25:25.8171591Z      |
2020-03-31T20:25:25.8171591Z      |
2020-03-31T20:25:25.8173267Z 213  | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
2020-03-31T20:25:25.8176921Z      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2020-03-31T20:25:25.8177893Z 
2020-03-31T20:25:25.8177893Z 
2020-03-31T20:25:25.8179268Z error: `[write_vectored]` cannot be resolved, ignoring it.
2020-03-31T20:25:25.8180779Z     --> src/libstd/io/mod.rs:1389:63
2020-03-31T20:25:25.8182002Z      |
2020-03-31T20:25:25.8183517Z 1389 |     /// If the buffer contains no data, this will never call [`write_vectored`].
2020-03-31T20:25:25.8186698Z      |
2020-03-31T20:25:25.8188621Z      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
2020-03-31T20:25:25.8190032Z 
2020-03-31T20:25:26.1237854Z error: aborting due to 2 previous errors
2020-03-31T20:25:26.1237854Z error: aborting due to 2 previous errors
2020-03-31T20:25:26.1238412Z 
2020-03-31T20:25:26.1471891Z error: Could not document `std`.
2020-03-31T20:25:26.1472165Z 
2020-03-31T20:25:26.1472338Z Caused by:
2020-03-31T20:25:26.1479592Z   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --edition=2018 --crate-type dylib --crate-type rlib --crate-name std src/libstd/lib.rs --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="compiler-builtins-c"' --cfg 'feature="default"' --cfg 'feature="panic_unwind"' --cfg 'feature="std_detect_dlsym_getauxval"' --cfg 'feature="std_detect_file_io"' --error-format=json --json=diagnostic-rendered-ansi --markdown-css rust.css --markdown-no-toc --generate-redirect-pages -Z unstable-options --resource-suffix 1.44.0 --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/liballoc-c4955f7c11866375.rmeta --extern backtrace_rs=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace-fe732e07cc6b018b.rmeta --extern cfg_if=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcfg_if-b0a312d64aa824d2.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-66b1433fa626bbbd.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libcore-f3b6809857109b0f.rmeta --extern hashbrown=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libhashbrown-144a4d778798e366.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/liblibc-53781145e5aa08ab.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-d145b2001095eff1.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-77e11d514de0b2c0.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-linux-gnu/release/deps/libunwind-f83cf9ea6ff98591.rmeta` (exit code: 1)
2020-03-31T20:25:26.1501017Z 
2020-03-31T20:25:26.1501017Z 
2020-03-31T20:25:26.1503068Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "-Z" "unstable-options" "--resource-suffix" "1.44.0" "--index-page" "/checkout/src/doc/index.md"
2020-03-31T20:25:26.1504355Z 
2020-03-31T20:25:26.1504461Z 
2020-03-31T20:25:26.1507953Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-03-31T20:25:26.1509217Z Build completed unsuccessfully in 1:36:04
2020-03-31T20:25:26.1509217Z Build completed unsuccessfully in 1:36:04
2020-03-31T20:25:26.1562262Z == clock drift check ==
2020-03-31T20:25:26.1580474Z   local time: Tue Mar 31 20:25:26 UTC 2020
2020-03-31T20:25:26.2265488Z   network time: Tue, 31 Mar 2020 20:25:26 GMT
2020-03-31T20:25:26.2266082Z == end clock drift check ==
2020-03-31T20:25:29.3001702Z 
2020-03-31T20:25:29.3079109Z ##[error]Bash exited with code '1'.
2020-03-31T20:25:29.3095038Z ##[section]Finishing: Run build
2020-03-31T20:25:29.3141799Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T20:25:29.3146446Z Task         : Get sources
2020-03-31T20:25:29.3146775Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-31T20:25:29.3147203Z Version      : 1.0.0
2020-03-31T20:25:29.3147428Z Author       : Microsoft
2020-03-31T20:25:29.3147428Z Author       : Microsoft
2020-03-31T20:25:29.3147934Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-31T20:25:29.3148615Z ==============================================================================
2020-03-31T20:25:29.6429694Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-31T20:25:29.6474319Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-03-31T20:25:29.6559927Z Cleaning up task key
2020-03-31T20:25:29.6561226Z Start cleaning up orphan processes.
2020-03-31T20:25:29.6735315Z Terminate orphan process: pid (3481) (python)
2020-03-31T20:25:29.6972941Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-04-01T15:54:17Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-01T14:13:23.0354496Z ========================== Starting Command Output ===========================
2020-04-01T14:13:23.0358402Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/7b0ea816-9246-4d91-942f-64e5628f53d9.sh
2020-04-01T14:13:23.0359411Z 
2020-04-01T14:13:23.0363333Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-01T14:13:23.0382679Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-04-01T14:13:23.0385917Z Task         : Get sources
2020-04-01T14:13:23.0386225Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T14:13:23.0386538Z Version      : 1.0.0
2020-04-01T14:13:23.0386740Z Author       : Microsoft
---
2020-04-01T14:13:24.0415340Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-01T14:13:24.0420341Z ##[command]git config gc.auto 0
2020-04-01T14:13:24.0423597Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-01T14:13:24.0426616Z ##[command]git config --get-all http.proxy
2020-04-01T14:13:24.0431972Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70612/merge:refs/remotes/pull/70612/merge
---
2020-04-01T14:15:26.7691161Z Looks like docker image is the same as before, not uploading
2020-04-01T14:15:34.4102042Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T14:15:34.4385815Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T14:15:34.4435788Z == clock drift check ==
2020-04-01T14:15:34.4441889Z   local time: Wed Apr  1 14:15:34 UTC 2020
2020-04-01T14:15:34.6073777Z   network time: Wed, 01 Apr 2020 14:15:34 GMT
2020-04-01T14:15:34.6100513Z Starting sccache server...
2020-04-01T14:15:34.6898326Z configure: processing command line
2020-04-01T14:15:34.6898635Z configure: 
2020-04-01T14:15:34.6899642Z configure: rust.dist-src        := False
---
2020-04-01T14:20:32.6979063Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T14:20:34.1951612Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T14:20:35.8324031Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T14:20:37.2301856Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T14:20:45.9323724Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T14:20:48.7863638Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T14:20:53.4430434Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T14:20:57.8835244Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T14:21:06.4847898Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T14:42:02.0730523Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T14:42:03.8222288Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T14:42:05.7114431Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T14:42:06.4864081Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T14:42:17.2796822Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T14:42:19.3463913Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T14:42:24.5065618Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T14:42:29.7769888Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T14:42:41.1158777Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T15:06:51.1378811Z .................................................................................................... 1700/9865
2020-04-01T15:06:54.9084798Z .................................................................................................... 1800/9865
2020-04-01T15:07:03.2453295Z ...............................................................................................i.... 1900/9865
2020-04-01T15:07:10.6629047Z .................................................................................................... 2000/9865
2020-04-01T15:07:16.7720178Z .....................................................................................iiiii.......... 2100/9865
2020-04-01T15:07:36.3727494Z .................................................................................................... 2300/9865
2020-04-01T15:07:38.5675461Z .................................................................................................... 2400/9865
2020-04-01T15:07:40.8557143Z .................................................................................................... 2500/9865
2020-04-01T15:07:46.8582076Z .................................................................................................... 2600/9865
---
2020-04-01T15:10:34.5534085Z ...........................................................i...............i........................ 5000/9865
2020-04-01T15:10:41.4702014Z .................................................................................................... 5100/9865
2020-04-01T15:10:48.5396595Z .................................................................................................... 5200/9865
2020-04-01T15:10:53.0912462Z ....i............................................................................................... 5300/9865
2020-04-01T15:11:03.0164057Z ..........................................................................................ii.ii..... 5400/9865
2020-04-01T15:11:06.8906203Z ...i...i............................................................................................ 5500/9865
2020-04-01T15:11:15.1815745Z ...................................i................................................................ 5700/9865
2020-04-01T15:11:24.9235264Z .......................................................ii....................................i...... 5800/9865
2020-04-01T15:11:32.2226904Z .................................................................................................... 5900/9865
2020-04-01T15:11:36.9578049Z .................................................................................................... 6000/9865
2020-04-01T15:11:36.9578049Z .................................................................................................... 6000/9865
2020-04-01T15:11:45.8184480Z .......................................................................................ii...i..ii... 6100/9865
2020-04-01T15:12:05.4756255Z .................................................................................................... 6300/9865
2020-04-01T15:12:10.4227545Z .................................................................................................... 6400/9865
2020-04-01T15:12:13.1039342Z .................................................................................................... 6500/9865
2020-04-01T15:12:13.1039342Z .................................................................................................... 6500/9865
2020-04-01T15:12:24.6545211Z .................i..ii.............................................................................. 6600/9865
2020-04-01T15:12:43.9185476Z .................................................................................................... 6800/9865
2020-04-01T15:12:45.8271650Z .................i.................................................................................. 6900/9865
2020-04-01T15:12:47.8302987Z .................................................................................................... 7000/9865
2020-04-01T15:12:49.8084261Z ........................................................i........................................... 7100/9865
---
2020-04-01T15:14:26.6817186Z .................................................................................................... 7800/9865
2020-04-01T15:14:32.0523732Z .................................................................................................... 7900/9865
2020-04-01T15:14:37.4278749Z .................................................................................................... 8000/9865
2020-04-01T15:14:45.6233574Z ................i................................................................................... 8100/9865
2020-04-01T15:14:54.0296311Z .................................................................iiiiiiiiii.i....................... 8200/9865
2020-04-01T15:15:09.1028717Z .........i......i................................................................................... 8400/9865
2020-04-01T15:15:13.9171142Z .................................................................................................... 8500/9865
2020-04-01T15:15:25.2533768Z .................................................................................................... 8600/9865
2020-04-01T15:15:36.6175424Z .................................................................................................... 8700/9865
---
2020-04-01T15:17:54.3311687Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-04-01T15:17:54.3500803Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-01T15:17:54.5440361Z 
2020-04-01T15:17:54.5440747Z running 183 tests
2020-04-01T15:17:57.1820066Z iiii......i............ii.i..iiii....i....i...........i............i..i..................i....i..... 100/183
2020-04-01T15:17:59.7074861Z .......i.i.i...iii..iiiiiiiiiiiiiiii.......................iii.............ii......
2020-04-01T15:17:59.7081444Z 
2020-04-01T15:17:59.7085927Z  finished in 5.358
2020-04-01T15:17:59.7087166Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-01T15:17:59.7279553Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-01T15:18:01.7443647Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-01T15:18:01.7640146Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-01T15:18:01.9201513Z 
2020-04-01T15:18:01.9203120Z running 9 tests
2020-04-01T15:18:01.9204210Z iiiiiiiii
2020-04-01T15:18:01.9214744Z 
2020-04-01T15:18:01.9214943Z  finished in 0.157
2020-04-01T15:18:01.9215607Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-01T15:18:01.9409851Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-01T15:18:21.1172408Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-01T15:18:21.7352958Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-01T15:18:21.9096102Z 
2020-04-01T15:18:21.9096815Z running 115 tests
2020-04-01T15:18:34.6846665Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-01T15:18:36.3510843Z ...iiii.....ii.
2020-04-01T15:18:36.3513397Z 
2020-04-01T15:18:36.3513617Z  finished in 14.616
2020-04-01T15:18:36.3521691Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-01T15:18:36.3524598Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-01T15:30:12.0543534Z 
2020-04-01T15:30:12.0547518Z    Doc-tests core
2020-04-01T15:30:16.5892892Z 
2020-04-01T15:30:16.5893770Z running 2489 tests
2020-04-01T15:30:25.5004304Z ......iiiii......................................................................................... 100/2489
2020-04-01T15:30:34.2192618Z .....................................................................................ii............. 200/2489
2020-04-01T15:30:55.2829054Z ....................i............................................................................... 400/2489
2020-04-01T15:30:55.2829054Z ....................i............................................................................... 400/2489
2020-04-01T15:31:05.2607907Z ..........................................................................i..i..................iiii 500/2489
2020-04-01T15:31:21.9105352Z .................................................................................................... 700/2489
2020-04-01T15:31:30.6403857Z .................................................................................................... 800/2489
2020-04-01T15:31:39.1530633Z .................................................................................................... 900/2489
2020-04-01T15:31:47.7575552Z .................................................................................................... 1000/2489
---
2020-04-01T15:35:16.4846622Z 
2020-04-01T15:35:16.4847028Z running 1019 tests
2020-04-01T15:35:32.7960480Z i................................................................................................... 100/1019
2020-04-01T15:35:42.3335266Z .................................................................................................... 200/1019
2020-04-01T15:35:49.3221927Z ..................iii......i......i...i......i...................................................... 300/1019
2020-04-01T15:35:59.9907043Z ...................................................i....i......................................ii... 500/1019
2020-04-01T15:36:07.1946211Z .................................................................................................... 600/1019
2020-04-01T15:36:11.7896367Z .................................................................................................... 700/1019
2020-04-01T15:36:11.7896367Z .................................................................................................... 700/1019
2020-04-01T15:36:18.2485459Z .............................................iiii................................................... 800/1019
2020-04-01T15:36:30.9439482Z .................................................................................................... 900/1019
2020-04-01T15:36:36.4986213Z ...................................................................iiii............................. 1000/1019
2020-04-01T15:36:37.6539489Z test result: ok. 999 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-04-01T15:36:37.6539846Z 
2020-04-01T15:36:37.6634143Z  finished in 153.498
2020-04-01T15:36:37.6637692Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-04-01T15:39:37.6453629Z 
2020-04-01T15:39:37.6454392Z test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2020-04-01T15:39:37.6454847Z 
2020-04-01T15:39:37.6517247Z  finished in 0.928
2020-04-01T15:39:37.6518842Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
2020-04-01T15:39:37.6538955Z Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-01T15:39:37.8268500Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T15:39:38.7496786Z      Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-faa671b93ce4585f
2020-04-01T15:39:38.7528857Z 
2020-04-01T15:39:38.7529491Z running 0 tests
2020-04-01T15:39:38.7529882Z 
---
2020-04-01T15:53:35.2238061Z Set({"/checkout/src/librustc_parse"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2238833Z Set({"/checkout/src/librustc_passes"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2239636Z Set({"/checkout/src/librustc_plugin_impl"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2240659Z Set({"/checkout/src/librustc_privacy"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2241447Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2243033Z Set({"/checkout/src/librustc_save_analysis"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2244025Z Set({"/checkout/src/librustc_session"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2244790Z Set({"/checkout/src/librustc_span"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
2020-04-01T15:53:35.2246233Z Set({"/checkout/src/librustc_symbol_mangling"}) not skipped for "bootstrap::doc::Rustc" -- not in ["src/tools/tidy"]
---
2020-04-01T15:53:47.9272772Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2020-04-01T15:53:48.3413731Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2020-04-01T15:53:48.5097957Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2020-04-01T15:53:49.9696167Z     Finished release [optimized] target(s) in 1.62s
2020-04-01T15:53:52.3168493Z std/io/trait.Write.html:128: broken link fragment `#tymethod.write_vectored` pointing to `std/io/trait.Write.html`
2020-04-01T15:53:52.3169565Z std/io/trait.Write.html:134: broken link fragment `#tymethod.write_vectored` pointing to `std/io/trait.Write.html`
2020-04-01T15:53:57.0435298Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:43:9
2020-04-01T15:53:57.0464823Z 
2020-04-01T15:53:57.0465221Z 
2020-04-01T15:53:57.0466393Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2020-04-01T15:53:57.0467061Z expected success, got: exit code: 101
2020-04-01T15:53:57.0467061Z expected success, got: exit code: 101
2020-04-01T15:53:57.0467377Z 
2020-04-01T15:53:57.0467582Z 
2020-04-01T15:53:57.0477704Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-01T15:53:57.0478368Z Build completed unsuccessfully in 1:36:53
2020-04-01T15:53:57.0534568Z == clock drift check ==
2020-04-01T15:53:57.9330454Z   local time: Wed Apr  1 15:53:57 UTC 2020
2020-04-01T15:53:57.9330866Z   network time: Wed, 01 Apr 2020 15:53:57 GMT
2020-04-01T15:53:58.8041844Z 
2020-04-01T15:53:58.8041844Z 
2020-04-01T15:53:58.8107832Z ##[error]Bash exited with code '1'.
2020-04-01T15:53:58.8121361Z ##[section]Finishing: Run build
2020-04-01T15:53:58.8169079Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-04-01T15:53:58.8174076Z Task         : Get sources
2020-04-01T15:53:58.8174425Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T15:53:58.8174751Z Version      : 1.0.0
2020-04-01T15:53:58.8174993Z Author       : Microsoft
2020-04-01T15:53:58.8174993Z Author       : Microsoft
2020-04-01T15:53:58.8175352Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-01T15:53:58.8175758Z ==============================================================================
2020-04-01T15:53:59.1583001Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-01T15:53:59.1625651Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70612/merge to s
2020-04-01T15:53:59.1709210Z Cleaning up task key
2020-04-01T15:53:59.1710491Z Start cleaning up orphan processes.
2020-04-01T15:53:59.1887398Z Terminate orphan process: pid (3588) (python)
2020-04-01T15:53:59.2141073Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

LukasKalbertodt

A few inline comments, mostly documentation though.

Regarding the discussion in #70436: I am also not very happy about an API like this. Especially since we recommend in the docs to "treat it as if bufs was consumed by this method". Feels wrong to me, as in Rust, we should be able to assert this on a type level somehow. But maybe it's not that bad, as this is mainly a fairly low level API anyway. And unfortunately, I don't have a great idea how to use the type system to make this better.

I personally don't like the idea of making this method implementation more complicated or slower to get around this API quirk. So I'm not quite sure what to do about this...

src/libstd/io/mod.rs

Also adds some more tests with different length IoSlices.

Thomasdezeeuw · 2020-04-06T10:45:15Z

@LukasKalbertodt I've address all comments, except for the tracking issue one.

LukasKalbertodt

One tiny thing still!

src/libstd/io/mod.rs

LukasKalbertodt · 2020-04-06T22:13:56Z

Thanks!

As I said, I don't particularly like the API. But let's get it landed, it's unstable after all. We can still change and discuss the exact API later.

@bors r+

bors · 2020-04-06T22:13:57Z

📌 Commit 5d09f9f has been approved by LukasKalbertodt

@cramertj

…albertodt Add io::Write::write_all_vectored Similar to io::Write::write_all but uses io::Write::write_vectored instead. Updates rust-lang#70436 /cc @cramertj @sfackler

@cramertj

…albertodt Add io::Write::write_all_vectored Similar to io::Write::write_all but uses io::Write::write_vectored instead. Updates rust-lang#70436 /cc @cramertj @sfackler

@cramertj

…albertodt Add io::Write::write_all_vectored Similar to io::Write::write_all but uses io::Write::write_vectored instead. Updates rust-lang#70436 /cc @cramertj @sfackler

@ghost

Rollup of 5 pull requests Successful merges: - rust-lang#70612 (Add io::Write::write_all_vectored) - rust-lang#70690 (Clean up E0501 explanation) - rust-lang#70821 (expose suggestions::InferCtxtExt for clippy) - rust-lang#70839 (clean up E0506 explanation) - rust-lang#70859 (Move sanitize-inline-always test to sanitize directory) Failed merges: r? @ghost

joshtriplett · 2020-04-14T23:47:13Z

I'm very happy to see this method added, thank you!

rust-highfive assigned LukasKalbertodt Mar 31, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020

Add io::Write::write_all_vectored

33a4999

Similar to io::Write::write_all but uses io::Write::write_vectored instead.

sfackler reviewed Mar 31, 2020

View reviewed changes

src/libstd/io/mod.rs Outdated Show resolved Hide resolved

Use unspecified over undefined in io::Write::write_all_vectored docs

9745b1f

Fix link to write_vectored

ba91e7e

LukasKalbertodt suggested changes Apr 5, 2020

View reviewed changes

Improve io::Write::write_all_vectored docs

63118d1

Also adds some more tests with different length IoSlices.

LukasKalbertodt suggested changes Apr 6, 2020

View reviewed changes

src/libstd/io/mod.rs Outdated Show resolved Hide resolved

Put reference to write_vectored in quotes in doc

5d09f9f

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020

Dylan-DPC-zz mentioned this pull request Apr 6, 2020

Rollup of 4 pull requests #70862

Closed

Dylan-DPC-zz mentioned this pull request Apr 6, 2020

Rollup of 4 pull requests #70863

Closed

This was referenced Apr 6, 2020

Rollup of 4 pull requests #70864

Closed

Rollup of 5 pull requests #70865

Merged

bors merged commit 5768385 into rust-lang:master Apr 7, 2020

Thomasdezeeuw deleted the issue_70436 branch April 7, 2020 08:29

Thomasdezeeuw mentioned this pull request Apr 7, 2020

Tracking issue for Write::write_all_vectored #70436

Open

3 tasks

mxinden mentioned this pull request May 27, 2020

src/encoder/text: Optimize metric formatting tikv/rust-prometheus#327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add io::Write::write_all_vectored #70612

Add io::Write::write_all_vectored #70612

Thomasdezeeuw commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

Thomasdezeeuw commented Mar 31, 2020

Centril commented Mar 31, 2020

Thomasdezeeuw commented Mar 31, 2020

Centril commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

rust-highfive commented Apr 1, 2020

LukasKalbertodt left a comment

Thomasdezeeuw commented Apr 6, 2020

LukasKalbertodt left a comment

LukasKalbertodt commented Apr 6, 2020

bors commented Apr 6, 2020

joshtriplett commented Apr 14, 2020

Add io::Write::write_all_vectored #70612

Add io::Write::write_all_vectored #70612

Conversation

Thomasdezeeuw commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

Thomasdezeeuw commented Mar 31, 2020

Centril commented Mar 31, 2020

Thomasdezeeuw commented Mar 31, 2020

Centril commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

rust-highfive commented Mar 31, 2020

rust-highfive commented Apr 1, 2020

LukasKalbertodt left a comment

Choose a reason for hiding this comment

Thomasdezeeuw commented Apr 6, 2020

LukasKalbertodt left a comment

Choose a reason for hiding this comment

LukasKalbertodt commented Apr 6, 2020

bors commented Apr 6, 2020

joshtriplett commented Apr 14, 2020