expose suggestions::InferCtxtExt for clippy #70821
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
|
This looks fine to me, but I'll pass on to the reviewer of rust-lang/rust-clippy#5423 to make sure this is the right change (e.g. r? @eddyb |
|
LGTM with @varkor's nit fixed. |
…s.rs Co-Authored-By: varkor <github@varkor.com>
|
Thanks guys! |
|
@bors r+ rollup |
|
📌 Commit 57a6b7b has been approved by |
bors
added
S-waiting-on-bors
…xt, r=eddyb expose suggestions::InferCtxtExt for clippy This is very useful to do good async/await diagnostic reporting, for example for rust-lang/rust-clippy#5423.
…xt, r=eddyb expose suggestions::InferCtxtExt for clippy This is very useful to do good async/await diagnostic reporting, for example for rust-lang/rust-clippy#5423.
…xt, r=eddyb expose suggestions::InferCtxtExt for clippy This is very useful to do good async/await diagnostic reporting, for example for rust-lang/rust-clippy#5423.
Rollup of 5 pull requests Successful merges: - rust-lang#70612 (Add io::Write::write_all_vectored) - rust-lang#70690 (Clean up E0501 explanation) - rust-lang#70821 (expose suggestions::InferCtxtExt for clippy) - rust-lang#70839 (clean up E0506 explanation) - rust-lang#70859 (Move sanitize-inline-always test to sanitize directory) Failed merges: r? @ghost
This is very useful to do good async/await diagnostic reporting, for example for rust-lang/rust-clippy#5423.