Point at the return type on .into() failure caused by ?
#71409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/librustc_trait_selection/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
|
r=me with nits addressed. |
petrochenkov
added
S-waiting-on-author
estebank
force-pushed
the
point-at-ret-question-mark-op
branch
from
711676f
to
be90f90
Compare
|
@bors r=petrochenkov |
|
📌 Commit be90f90 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#68716 (Stabilize `Span::mixed_site`) - rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader) - rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`) - rust-lang#71419 (add message for resolution failure because wrong namespace) - rust-lang#71438 (Tweak some suggestions in `rustc_resolve`) - rust-lang#71589 (remove Unique::from for shared pointer types) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35946.