Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check non-Send/Sync upvars captured by generator #71923

Merged
merged 7 commits into from
May 20, 2020
Merged

Check non-Send/Sync upvars captured by generator #71923

merged 7 commits into from
May 20, 2020

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented May 5, 2020

Closes #70818
r? @tmandry

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
tmandry
tmandry requested changes May 5, 2020
View reviewed changes
Copy link
Member

@tmandry tmandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! I left a few minor comments.

src/librustc_typeck/check/generator_interior.rs Outdated Show resolved Hide resolved
src/test/ui/async-await/issue-70818.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/generator_interior.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/generator_interior.rs Outdated Show resolved Hide resolved
src/test/ui/async-await/issue-70818.rs Outdated Show resolved Hide resolved
@csmoe csmoe changed the title Record upvars in generator interior Check non-Send/Sync upvars captured by generator May 6, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2020
@tmandry
Copy link
Member

tmandry commented May 19, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 19, 2020

📌 Commit c9e1465 has been approved by tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 20, 2020
@Dylan-DPC
Rollup merge of rust-lang#71923 - csmoe:issue-70818, r=tmandry
7a9e286 
Check non-Send/Sync upvars captured by generator

Closes rust-lang#70818
r? @tmandry
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 20, 2020
Closed
@bors
Copy link
Contributor

bors commented May 20, 2020

⌛ Testing commit c9e1465 with merge f182c4a...

@bors
Copy link
Contributor

bors commented May 20, 2020

☀️ Test successful - checks-azure
Approved by: tmandry
Pushing f182c4a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2020
@bors bors merged commit f182c4a into rust-lang:master May 20, 2020
@bors bors mentioned this pull request May 20, 2020
Merged
@csmoe csmoe deleted the issue-70818 branch May 27, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmandry tmandry tmandry approved these changes

Assignees

@tmandry tmandry

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

note_obligation_cause reporting for non-async/await not optimal
5 participants
@csmoe @rust-highfive @tmandry @bors @joelpalmer