Show default values for debug-assertions & debug-assertions-std #72382
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| @@ -312,11 +312,11 @@ | |||
|
|
|||
| # Whether or not debug assertions are enabled for the compiler and standard | |||
| # library. | |||
| #debug-assertions = false | |||
| #debug-assertions = debug | |||
There was a problem hiding this comment.
is this legal syntax if you uncomment it?
There was a problem hiding this comment.
It is invalid when uncommented. But I think it is valuable to indicate how default value is obtained, and similar approach is already used for other options.
|
Hmm, ok. I agree it's useful though I'm surprised we would permit syntax that can't be uncommented. But if we follow the same approach elsewhere, seems ok. |
|
@bors r+ rollup=always |
|
📌 Commit 6778c7a has been approved by |
bors
added
S-waiting-on-bors
…s, r=nikomatsakis Show default values for debug-assertions & debug-assertions-std
…s, r=nikomatsakis Show default values for debug-assertions & debug-assertions-std
Rollup of 7 pull requests Successful merges: - rust-lang#72055 (Intern predicates) - rust-lang#72149 (Don't `type_of` on trait assoc ty without default) - rust-lang#72347 (Make intra-link resolve links for both trait and impl items) - rust-lang#72350 (Improve documentation of `slice::from_raw_parts`) - rust-lang#72382 (Show default values for debug-assertions & debug-assertions-std) - rust-lang#72421 (Fix anchor display when hovering impl) - rust-lang#72425 (fix discriminant_value sign extension) Failed merges: r? @ghost
No description provided.