Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor display when hovering impl #72421

Merged
merged 1 commit into from
May 22, 2020

Conversation

GuillaumeGomez
Copy link
Member

A little gif for the fixed behaviour:

hover-anchor

r? @kinnison

@kinnison
Copy link
Contributor

Assuming green CI, r=me

@GuillaumeGomez
Copy link
Member Author

@bors: r=kinnison rollup

@bors
Copy link
Contributor

bors commented May 21, 2020

📌 Commit 20b499c has been approved by kinnison

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 21, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
This was referenced May 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#72055 (Intern predicates)
 - rust-lang#72149 (Don't `type_of` on trait assoc ty without default)
 - rust-lang#72347 (Make intra-link resolve links for both trait and impl items)
 - rust-lang#72350 (Improve documentation of `slice::from_raw_parts`)
 - rust-lang#72382 (Show default values for debug-assertions & debug-assertions-std)
 - rust-lang#72421 (Fix anchor display when hovering impl)
 - rust-lang#72425 (fix discriminant_value sign extension)

Failed merges:

r? @ghost
@bors bors merged commit fc729d0 into rust-lang:master May 22, 2020
@GuillaumeGomez GuillaumeGomez deleted the fix-impl-hover-anchor branch May 22, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants