Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add associated consts MIN/MAX for Wrapping<Int> #72891

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add associated consts MIN/MAX for Wrapping<Int> #72891

merged 1 commit into from
Jun 2, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 1, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2020
@tesuji tesuji marked this pull request as draft June 1, 2020 17:07
@tesuji
Copy link
Contributor Author

tesuji commented Jun 1, 2020

r? @sfackler

@tesuji tesuji marked this pull request as ready for review June 1, 2020 17:13
@sfackler
Copy link
Member

sfackler commented Jun 1, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2020

📌 Commit b2c4469 has been approved by sfackler

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2020
@leonardo-m
Copy link

One use case?

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 2, 2020
@Dylan-DPC
Rollup merge of rust-lang#72891 - lzutao:wrapping_int-max, r=sfackler
371e8b7 
Add associated consts MIN/MAX for Wrapping<Int>
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 2, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Jun 2, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 2, 2020
@bors
Auto merge of rust-lang#72905 - JohnTitor:rollup-phtyo5i, r=JohnTitor
10c2316 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#72775 (Return early to avoid ICE)
 - rust-lang#72795 (Add a test for `$:ident` in proc macro input)
 - rust-lang#72822 (remove trivial calls to mk_const)
 - rust-lang#72825 (Clarify errors and warnings about the transition to the new asm!)
 - rust-lang#72827 (changed *nix to Unix-like)
 - rust-lang#72880 (Clean up E0637 explanation)
 - rust-lang#72886 (Remove allow missing_debug_implementations for MaybeUninit)
 - rust-lang#72889 (rustc: Remove the `--passive-segments` LLD flag on wasm)
 - rust-lang#72891 (Add associated consts MIN/MAX for Wrapping<Int>)
 - rust-lang#72893 (test miri-unleash TLS accesses)

Failed merges:

r? @ghost
@bors bors merged commit f388007 into rust-lang:master Jun 2, 2020
@tesuji tesuji deleted the wrapping_int-max branch June 2, 2020 07:55
@tesuji
Copy link
Contributor Author

tesuji commented Jun 10, 2020 •
edited
Loading

@leonardo-m

One use case?

This should be asked in a separate issue and cc to #32463 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tesuji @rust-highfive @sfackler @bors @leonardo-m @hanna-kruppe