Rollup of 6 pull requests #72903
Closed
Rollup of 6 pull requests #72903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes unnecessary calls to `grow` when the allocation would fit exactly in the remaining space.
They are pointless. No reasonable allocator will be able to satisfy a `reserve_in_place` request that *doubles* the size of an allocation when dealing with allocations that are 4 KiB and larger. Just to be sure, I confirmed on Linux that the `reserve_in_place` calls never succeed. (Note however that the `reserve_in_place` call for `DroplessArena::grow` did occasionally succeed prior to the off-by-one fix in the previous commit, because we would sometimes do a `reserve_in_place` request for the chunk's current size, which would trivially succeed!)
Also remove a now-unnecessary `placement` argument.
- Use `len` more consistently for the number of elements in a vector, because that's the usual name. - Use `additional` more consistently for the number of elements we want to add, because that's what `Vec::reserve()` uses. - Use `cap` consistently rather than `capacity`. - Plus a few other tweaks. This increases consistency and conciseness.
It already has a Debug implementation.
…ace, r=Amanieu Remove `RawVec::reserve_in_place`. And some related clean-ups. r? @oli-obk
Return early to avoid ICE Fixes rust-lang#72766
…akis Add a test for `$:ident` in proc macro input cc rust-lang#72545 (comment)
…an-DPC Clean up E0637 explanation r? @Dylan-DPC
Remove allow missing_debug_implementations for MaybeUninit It already has a Debug implementation.
Add associated consts MIN/MAX for Wrapping<Int>
|
@bors r+ rollup=never p=6 |
|
📌 Commit 371e8b7 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 371e8b7 with merge 5ee8b41484c51ef8015e207d6c5e0ea479dae69c... |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
RawVec::reserve_in_place. #72417 (RemoveRawVec::reserve_in_place.)$:identin proc macro input #72795 (Add a test for$:identin proc macro input)Failed merges:
r? @ghost