-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #73402
Rollup of 8 pull requests #73402
Conversation
* Check for overflow when calculating the slice start & end position. * Align the pointer obtained from the allocator, ensuring that it satisfies user requested alignment (the allocator is only asked for layout compatible with u8 slice). * Remove an incorrect assertion from DroplessArena::align.
Return a pointer from `alloc_raw` instead of a slice. There is no practical use for slice as a return type and changing it to a pointer avoids forming references to an uninitialized memory.
Apparently it got changed.
Check for overflow in DroplessArena and align returned memory * Check for overflow when calculating the slice start & end position. * Align the pointer obtained from the allocator, ensuring that it satisfies user requested alignment (the allocator is only asked for layout compatible with u8 slice). * Remove an incorrect assertion from DroplessArena::align. * Avoid forming references to an uninitialized memory in DroplessArena. Helps with rust-lang#73007, rust-lang#72624.
Don't run generator transform when there's a TyErr Not sure if this might cause any problems later on, but we shouldn't be hitting codegen or const eval for the produced MIR anyways, so it should be fine. cc rust-lang#72685 (comment)
…tions, r=kinnison Re-order correctly the sections in the sidebar Before that, "trait implementations" and "implementors" titles in the sidebar were before "methods" for example. Which wasn't logical considering that the two sections come after in the "content". r? @kinnison
Use track caller for bug! macro
…num-cpus, r=Mark-Simulacrum Add more info to `x.py build --help` on default value for `-j JOBS`.
…chievink Fix typo in docs of std::mem
Use `Ipv4Addr::from<[u8; 4]>` when possible Resolve this comment: rust-lang#73331 (comment)
Fix forge-platform-support URL Apparently it got changed.
@bors p=8 r+ rollup=never |
📌 Commit b4dd6a0 has been approved by |
@Dylan-DPC I mentioned this in chat, but, please don't make rollups that "skip the queue". If the rollup is higher priority than another PR, it should contain PRs that have the same or higher priority. I.e. if the rollup is skipping past p=1 PRs, it should at least contain other p=1 PRs. These rules are mentioned under the rollup button: Additionally, the point of rollup=always PRs is that they're:
which means that they mostly should be used as "filler" in a rollup that contains other substantative PRs, the point of the rollup is to get substantative PRs landed, not to just reduce queue size. This rollup only contains two non-rollup PRs :/ |
Either wya, created a second rollup that can run after this one #73408 |
☀️ Test successful - checks-azure |
Successful merges:
x.py build --help
on default value for-j JOBS
. #73380 (Add more info tox.py build --help
on default value for-j JOBS
.)Ipv4Addr::from<[u8; 4]>
when possible #73389 (UseIpv4Addr::from<[u8; 4]>
when possible)Failed merges:
r? @ghost