Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that parallel-compiler = true causes tests to fail #76441

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Note that parallel-compiler = true causes tests to fail #76441

merged 1 commit into from
Sep 14, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 7, 2020

Mentioning #75760.

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 7, 2020
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2020
@jyn514
Copy link
Member Author

jyn514 commented Sep 7, 2020

High-five really wants you to review this PR!

@jyn514 jyn514 mentioned this pull request Sep 7, 2020
Closed
pickfire
pickfire approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 13, 2020

📌 Commit 44726ba has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2020
@jonas-schievink jonas-schievink mentioned this pull request Sep 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2020
@bors
Auto merge of rust-lang#76678 - jonas-schievink:rollup-vzl9yhx, r=jon…
f9a322a 
…as-schievink

Rollup of 12 pull requests

Successful merges:

 - rust-lang#75559 (unions: test move behavior of non-Copy fields)
 - rust-lang#76441 (Note that parallel-compiler = true causes tests to fail)
 - rust-lang#76527 (Remove internal and unstable MaybeUninit::UNINIT.)
 - rust-lang#76629 (Simplify iter zip struct doc)
 - rust-lang#76640 (Simplify SyncOnceCell's `take` and `drop`.)
 - rust-lang#76646 (Add mailmap entry)
 - rust-lang#76651 (Remove Windows details from Unix and VmWorks symlink() docstrings)
 - rust-lang#76663 (Simplify iter chain struct doc)
 - rust-lang#76665 (slice::from_raw_parts: explicitly mention that data must be initialized)
 - rust-lang#76667 (Fix CI LLVM to work on NixOS out of the box)
 - rust-lang#76668 (Add visualization of rustc span in doc)
 - rust-lang#76677 (note that test_stable_pointers does not reflect a stable guarantee)

Failed merges:

r? `@ghost`
@bors bors merged commit 581524e into rust-lang:master Sep 14, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 14, 2020
@jyn514 jyn514 deleted the parallel branch November 7, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jyn514 @rust-highfive @jonas-schievink @bors @pickfire @nikomatsakis @rustbot