Rollup of 12 pull requests #76678
Merged
Rollup of 12 pull requests #76678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it is no longer necessary, as uninit_array() can be used instead in the few cases where it was needed.
Without this, it was not inlined in SyncOnceCell::into_inner(), causing unecessary checks and dead code.
This note is not relevant to other operating systems.
It took me quite some time to figure out what Span::to means. A picture is worth a thousand words.
unions: test move behavior of non-Copy fields This test ensures the behaviors suggested by @petrochenkov [here](#32836 (comment)).
Note that parallel-compiler = true causes tests to fail Mentioning #75760.
…onas-schievink Remove internal and unstable MaybeUninit::UNINIT. Looks like it is no longer necessary, as `uninit_array()` can be used instead in the few cases where it was needed. (I wanted to just add `#[doc(hidden)]` to remove clutter from the documentation, but looks like it can just be removed entirely.)
Simplify iter zip struct doc
…r=matklad Simplify SyncOnceCell's `take` and `drop`. Prevents copies by using `assume_init_read` and `assume_init_drop`.
Add mailmap entry
…=Mark-Simulacrum Remove Windows details from Unix and VmWorks symlink() docstrings This note is not relevant to other operating systems.
Simplify iter chain struct doc
slice::from_raw_parts: explicitly mention that data must be initialized This reflects the status quo, until the discussion in rust-lang/unsafe-code-guidelines#77 reaches a conclusion.
Fix CI LLVM to work on NixOS out of the box r? @Mark-Simulacrum Tested locally, seems to work!
Add visualization of rustc span in doc It took me quite some time to figure out what Span::to means. A picture is worth a thousand words.
note that test_stable_pointers does not reflect a stable guarantee Just to be sure...
|
@bors r+ p=12 rollup=never |
|
📌 Commit fe716d0 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
takeanddrop. #76640 (Simplify SyncOnceCell'stakeanddrop.)Failed merges:
r? @ghost