Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Default::default() for atomics #78621

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Inline Default::default() for atomics #78621

merged 1 commit into from
Nov 1, 2020

Conversation

solson
Copy link
Member

@solson solson commented Nov 1, 2020

Functions like AtomicUsize::default() are not cross-crate inlineable before this PR (see assembly output here), which can lead to unexpected performance issues when initializing a large array using this function, e.g. as seen here which should turn into a simple loop writing zeroes but doesn't.

r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit e5b1f69 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#78073 (Add #[inline] to some functions in core::str.)
 - rust-lang#78596 (Fix doc links to std::fmt)
 - rust-lang#78599 (Add note to process::arg[s] that args shouldn't be escaped or quoted)
 - rust-lang#78602 (fix various aliasing issues in the standard library)
 - rust-lang#78603 (expand: Tweak a comment in implementation of `macro_rules`)
 - rust-lang#78621 (Inline Default::default() for atomics)

Failed merges:

r? `@ghost`
@bors bors merged commit 97678b8 into rust-lang:master Nov 1, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 1, 2020
@solson solson deleted the inline branch November 1, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants