Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[inline] to some functions in core::str. #78073

Merged
merged 3 commits into from
Nov 1, 2020

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Oct 18, 2020

Almost all str functions already had #[inline].

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020
@jyn514 jyn514 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 19, 2020
@eddyb
Copy link
Member

eddyb commented Nov 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2020

📌 Commit cc850ec has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
@bors
Copy link
Contributor

bors commented Nov 1, 2020

⌛ Testing commit cc850ec with merge bef0b605069505374b598c47af5f737890fd328a...

@bors
Copy link
Contributor

bors commented Nov 1, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 1, 2020
@m-ou-se
Copy link
Member Author

m-ou-se commented Nov 1, 2020

CI ran into the same issue as here: #78280 (comment)

Seems to happen only sometimes..

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#78073 (Add #[inline] to some functions in core::str.)
 - rust-lang#78596 (Fix doc links to std::fmt)
 - rust-lang#78599 (Add note to process::arg[s] that args shouldn't be escaped or quoted)
 - rust-lang#78602 (fix various aliasing issues in the standard library)
 - rust-lang#78603 (expand: Tweak a comment in implementation of `macro_rules`)
 - rust-lang#78621 (Inline Default::default() for atomics)

Failed merges:

r? `@ghost`
@bors
Copy link
Contributor

bors commented Nov 1, 2020

⌛ Testing commit cc850ec with merge e8cbaf2...

@bors bors merged commit 835310e into rust-lang:master Nov 1, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants